- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix Remove Storage error message(#863097)
by mlipchuk＠redhat.com 20 Dec '12

20 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix Remove Storage error message(#863097) ...................................................................... core: Fix Remove Storage error message(#863097) setActionMessageParameters() was not set for RemoveStorageDomainCommand, nor for base class StorageDomainCommandBase(). When the lock could not be acquired in CommandBase.acquireLockInternal() both VAR__TYPE__STORAGE__DOMAIN and VAR__ACTION__REMOVE were not added to the VdcBllMessages, resulting in ${action} and ${type} appearing in the error message. This patch implements setActionMessageParameters() in StorageDomainCommandBase and in RemoveStorageDomainCommand, and removes the setting of VAR__TYPE__STORAGE__DOMAIN and VAR__ACTION__REMOVE in other flows, as it is not needed there anymore. Adjusted and added tests, also added assert messages in CommandAssertUtils. Change-Id: I8b737545c0519cc2034bb6eec36afcc38da26059 Bug-Url: https://bugzilla.redhat.com/863097 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandAssertUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 5 files changed, 34 insertions(+), 22 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/10265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b737545c0519cc2034bb6eec36afcc38da26059 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing SPM election in case that we have IrsNoMaster...
by mkublin＠redhat.com 20 Dec '12

20 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing SPM election in case that we have IrsNoMasterDomainException ...................................................................... engine: Fixing SPM election in case that we have IrsNoMasterDomainException The following patch should add a current host to tried ones, otherwise the host will not be added and in case of throwing IrsNoMasterDomainException we will never trigger a reconstruct and will continue to perfrom a spm election for next 5 minutes. The error is that list of tried ids is left empty Change-Id: I14af7f4459b54a0d74bece777d72da8b1a0e2b84 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14af7f4459b54a0d74bece777d72da8b1a0e2b84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add clear message for live snapshot fail
by amureini＠redhat.com 19 Dec '12

19 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: add clear message for live snapshot fail ...................................................................... core: add clear message for live snapshot fail Add a new, clear message when live snapshot fails for a host which is up in a data center with compatibility version 3.0. Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a Bug-Url: https://bugzilla.redhat.com/873156 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 24 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract code to methods in ImagesHandler
by amureini＠redhat.com 19 Dec '12

19 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extract code to methods in ImagesHandler ...................................................................... core: Extract code to methods in ImagesHandler Extract code to isVMDown and checking for storage pool validity to external methods to make PerformImagesChecks more readable. Change-Id: I363f7bf24ca9b5d408a61ba9159b6e5f2a5c46e0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 22 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363f7bf24ca9b5d408a61ba9159b6e5f2a5c46e0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cpu host feature
by dfediuck＠redhat.com 19 Dec '12

19 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: cpu host feature ...................................................................... engine: cpu host feature Adds the engine-side support for cpu-host feature http://www.ovirt.org/Features/Cpu-host_Support Bug-Url: https://bugzilla.redhat.com/838469 Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0090_cpuhost_support.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/CpuMode.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 27 files changed, 158 insertions(+), 18 deletions(-) Approvals: Laszlo Hornyak: Verified Greg Padgett: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: windows 8/2012 default user portal console shoul...
by tjelinek＠redhat.com 19 Dec '12

19 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: windows 8/2012 default user portal console should be RDP ...................................................................... userportal: windows 8/2012 default user portal console should be RDP Since windows 8/2012 don't have spice drivers yet, default in user portal should be rdp. Default in admin will stay spice. This default is recalculated if the OS type or the default console changes Change-Id: I019f3f80e020a85fb6b2ae8a855a0c3fe89ba1d6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleSelectionContext.java 4 files changed, 88 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I019f3f80e020a85fb6b2ae8a855a0c3fe89ba1d6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Audit log messages file EOLs set to Unix
by yzaslavs＠redhat.com 19 Dec '12

19 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Audit log messages file EOLs set to Unix ...................................................................... webadmin: Audit log messages file EOLs set to Unix Change-Id: If119bb5fd0119ea8c8fad54feedd729a43b23cff Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 560 insertions(+), 560 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If119bb5fd0119ea8c8fad54feedd729a43b23cff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added single vm uptime br46 (#862019)
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added single vm uptime br46 (#862019) ...................................................................... reports: added single vm uptime br46 (#862019) This report contains one gauge displaying the weighted average uptime of a single selected VM for a requested period. Bug-Url: https://bugzilla.redhat.com/862019 Change-Id: I50951e7380be136162bb2beb86ec0ed4bbe46d1e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Service_level/VMs/.folder.xml A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46.xml A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/full details.jrxml.data A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/single_vm_uptime_br46_jrxml.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 5 files changed, 746 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50951e7380be136162bb2beb86ec0ed4bbe46d1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding force option to remove host
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding force option to remove host ...................................................................... webadmin: Adding force option to remove host 'Force Remove' checkbox will be shown while removing a host from a gluster only cluster. This is supported for mutiple hosts removals as well, but all the selected hosts should belong to a single gluster cluster. If the user selects force, it internally passes 'force' option to 'gluster peer detach' command. Change-Id: I9fe3814815acff8a5f230c1a3d6ebcb6e3bbc633 Bug-Url: https://bugzilla.redhat.com/882807 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConfirmationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 51 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fe3814815acff8a5f230c1a3d6ebcb6e3bbc633 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix cluster dialog hang during import
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix cluster dialog hang during import ...................................................................... webadmin: Fix cluster dialog hang during import 1. Cluster dialog was hanging when wrong password is given for the host. This is fixed now. An error message will be shown in case of wrong credentials. 2. If the servers which the user is trying to import is already part of another cluster, an error message will be shown. Change-Id: I717a9aa953f2c8bc41676c2cf91267e38328245f Bug-Url: https://bugzilla.redhat.com/883147 Bug-Url: https://bugzilla.redhat.com/884292 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I717a9aa953f2c8bc41676c2cf91267e38328245f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0