- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: NPE in OsTypeImage
by tjelinek＠redhat.com 19 Dec '12

19 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: NPE in OsTypeImage ...................................................................... userportal: NPE in OsTypeImage The OsTypeImage creates the name of the default OS type like: "otherOs" + nameUniquePart + IMAGE, where the IMAGE is "Image", the nameUniquePart is "Large" or "Small". Than takes this name and looks up the specific image from the ApplicationResourcesWithLookup. The probelm was, that the otherOsSmallImage was written with capital "O", which caused periodic NPE thrown on FE. Fixed by expecting the "OtherOs..." on OsTypeImage and adjusted also other names in ApplicationResourcesWithLookup. Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/OsTypeImage.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: changed tabs to spaces
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changed tabs to spaces ...................................................................... reports: changed tabs to spaces Change-Id: I4c330663d31cd1d560bc6fd49cde9c06a5981ae5 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/full details.jrxml.data 2 files changed, 617 insertions(+), 617 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c330663d31cd1d560bc6fd49cde9c06a5981ae5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added user spice session activity report (#880581)
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added user spice session activity report (#880581) ...................................................................... reports: added user spice session activity report (#880581) This report contains a table detailing user spice activity with regards to time spent and resources used in the session in the selected data center and cluster and within the selected period. Bug-Url: https://bugzilla.redhat.com/880581 Change-Id: I3e2d0ad2ab2cbb7ea14f2d794b921e1932e014f2 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/.folder.xml A reports/repository_files/resources/Reports/users_usage/.folder.xml A reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45.xml A reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/full details.jrxml.data A reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/users_spice_sessions_activity_br45_jrxml.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 6 files changed, 939 insertions(+), 17 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2d0ad2ab2cbb7ea14f2d794b921e1932e014f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: handle engine at loopback (all-in-one)
by Alon Bar-Lev 19 Dec '12

19 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: handle engine at loopback (all-in-one) ...................................................................... vdsm: bridge: handle engine at loopback (all-in-one) When engine is at loopback we cannot create the bridge normally, as lo cannot be added to a bridge. As a workaround we create an empty bridge with loopback address of 127.0.0.2. Change-Id: Ie96d40c41c2d72921407bfb7d132bdfccb1b84ac Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 18 insertions(+), 57 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie96d40c41c2d72921407bfb7d132bdfccb1b84ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix NPE in VM list models
by vszocs＠redhat.com 19 Dec '12

19 Dec '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Fix NPE in VM list models ...................................................................... userportal: Fix NPE in VM list models Change-Id: Ib9968567971141bf3e0b95c2220ec403555fafbd Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9968567971141bf3e0b95c2220ec403555fafbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM ...
by asaf＠redhat.com 18 Dec '12

18 Dec '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg ...................................................................... engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg Specified error level for USER_FAILED_ATTACH_DISK_TO_VM message. The error level for instance affects the visual representation of the message in the webadmin interface. Change-Id: Id0202766ecae08a0bfa78a149f089d3e4bf96f52 Bug-Url: https://bugzilla.redhat.com/848367 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0202766ecae08a0bfa78a149f089d3e4bf96f52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Quota Monitors - userportal
by gchaplik＠redhat.com 18 Dec '12

18 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Quota Monitors - userportal ...................................................................... userportal: Quota Monitors - userportal This patch is the 3rd out of 3. SideTabExtendedResourcesView was changed to include Quota Monitors (see full details on feature page - wiki.ovirt.org/Features/Design/Quota-3.2) ResourcesModel was changed to support the UI change A new Widget QuotaProgressBar was designed for the monitors. Change-Id: Idbecbf9233704c2cd5e485f3c4158c9a78559218 Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 11 files changed, 833 insertions(+), 152 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbecbf9233704c2cd5e485f3c4158c9a78559218 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Quota Monitors - webadmin
by gchaplik＠redhat.com 18 Dec '12

18 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Quota Monitors - webadmin ...................................................................... webadmin: Quota Monitors - webadmin This patch is the 2nd out of 3. Quota monitoring is added to the webadmin as columns in the MainTabQuotaView. Change-Id: I39aaf87f084a31b6ff31412030517a2f19bbe1af Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaPercentColumn.java 3 files changed, 228 insertions(+), 32 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39aaf87f084a31b6ff31412030517a2f19bbe1af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Quota Monitors - backend
by gchaplik＠redhat.com 18 Dec '12

18 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Quota Monitors - backend ...................................................................... engine: Quota Monitors - backend This patch is the 1st out of 3. It sets the backend support for adding Quota Monitoring to the UI. a new entity is defined "QuotaPerUserUsageEntity" - to allow passing usage data to the UI. Two new methods are added to the QuotaManager API in order to allow using the QuotaManager cache for the monitoring in the UI. Two Querier are also changed to support the new data and API Change-Id: I67770aefec191832d0c5bb69fbaba82cd0e6febb Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotasConsumptionForCurrentUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaUsagePerUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotasConsumptionForCurrentUserQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 8 files changed, 467 insertions(+), 8 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67770aefec191832d0c5bb69fbaba82cd0e6febb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: removed unused columns.
by ydary＠redhat.com 18 Dec '12

18 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: removed unused columns. ...................................................................... history: removed unused columns. Change-Id: I95f6906702e561bbcddd9d334d2760b875651b9f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_views_3_2.sql M data-warehouse/historydbscripts_postgres/upgrade/03_02_0010_add_vm_users_usage_tables.sql 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f6906702e561bbcddd9d334d2760b875651b9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0