- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Removing jdk7 extended CTOR
by yzaslavs＠redhat.com 03 Dec '12

03 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Removing jdk7 extended CTOR ...................................................................... core: Removing jdk7 extended CTOR Change-Id: If25ef37b0d9ff79737e7dfe8283322acb70b1dcb Bug-Url: https://bugzilla.redhat.com/878964 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/exceptions/InitializationException.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25ef37b0d9ff79737e7dfe8283322acb70b1dcb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing unused code GetAvailableClusterVersionsQuer...
by mkublin＠redhat.com 03 Dec '12

03 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing unused code GetAvailableClusterVersionsQuery ...................................................................... engine: Removing unused code GetAvailableClusterVersionsQuery Looks like that no one is using that query, so removing it Change-Id: If60af12692a532d25311db64fb547a57f4a8052e Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableClusterVersionsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableClusterVersionsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java 5 files changed, 0 insertions(+), 112 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If60af12692a532d25311db64fb547a57f4a8052e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed useless checks at ConnectHostToStoragePoolSe...
by mkublin＠redhat.com 03 Dec '12

03 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand ...................................................................... engine: Removed useless checks at ConnectHostToStoragePoolServersCommand The following checks at canDoaction are useless, the command is called only once form InitVdsOnUp and the same checks are performed before a call to command Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java 1 file changed, 21 insertions(+), 27 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing last host in status UP in pool
by mkublin＠redhat.com 03 Dec '12

03 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing last host in status UP in pool ...................................................................... core: Removing last host in status UP in pool If host can not connect to storage it will be moved to Non-Operational. A reson that host was left at sttaus UP was to use it as fence agent when it is the only host at pool, it is possible to use a non-operational host as fence agent Change-Id: I42b3b45e882fe84eb869c82fe83eadb7c1da5152 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 6 files changed, 25 insertions(+), 79 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42b3b45e882fe84eb869c82fe83eadb7c1da5152 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Introduction and usage of CustomPropertiesValueHelper
by yzaslavs＠redhat.com 03 Dec '12

03 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Introduction and usage of CustomPropertiesValueHelper ...................................................................... tools: Introduction and usage of CustomPropertiesValueHelper The following patch introduces the CustomPropertiesValueHelper to be used with UserdefinedVmProperties. In order to provide a more accurate description, validate method is changed to return a ValidationResult object that contains a descriptive message. engine-config.properties is changed accordingly. Bug-Id: https://bugzilla.redhat.com/ 878964 Change-Id: Ieffbc359880e87a7159906579a18b2e5c63bd718 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java A backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java A backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/ValidationResult.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 11 files changed, 107 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieffbc359880e87a7159906579a18b2e5c63bd718 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmPropertiesUtils should be initialized via StartupBea...
by yzaslavs＠redhat.com 03 Dec '12

03 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: VmPropertiesUtils should be initialized via StartupBean ...................................................................... core: VmPropertiesUtils should be initialized via StartupBean This patch fixes VmPropertiesUtils to be initialized at StartUpBean. This is a first patch in series (the 2nd part will be dealing with validations at engine-config) Change-Id: If25ef37b0d9ff79737e7efe8283372aca70b0dcb Bug-Id: https://bugzilla.redhat.com/878694 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/exceptions/InitializationException.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java 3 files changed, 72 insertions(+), 27 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25ef37b0d9ff79737e7efe8283372aca70b0dcb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Allow e1000 nic type for Windows VM
by tjelinek＠redhat.com 03 Dec '12

03 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Allow e1000 nic type for Windows VM ...................................................................... userportal,webadmin: Allow e1000 nic type for Windows VM Because of some licencing issues, the e1000 NIC was not allowed to be selected for the windows VMs. As this has been solved now, enabling it again. Change-Id: I9d7a943c588596062ebd660211fd3e71e925f131 Bug-Url: https://bugzilla.redhat.com/838470 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d7a943c588596062ebd660211fd3e71e925f131 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: importing/removing newly detected gluster hosts
by gchaplik＠redhat.com 03 Dec '12

03 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: importing/removing newly detected gluster hosts ...................................................................... webadmin: importing/removing newly detected gluster hosts An alert will be shown in the Cluster General tab when there new hosts which were added to the cluster through gluster cli(gluster peer probe) and they are not available in the ovirt engine. On clicking of the alert, a dialog will be shown with the new hosts along with their fingerprints. User will provide the passwords for them and save. Change-Id: I7afc2823d59c510d6e6aabd78e9be1d3c2ed082e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/DetachGlusterHostsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/DetachGlusterHostsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/DetachGlusterHostsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/DetachGlusterHostsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml 14 files changed, 786 insertions(+), 40 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7afc2823d59c510d6e6aabd78e9be1d3c2ed082e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding "Select All" checkbox header to CellTable
by gchaplik＠redhat.com 03 Dec '12

03 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding "Select All" checkbox header to CellTable ...................................................................... webadmin: Adding "Select All" checkbox header to CellTable EntityModelCellTable and IVdcQueryableCellTable are enhanced to support a "Select All" functionality by providing a Checkbox in the header of the selection column. The Checkbox will be shown only if the CellTable supports multiselection and the showSelectAllCheckbox is true. Change-Id: I7f9f303143ecb322a6d325a56c3b97a23b3253c6 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IVdcQueryableCellTable.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SelectAllCheckBoxHeader.java 4 files changed, 147 insertions(+), 7 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f9f303143ecb322a6d325a56c3b97a23b3253c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hiding Dashboard and Quota tabs in Gluster-only mo...
by gchaplik＠redhat.com 03 Dec '12

03 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Hiding Dashboard and Quota tabs in Gluster-only mode ...................................................................... webadmin: Hiding Dashboard and Quota tabs in Gluster-only mode Dashboard and Quota tabs will not be shown when running the application with ApplicationMode=GlusterOnly. Change-Id: Ib30d9bf297ddbc1b49565d19b16951e58736d1ab Bug-Url: https://bugzilla.redhat.com/838906 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib30d9bf297ddbc1b49565d19b16951e58736d1ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0