- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RFE: allow to define deletion protection per vm
by tjelinek＠redhat.com 04 Dec '12

04 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: core: RFE: allow to define deletion protection per vm ...................................................................... core: RFE: allow to define deletion protection per vm This patch introduces protection from unwanted deletion of VMs/Templates. Each VM/Template will have a boolean flag representing if the VM/Template is delete protected. If this flag is set to true, the backend will prevent deletion of corresponding entity. On backend it affects - vm_static table in database will have a new boolean column "delete_protected" with default value FALSE - Ovf export/import - new field DeleteProtected - corresponding entities, db classes (DAOs, row mapper) Change-Id: I878f32506e0aececb7947b2db5c63cf0cc0980b5 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871371 --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1540_add_delete_protection.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 21 files changed, 89 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I878f32506e0aececb7947b2db5c63cf0cc0980b5 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: reformat remove disk messages
by ecohen＠redhat.com 04 Dec '12

04 Dec '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: reformat remove disk messages ...................................................................... webadmin: reformat remove disk messages In addition to reformating the "remove disk" messages in order to ease their translation to the other locales, the "diskNote" key has been removed from all the non-English .properties files, as the old values contain variables-placeholders that don't exist in the source (English) string anymore. The "diskNote" updated translations will be pushed in a separate patch. Change-Id: I20172c8e70659a6fa5f77dec738d1c9025daac70 Bug-Id: https://bugzilla.redhat.com/871222 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_es.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_fr.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_ja.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_zh_CN.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_es.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_es.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_zh_CN.properties 16 files changed, 16 insertions(+), 26 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20172c8e70659a6fa5f77dec738d1c9025daac70 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: generate entry-point (/api) methods
by mpastern＠redhat.com 04 Dec '12

04 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: generate entry-point (/api) methods ...................................................................... codegen: generate entry-point (/api) methods Change-Id: I40926576bf9c0df0aa847e64cfb7878e6546e05e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java M java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractTemplate.java M java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate A java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/RootResourceDynamicTemplate A java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/RootResourceDynamicTemplate.java A java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/RootResourceStaticTemplate A java-sdk-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/RootResourceStaticTemplate.java M java-sdk/src/main/java/org/ovirt/engine/sdk/Api.java M java-sdk/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java 9 files changed, 1,422 insertions(+), 1,207 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40926576bf9c0df0aa847e64cfb7878e6546e05e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Added APT package list support
by bazulay＠redhat.com 04 Dec '12

04 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: Added APT package list support ...................................................................... agent: Added APT package list support The newly added functionality allows the guest agent to report installed packages and their version even on systems with APT package managers (e.g Debian) or both RPM + APT side by side. Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/ovirt-guest-agent.conf 2 files changed, 54 insertions(+), 7 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Jarod.w <work.iec23801(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix empty quota in updateVM pass
by dfediuck＠redhat.com 04 Dec '12

04 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix empty quota in updateVM pass ...................................................................... core: Fix empty quota in updateVM pass When vm is running and have no quota, updateVM does not check quota validity for empty quota. The rule for adding quotaConsumptionParameter was changed so that null or empty quota would be passed to the QuotaManager for validation. Change-Id: I5b4c782c7c2dd3a70a19e8ed82ab5e180495eb6d Bug-Url: https://bugzilla.redhat.com/882809 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b4c782c7c2dd3a70a19e8ed82ab5e180495eb6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: remove python syntax checks
by Alon Bar-Lev 04 Dec '12

04 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: remove python syntax checks ...................................................................... packaging: remove python syntax checks Change-Id: Ief73920695726f31cb62fd6d7212b0a8d58c4f4f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief73920695726f31cb62fd6d7212b0a8d58c4f4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: remove python syntax checks
by Alon Bar-Lev 04 Dec '12

04 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: remove python syntax checks ...................................................................... packaging: remove python syntax checks Change-Id: I77a7a9d2fd57b7d8a82282e5874699e6871c4055 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a7a9d2fd57b7d8a82282e5874699e6871c4055 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core:encrypt vds_static pm_password field on ..."
by emesika＠redhat.com 04 Dec '12

04 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core:encrypt vds_static pm_password field on ..." ...................................................................... Revert "core:encrypt vds_static pm_password field on ..." This reverts commit 4f1e4704c169664bde1c128e718dbdc4a94a99a3 This change was supposed to be d/s Only and was pushed upstream as a result of misunderstanding between me & Moran G --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifebdee1ea19cbfa8ef1a28ace77c33ef81c39372 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: switch tab with space key
by tjelinek＠redhat.com 04 Dec '12

04 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: switch tab with space key ...................................................................... userportal,webadmin: switch tab with space key It is now possible to switch tab in a dialog that contains multiple tabs by pressing the space key when the header of the tab we want to switch to is focused Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Ordering Networks by Name
by msalem＠redhat.com 04 Dec '12

04 Dec '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Ordering Networks by Name ...................................................................... engine: Ordering Networks by Name This patch changes the underlying query of NetworkDAO.getAllForCluster to return a list ordered by network name, to be presented that way in the client. Change-Id: I309c66afb9785226c9cbb9d753175504fd3203fe Bug-Url: https://bugzilla.redhat.com/855886 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I309c66afb9785226c9cbb9d753175504fd3203fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0