- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: SanStorageLunToTargetList FindBugs
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SanStorageLunToTargetList FindBugs ...................................................................... webadmin: SanStorageLunToTargetList FindBugs Solved FindBugs warning RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE. The items variable is clearly not null here, since isEmpty() is called on it beforehand, so the conditional statement can be safely removed. Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4623dfb81aa3354d761536f35f351bd58964a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "userportal: SearchResultsLimit race condition (#8539...
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: Revert "userportal: SearchResultsLimit race condition (#853904)" ...................................................................... Revert "userportal: SearchResultsLimit race condition (#853904)" This reverts commit 018d88cd3dfd521fbcbb6fc1a6e3acc0c8a39a87 Causes a NPE in TagListModel during WebAdmin startup. A fixed patch will be suggested. --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java 3 files changed, 4 insertions(+), 37 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee499669af30b4b620b9fa9bd86b775b4f9e1eee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix in error message (#853704)
by yzaslavs＠redhat.com 24 Sep '12

24 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix in error message (#853704) ...................................................................... core: fix in error message (#853704) Previous patch changed the message, but there was a typo there. Fixing the message. Change-Id: I2c81dd44dd579ad1a0685a99b79df5e263c8fa0b Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c81dd44dd579ad1a0685a99b79df5e263c8fa0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: using pg_dump --column-inserts ...(#858643)
by yzaslavs＠redhat.com 24 Sep '12

24 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: using pg_dump --column-inserts ...(#858643) ...................................................................... core: using pg_dump --column-inserts ...(#858643) using pg_dump --column-inserts slows down the restore process The backup script is calling internally the postgres pg_dump utility that actually performs the backup. The backup script output is a SQL file. This file can have 2 formats for data inserts 1) COPY (per table) - efficient and fast, all data is inserted or none 2) INSERT (per table row) - slow and problematic in large databases, part of table rows may be inserted since a failure in a row does not skip the other inserts for the relevant table. This patch change the default from INSERT (option 2 above) to COPY (option 1) by: Adding additional flag to the backup.sh script -c, if this flag is set then the pg_dump is called with the --column-inserts flag, otherwise not. The default behaviour is to backup without --column-inserts in order to generate COPY statements rather than INSERT statements per table row for easy and efficient restore. Change-Id: Iac6b8a6762868b9535f24cc9c496e11722485885 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/backup.sh 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6b8a6762868b9535f24cc9c496e11722485885 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: task manager cache is not cleared..(#854308)
by emesika＠redhat.com 24 Sep '12

24 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: task manager cache is not cleared..(#854308) ...................................................................... core: task manager cache is not cleared..(#854308) task manager cache is not cleared after getting error that task does not exist from vdsm on stopTask(#854308) This patch insures that async tasks found in engine and not found by VDSM will get the 'unknown' state. The case in which there may be no SPM temporally as a result of a failure is handled differently in AsyncTaskManager and SPMGetAllTasksStatusesVDSCommand. Previous code sets all tasks that are found by engine (in cache) and not found as VDSM as running. This prevented cleanup of unknown tasks from the cache as described in BZ. https://bugzilla.redhat.com/854308 Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksStatusesVDSCommand.java 3 files changed, 15 insertions(+), 19 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Make HA consistant in VM and template tabs
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Make HA consistant in VM and template tabs ...................................................................... webadmin: Make HA consistant in VM and template tabs Problems: * Inconsistent display of the high availability value between vm and template tabs and inside the template tab Solution: * Change the display component to BooleanLabel and check the hasHighlyAvailable flag Change-Id: Ia71c1bf7af6658f880c95b566b50655a6fe0c5c5 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia71c1bf7af6658f880c95b566b50655a6fe0c5c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: spm and master domain maintenance actions cause wrong ...
by oourfali＠redhat.com 24 Sep '12

24 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: spm and master domain maintenance actions cause wrong error (#853704) ...................................................................... core: spm and master domain maintenance actions cause wrong error (#853704) When failed to acquire lock, the error message is misleading, as it clains that same action is in progress, but it is not the case. The real case is that there are two related operations that are occuring at the same time, so the user should wait for one to finish, before initiating the second one. This patch fixes this error message. Change-Id: I183ab61e1078c18b94e0faab5f1ba5074b8c9e8d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I183ab61e1078c18b94e0faab5f1ba5074b8c9e8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed Refresh to refreshModel
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Renamed Refresh to refreshModel ...................................................................... core: Renamed Refresh to refreshModel Fixes FindBugs issues - 1. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.events.EventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() 2. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.templates.UserPortalTemplateEventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() 3. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.vms.UserPortalVmEventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() Base class of EventListModel already has a function named refresh() Since here the model is being refreshed ... called it refreshModel() Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: pass HA value to template from vm
by gchaplik＠redhat.com 24 Sep '12

24 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: pass HA value to template from vm ...................................................................... webadmin: pass HA value to template from vm Problems: * When creating tamplate from vm the high availability property was lost Solution: * Assign high availability value to the model saved as template Change-Id: Iab549b81b1cccf69d79e9fae0980ad5b55690a03 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab549b81b1cccf69d79e9fae0980ad5b55690a03 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow attaching v2 domains for v3 pool (#856166)
by asaf＠redhat.com 24 Sep '12

24 Sep '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Allow attaching v2 domains for v3 pool (#856166) ...................................................................... webadmin: Allow attaching v2 domains for v3 pool (#856166) https://bugzilla.redhat.com/856166 Allow attaching v2 domains for version 3 pool. Change-Id: I58a765eb1b5d122d06111e2151325110096c1623 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58a765eb1b5d122d06111e2151325110096c1623 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0