- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor AddStorageDomainCommon cleanup
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor AddStorageDomainCommon cleanup ...................................................................... core: minor AddStorageDomainCommon cleanup removed the unnecesary temporary variable Change-Id: If6dff088dae4ab5c472c68e65c3e1ffb5d35a451 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6dff088dae4ab5c472c68e65c3e1ffb5d35a451 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: Fix stateless VM Quota double-count
by dfediuck＠redhat.com 27 Sep '12

27 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix stateless VM Quota double-count ...................................................................... core: Fix stateless VM Quota double-count The cluster quota was counted twice when running a VM in stateless mode (only when the stateless is triggered by the 'stateless' flag in the VM edit pop-up and not when its triggered by the 'stateless' flag in the Run once pop-up). Change-Id: If62d10a4e7ff0477a7cf324a28f09e4c493e5689 Bug-Url: https://bugzilla.redhat.com/854491 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/8223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If62d10a4e7ff0477a7cf324a28f09e4c493e5689 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log domain name during error in irsbroker (#854025)
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: log domain name during error in irsbroker (#854025) ...................................................................... core: log domain name during error in irsbroker (#854025) https://bugzilla.redhat.com/854025 Log storage domain GUID and name in irsbroker to make troubleshooting and debugging easier. Change-Id: Ic1943d779237c686a21ea74168ed48a0ac45c202 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 28 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1943d779237c686a21ea74168ed48a0ac45c202 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup ...................................................................... core: SyntaxChecker cleanup Use equals() instead of StringHelper.EqOp() Change-Id: Ic5f395a3a99780a73e056239b805e127ef931935 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5f395a3a99780a73e056239b805e127ef931935 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Fixing gluster volume CIFS export configuration
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fixing gluster volume CIFS export configuration ...................................................................... engine: Fixing gluster volume CIFS export configuration when the user wants to export a volume through CIFS protocol, an option 'user.cifs=on' needs to be set. There were some confusions regarding 'on' and 'off', it is fixed now. Change-Id: Ied95cf5f95a467c82d25b4499982c46a0d7c6657 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied95cf5f95a467c82d25b4499982c46a0d7c6657 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Bll Query to fetch the newly added Gluster servers
by yzaslavs＠redhat.com 27 Sep '12

27 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Bll Query to fetch the newly added Gluster servers ...................................................................... engine: Bll Query to fetch the newly added Gluster servers - Query returns servers and ssh key finger print if the parameter 'isServerKeyFingerprintRequired' is true. Change-Id: I0e010683c221abeabbb2e427a86bcf155b89b68f Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/AddedGlusterServersParameters.java 4 files changed, 274 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e010683c221abeabbb2e427a86bcf155b89b68f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ImagesHandler clenaup
by lhornyak＠redhat.com 26 Sep '12

26 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: ImagesHandler clenaup ...................................................................... core: ImagesHandler clenaup Removed usage of the deprecated StringHelper class from ImagesHandler and used apache commons' StringUtils instead. Change-Id: Ib8d73affd4a49b0c01cb0f51b50814300d7ed0ab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8d73affd4a49b0c01cb0f51b50814300d7ed0ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: ExportVmCommand clenaup
by lhornyak＠redhat.com 26 Sep '12

26 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: ExportVmCommand clenaup ...................................................................... core: ExportVmCommand clenaup Removed usage of the deprecated StringHelper class from ExortVmCommand and used apache commons' StringUtils instead. Change-Id: I5405a7cb7531208b658c450a809ec658f0fc7426 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5405a7cb7531208b658c450a809ec658f0fc7426 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: ChangeDiskCommand clenaup
by lhornyak＠redhat.com 26 Sep '12

26 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: ChangeDiskCommand clenaup ...................................................................... core: ChangeDiskCommand clenaup Removed usage of the deprecated StringHelper class from ChangeDiskCommand and used a simple equals() call on the constant string instead. Change-Id: I1173561fe3dc44d7f4d7951d5772440ac7601fd2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1173561fe3dc44d7f4d7951d5772440ac7601fd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: SnapshotsManager clenaup
by lhornyak＠redhat.com 26 Sep '12

26 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SnapshotsManager clenaup ...................................................................... core: SnapshotsManager clenaup Removed usage of the deprecated StringHelper class from SnapshotsManager and used apache commons' StringUtils instead. Change-Id: Id5d1bf885f70ce85650eb5ebbec92e9e965cbb1a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5d1bf885f70ce85650eb5ebbec92e9e965cbb1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0