- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Cleanup in QuotaModel (#848289)
by gchaplik＠redhat.com 09 Sep '12

09 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Cleanup in QuotaModel (#848289) ...................................................................... webadmin: Cleanup in QuotaModel (#848289) https://bugzilla.redhat.com/848289 Cleanup of literals. Change-Id: I30466414921d859cc6cffbcef2d80eb717ddcdde Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30466414921d859cc6cffbcef2d80eb717ddcdde Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core: fix NPE is Challenger"
by masayag＠redhat.com 09 Sep '12

09 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: fix NPE is Challenger" ...................................................................... Revert "core: fix NPE is Challenger" This reverts commit 01ee24bc2010252f71d47dc950835fccbeed0110. Reverted due to failed unit-tests. Signed-off-by: Moti Asayag <masayag(a)redhat.com> Change-Id: I2130b5f5af1d8d3167aa5b5246c58a4bc0773808 --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2130b5f5af1d8d3167aa5b5246c58a4bc0773808 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: networks typos (#854358)
by alkaplan＠redhat.com 09 Sep '12

09 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: networks typos (#854358) ...................................................................... webadmin: networks typos (#854358) https://bugzilla.redhat.com/854358 Netwrok -> Network from one the interfaces/bond -> from one of the interfaces/bond Change-Id: Ib2a235554c1357cad425fbd89f71e616821508d1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2a235554c1357cad425fbd89f71e616821508d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change gracefully shutdown message (#854218)
by rgolan＠redhat.com 09 Sep '12

09 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: change gracefully shutdown message (#854218) ...................................................................... core: change gracefully shutdown message (#854218) https://bugzilla.redhat.com/show_bug.cgi?id=854218 changed "oVirt Engine" to just "Engine" in graceful shutdown message. Change-Id: I8b4550bd3b1cb22e8a80cc0a76fcffecb81e62e5 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b4550bd3b1cb22e8a80cc0a76fcffecb81e62e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: redundant rectangle on Network Interfaces tab (#85...
by alkaplan＠redhat.com 09 Sep '12

09 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: redundant rectangle on Network Interfaces tab (#851570) ...................................................................... webadmin: redundant rectangle on Network Interfaces tab (#851570) https://bugzilla.redhat.com/851570 In host->interfaces subtab, if there is nic/bond with just vlan/s (no non vlan network). There is redundant rectangle under the vlans. Change-Id: I6f963adaee4a765c38bc2bf54f4dafe6ab442961 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java 4 files changed, 26 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f963adaee4a765c38bc2bf54f4dafe6ab442961 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change Network Error Msg (#850854)
by msalem＠redhat.com 09 Sep '12

09 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Change Network Error Msg (#850854) ...................................................................... core: Change Network Error Msg (#850854) https://bugzilla.redhat.com/850854 Changes the error message in case a Nic with a Network that is not in the Vm Host is activated. Change-Id: I7d6d866c6c260af3834119f529e4aa5c56f80f69 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d6d866c6c260af3834119f529e4aa5c56f80f69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: bootstrap: node id: sync dmidecode usage from vdsm
by bazulay＠redhat.com 09 Sep '12

09 Sep '12

Barak Azulay has submitted this change and it was merged. Change subject: bootstrap: node id: sync dmidecode usage from vdsm ...................................................................... bootstrap: node id: sync dmidecode usage from vdsm Instead of awking the full output of dmidecode, use explicit query. If output contains "Not" format is '_<MAC>' and not 'Not_<Mac>'. Remove stderr output. Change-Id: Ifeea7fc5634bb393a198c4adbebcd69cd0d8438d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 18 insertions(+), 12 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeea7fc5634bb393a198c4adbebcd69cd0d8438d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bootstrap: node id: consider bonding MAC addresses as well
by bazulay＠redhat.com 09 Sep '12

09 Sep '12

Barak Azulay has submitted this change and it was merged. Change subject: bootstrap: node id: consider bonding MAC addresses as well ...................................................................... bootstrap: node id: consider bonding MAC addresses as well The node id is constructed using the lowest MAC address. If bonding is applied after initial node id was taken, it may shade the minimal address. This change adds to the MAC addresses of bonding interfaces to the MAC address addresses to consider. Sync with vdsm, consider only physical devices (has /device). Change-Id: I31ce43972fad77c716aff915d29d6589ba205280 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31ce43972fad77c716aff915d29d6589ba205280 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: ssh: test of invalid command workaround for fedora
by bazulay＠redhat.com 09 Sep '12

09 Sep '12

Barak Azulay has submitted this change and it was merged. Change subject: utils: ssh: test of invalid command workaround for fedora ...................................................................... utils: ssh: test of invalid command workaround for fedora Due to fedora bug#676841, invalid command returns exit code of success! Change-Id: I4c41c85e81ec8c6ed847913ab04ee3d381b18522 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c41c85e81ec8c6ed847913ab04ee3d381b18522 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: do not fail if using external sshd
by bazulay＠redhat.com 09 Sep '12

09 Sep '12

Barak Azulay has submitted this change and it was merged. Change subject: utils: do not fail if using external sshd ...................................................................... utils: do not fail if using external sshd Change-Id: I4c09754e0722592198754418b71319b227cbb9b8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c09754e0722592198754418b71319b227cbb9b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0