- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bootstrap: reduce verbosity of errors in event log (#853962)
by bazulay＠redhat.com 09 Sep '12

09 Sep '12

Barak Azulay has submitted this change and it was merged. Change subject: bootstrap: reduce verbosity of errors in event log (#853962) ...................................................................... bootstrap: reduce verbosity of errors in event log (#853962) The exact command syntax is not important to user. The exact exception is not important to user. Change-Id: Ie9f0042610b16af56487cb02349a399ee0f6b093 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java 1 file changed, 21 insertions(+), 19 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f0042610b16af56487cb02349a399ee0f6b093 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adding default implementation to abstract methods
by masayag＠redhat.com 09 Sep '12

09 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adding default implementation to abstract methods ...................................................................... engine: Adding default implementation to abstract methods Commit 35c2e7ceb5109c9349e3699c3f53414cbe0b4c4e broke the build by introducing an abstract method which isn't implmemented by other non-abstract classes. Change-Id: I5a8478062b5f9ad545ad8bdf87d01fa05b6686f0 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a8478062b5f9ad545ad8bdf87d01fa05b6686f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.2.0.1-1
by mpastern＠redhat.com 09 Sep '12

09 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.1-1 ...................................................................... cli: release 3.2.0.1-1 Change-Id: I0c039927679f425f9902bf36fe9817d6cd1e530b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 11 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c039927679f425f9902bf36fe9817d6cd1e530b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: release 3.2.0.1-1
by mpastern＠redhat.com 09 Sep '12

09 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.2.0.1-1 ...................................................................... sdk: release 3.2.0.1-1 Change-Id: I97530eec09bff8f6df36194b48deedc762181e86 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97530eec09bff8f6df36194b48deedc762181e86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 09 Sep '12

09 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - to Disks.add() added /name arg - to disk.install() added r/oot_password arg - to Template.delete() added async/correlation_id args - to Template.update added documentation - to HostTags.add() added expect/correlation_id args - to VM.start added /filter header Change-Id: I46f07fa52fd3f568f69e6113a71b77daa96ac38e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 320 insertions(+), 54 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46f07fa52fd3f568f69e6113a71b77daa96ac38e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix NPE in canDoAction at AttachDisk.
by mkublin＠redhat.com 09 Sep '12

09 Sep '12

Michael Kublin has submitted this change and it was merged. Change subject: core: fix NPE in canDoAction at AttachDisk. ...................................................................... core: fix NPE in canDoAction at AttachDisk. If disk is null, then the method should return instead of proceeding further as it could lead to NPE when disk is accessed. Change-Id: If1cb0a34c663b2b069eca92ad5229041525ba56e Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1cb0a34c663b2b069eca92ad5229041525ba56e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable MTU support in 3.0 (#854496)
by masayag＠redhat.com 09 Sep '12

09 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Disable MTU support in 3.0 (#854496) ...................................................................... webadmin: Disable MTU support in 3.0 (#854496) https://bugzilla.redhat.com/854496 Configuring MTU for logical networks in 3.0 data-center is disabled, both for new networks or for updating an existing networks. Change-Id: Icb7ffe1738f0f1512f5ea783700786e45c541d1d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 4 files changed, 66 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb7ffe1738f0f1512f5ea783700786e45c541d1d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Validate MTU support in CDA (#854496)
by masayag＠redhat.com 09 Sep '12

09 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Validate MTU support in CDA (#854496) ...................................................................... engine: Validate MTU support in CDA (#854496) https://bugzilla.redhat.com/854496 The patch adds a can-do-action validation to verify MTU is being overridden only in supported DC compatibility version. Change-Id: Iafe07da82009fcb8d433ea6cb94d150bf2796c26 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 30 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafe07da82009fcb8d433ea6cb94d150bf2796c26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add MTUOverrideSupported conf value (#854496)
by masayag＠redhat.com 09 Sep '12

09 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Add MTUOverrideSupported conf value (#854496) ...................................................................... core: Add MTUOverrideSupported conf value (#854496) https://bugzilla.redhat.com/854496 Added MTUOverrideSupported configuration value which specifies that MTU might be overridden by DC level 3.1 and above. Change-Id: If8f3b118df175832c1cdd50a5567df2d8d9ab4c5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 3 files changed, 10 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8f3b118df175832c1cdd50a5567df2d8d9ab4c5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add vdsName to vdsBroker log info (#853883)
by oourfali＠redhat.com 09 Sep '12

09 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: add vdsName to vdsBroker log info (#853883) ...................................................................... core: add vdsName to vdsBroker log info (#853883) https://bugzilla.redhat.com/show_bug.cgi?id=853883 Logger gets VdsCommandBase.toString() method's output, this patch adds call to getAdditionalInformation from toString to add to log string VdsName. Change-Id: Ieb0589bb5f5e157c04f85e46f6769d66ef98b2d1 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/IsVmDuringInitiatingVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 4 files changed, 18 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb0589bb5f5e157c04f85e46f6769d66ef98b2d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0