- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: [SetupNetworks] discontinuous arrows (#851496)
by alkaplan＠redhat.com 05 Sep '12

05 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] discontinuous arrows (#851496) ...................................................................... webadmin: [SetupNetworks] discontinuous arrows (#851496) https://bugzilla.redhat.com/851496 Discontinuous arrows when multiple VLANs is attached to interface via Setup Networks. Change-Id: I25a77289d622a9f0b6cb29accb4bc5720fa23c48 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ConnectorPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_left_middle.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_bottom.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_middle.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/arrow_right_top.png 12 files changed, 16 insertions(+), 23 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25a77289d622a9f0b6cb29accb4bc5720fa23c48 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Template Nics Missing Metadata
by oliel＠redhat.com 05 Sep '12

05 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Template Nics Missing Metadata ...................................................................... restapi: Template Nics Missing Metadata Change-Id: Id2137769e7f8aed1ab30d0393bb101bbab1269d0 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2137769e7f8aed1ab30d0393bb101bbab1269d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Invalid guid should result in 400 (BAD_REQUEST) sta...
by oliel＠redhat.com 05 Sep '12

05 Sep '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Invalid guid should result in 400 (BAD_REQUEST) status ...................................................................... restapi: Invalid guid should result in 400 (BAD_REQUEST) status Change-Id: Ia98fc192ed1f018f975d1ed06b1aa596d2ab7ac7 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MalformedIdExceptionMapper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java 4 files changed, 50 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia98fc192ed1f018f975d1ed06b1aa596d2ab7ac7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in InstallerMessages.
by masayag＠redhat.com 04 Sep '12

04 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in InstallerMessages. ...................................................................... core: Remove deprecated StringHelper in InstallerMessages. Replaced StringHelper with StringUtils Change-Id: I5f9a2fd6047a30203c2efca357fefd93897d5992 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f9a2fd6047a30203c2efca357fefd93897d5992 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in AddExistingSANStorag...
by masayag＠redhat.com 04 Sep '12

04 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in AddExistingSANStorageDomainCommand. ...................................................................... core: Remove deprecated StringHelper in AddExistingSANStorageDomainCommand. Replaced StringHelper with StringUtils Change-Id: I687dacfb991c59cc5330eea50082c18dd54c96bd Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sharad Mishra: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687dacfb991c59cc5330eea50082c18dd54c96bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Initialize host name for CDA message(BZ846771)
by mlipchuk＠redhat.com 04 Sep '12

04 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Initialize host name for CDA message(BZ846771) ...................................................................... core:Initialize host name for CDA message(BZ846771) https://bugzilla.redhat.com/show_bug.cgi?id=846771 the following patch propose a fix for the scenario when lun disk is being extended and the host gets network exception while trying to connect the storage domain. This cause the CDA message not to be set with the host id that was not manage to connect to the domain. The solution is to Wrap the VDS calls with try and catch so failedHost list can be set with the problematic host before throwing an exception. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I3aa40d4671dc99c2126c131fda36c25d8ed4826e --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 2 files changed, 23 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aa40d4671dc99c2126c131fda36c25d8ed4826e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Refactor VDS calls to a method (BZ846771)
by mlipchuk＠redhat.com 04 Sep '12

04 Sep '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Refactor VDS calls to a method (BZ846771) ...................................................................... core:Refactor VDS calls to a method (BZ846771) related to https://bugzilla.redhat.com/show_bug.cgi?id=846771 The following patch refactors a VDS call to be called from a method, instead to be called twice in the command. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I7524faba38f170a3a37d9cbfff25cda1993ca8a5 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 11 insertions(+), 18 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7524faba38f170a3a37d9cbfff25cda1993ca8a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ESC key causes error msg
by gchaplik＠redhat.com 04 Sep '12

04 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: ESC key causes error msg ...................................................................... webadmin: ESC key causes error msg In some cases pressing escape key causes an error with status code 0. we will ignore this staus code, in the client side. Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Id37f3ee8e1d788cefb0929c97f89ef9e0da26673 --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id37f3ee8e1d788cefb0929c97f89ef9e0da26673 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rhevm-upgrade: encrypt vds_static pm_pass..
by emesika＠redhat.com 04 Sep '12

04 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: rhevm-upgrade: encrypt vds_static pm_pass.. ...................................................................... core: rhevm-upgrade: encrypt vds_static pm_pass.. rhevm-upgrade: encrypt vds_static pm_password field on upgrade to 3.1 Adding check for store-utils.sh exit value and log an error message if password encryption fail for any host. In such a scenario, this host must be edited manually to set it PM properties. Change-Id: I5b99768d4bdec8673fc0c8c2b0f329f54701bede Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_00_0420_encrypt_pm_passwd.sh 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b99768d4bdec8673fc0c8c2b0f329f54701bede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Cant add correlation id to HostTags #849398
by mpastern＠redhat.com 04 Sep '12

04 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cant add correlation id to HostTags #849398 ...................................................................... restapi: Cant add correlation id to HostTags #849398 https://bugzilla.redhat.com/show_bug.cgi?id=849398 Change-Id: Ibc5d18fea881ed52f31b58177364cf9f631fb65e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc5d18fea881ed52f31b58177364cf9f631fb65e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0