- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[master]: tools: Add support for remote PGDB (BZ831040) Support dumpin...
by kroberts＠redhat.com 04 Sep '12

04 Sep '12

Keith Robertson has submitted this change and it was merged. Change subject: tools: Add support for remote PGDB (BZ831040) Support dumping of remote Postgres DBs ...................................................................... tools: Add support for remote PGDB (BZ831040) Support dumping of remote Postgres DBs Signed-off-by: Keith Robertson <kroberts(a)redhat.com> Change-Id: I2afcd480dadf90a4b6fd4ce60b43c16f16ffc3c2 --- M src/rhev/logcollector.py M src/sos/plugins/postgresql.py 2 files changed, 64 insertions(+), 28 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2afcd480dadf90a4b6fd4ce60b43c16f16ffc3c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: enable resizing of storage dialogs (#846327)
by derez＠redhat.com 03 Sep '12

03 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: enable resizing of storage dialogs (#846327) ...................................................................... webadmin: enable resizing of storage dialogs (#846327) https://bugzilla.redhat.com/846327 * Enabled resizing support on Storage and Disk dialogs. * Made the required adjustments and tweaks in Storage and Disk views for proper resizing. Change-Id: I7413550422d7e67acb7b8ac94ba59bb8d5c68c1f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 9 files changed, 52 insertions(+), 24 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7413550422d7e67acb7b8ac94ba59bb8d5c68c1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: resizable dialogs support (#846327)
by derez＠redhat.com 03 Sep '12

03 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: resizable dialogs support (#846327) ...................................................................... webadmin: resizable dialogs support (#846327) https://bugzilla.redhat.com/846327 UI infrastructure - resizable dialogs * Added ResizableDialogBox widget (extends DialogBox): ** Enables resizing of the dialog by catching browser's mouse events. ** Contains a 'resize' symbol at bottom-right corner. * Currently, the feature is disabled by default (since some dialogs require tweaking of their inner widgets for proper resizing - should be revisited separately). * The resizable behavior would be enabled for Storage and Disk dialogs. Change-Id: Iec5acd2fdc6aafebecf306b2be3b4a2f53b1cf62 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ResizableDialogBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/public/images/dialog/panel_edge_BR_resize.png 4 files changed, 164 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec5acd2fdc6aafebecf306b2be3b4a2f53b1cf62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetAllAttachableDisks - filter Illegal disks (#851201)
by derez＠redhat.com 03 Sep '12

03 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: GetAllAttachableDisks - filter Illegal disks (#851201) ...................................................................... core: GetAllAttachableDisks - filter Illegal disks (#851201) https://bugzilla.redhat.com/851201 GetAllAttachableDisksByPoolId stored procedure: filter out disks in status Illegal. Change-Id: Ia302712c7c49f0818bbb44e46339b8e5867ce69c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 5 files changed, 31 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia302712c7c49f0818bbb44e46339b8e5867ce69c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add network filter config value
by masayag＠redhat.com 03 Sep '12

03 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Add network filter config value ...................................................................... core: Add network filter config value A new configuration value is introduced: EnableMACAntiSpoofingFilterRules - a system level config to enable/disable network filtering feature. Change-Id: If703dd504c5d71bffec354fd850b39571dab9c28 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Muli Salem: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If703dd504c5d71bffec354fd850b39571dab9c28 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add Network Filtering rules to VMs
by masayag＠redhat.com 03 Sep '12

03 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Add Network Filtering rules to VMs ...................................................................... core: Add Network Filtering rules to VMs The patch introduces the Network Filtering feature. The feature is enabled for 3.2 compatible cluster level. If the feature is enabled, the engine dictates libvirt via VDSM to add a network filter rule to prevent VM mac spoofing. A single filter is supported per vnic. The filter is set on vnic during starting a VM or when hotplug of vnic is activated. Feature page: http://wiki.ovirt.org/wiki/Features/Design/Network/NetworkFiltering Change-Id: I5776ea730ef1733fe4f9efe852c07053573dc5ba Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HotPlugUnplgNicVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NetworkFilters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 7 files changed, 64 insertions(+), 15 deletions(-) Approvals: Muli Salem: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5776ea730ef1733fe4f9efe852c07053573dc5ba Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Prevent networks with different MTU (#852052)
by msalem＠redhat.com 03 Sep '12

03 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Prevent networks with different MTU (#852052) ...................................................................... engine: Prevent networks with different MTU (#852052) https://bugzilla.redhat.com/852052 The patch prevents attaching a network to an interface if one of the following cases occur: * A non-VM network is already attached to the interface with MTU other than default and the user attempt to attach a Vlan which its MTU is other than the non-VM network. * A Vlan with non-default MTU is attached to an interface and the user attempt to attach a non-VM network to it with MTU other than the Vlan. Attaching several Vlans (VM network) with different MTU will not be blocked, as VDSM should support MTU configuration for the underlying interface. Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 360 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add SetNonOperationalVds to ExecutionMsgs (#843786)
by msalem＠redhat.com 03 Sep '12

03 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Add SetNonOperationalVds to ExecutionMsgs (#843786) ...................................................................... core: Add SetNonOperationalVds to ExecutionMsgs (#843786) https://bugzilla.redhat.com/843786 Adding a job for SetNonOperationalVds in the ExecutionMessages.properties file. Also making sure Vds is set in JobMessageProperties. Change-Id: I3c5a54fde862e20285ba5775bca5c4a549282b62 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c5a54fde862e20285ba5775bca5c4a549282b62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: don't migrate vms if host can't recover (#851840)
by ofrenkel＠redhat.com 03 Sep '12

03 Sep '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: don't migrate vms if host can't recover (#851840) ...................................................................... core: don't migrate vms if host can't recover (#851840) https://bugzilla.redhat.com/show_bug.cgi?id=851840 if host moved to non-operational because it failed to recover (recovery timeout passed) there is no point in sending migrate for the vms, as migrate command to the host would fail with same recovery error. Change-Id: I9616436386ee03a68ba25efa57abd2ac90e7bc9b Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9616436386ee03a68ba25efa57abd2ac90e7bc9b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change Log Level in SetNonOperationalVds (#853751)
by msalem＠redhat.com 03 Sep '12

03 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Change Log Level in SetNonOperationalVds (#853751) ...................................................................... core: Change Log Level in SetNonOperationalVds (#853751) https://bugzilla.redhat.com/853751 Changes log level from info to error when host is set to Non-Operational. Change-Id: I3b8e0133b2d39d9ce99cc30ce2c80c7c306b73ac Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8e0133b2d39d9ce99cc30ce2c80c7c306b73ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0