- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor SearchQuery cleanup
by lhornyak＠redhat.com 07 Aug '12

07 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor SearchQuery cleanup ...................................................................... core: minor SearchQuery cleanup - removed StringHelper usage (deprecated) - temporary variable for frequently used calculation Change-Id: Iee43e31a42571d26860d8d25fb942ecec64ce477 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee43e31a42571d26860d8d25fb942ecec64ce477 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetworks] Sync network- bug fixes
by masayag＠redhat.com 06 Aug '12

06 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] Sync network- bug fixes ...................................................................... webadmin: [SetupNetworks] Sync network- bug fixes https://bugzilla.redhat.com/838333 In SetupNetworks- if the network is in sync the boot protocol is always disabled because the sync network is unchecked. In this case the boot protocol should depend on the sync network checkbox. Change-Id: Ifee9224ad8dc0bd85a075a0bcc7c721729c4de3f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabledForContainter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksManagementPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EnumRadioEditor.java 9 files changed, 44 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee9224ad8dc0bd85a075a0bcc7c721729c4de3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add filling "managed" for network details (#838300)
by mkolesni＠redhat.com 06 Aug '12

06 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add filling "managed" for network details (#838300) ...................................................................... engine: Add filling "managed" for network details (#838300) https://bugzilla.redhat.com/838300 Added filling this field that indicates if a network is managed by the engine or not. If a network is unmanaged, the "in sync" field will be false (since it's really not in sync) but it can be disregarded since unmanaged state is more important. Change-Id: I9d9bf007ba13c32dfca15c4ec1e331749331a12d Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9bf007ba13c32dfca15c4ec1e331749331a12d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add "managed" to network details (#838300)
by mkolesni＠redhat.com 06 Aug '12

06 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add "managed" to network details (#838300) ...................................................................... core: Add "managed" to network details (#838300) https://bugzilla.redhat.com/838300 This field indicates if a network is managed by the engine, or is a custom network that is defined on the host only. Change-Id: I2f0b387799af97050d8d0b3ec612665328b6d9f9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 3 files changed, 15 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f0b387799af97050d8d0b3ec612665328b6d9f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Localize "about" dialog text.
by ecohen＠redhat.com 06 Aug '12

06 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Localize "about" dialog text. ...................................................................... userportal: Localize "about" dialog text. The first line within the user portal's "about" dialog was hard coded. This patch localizes it (i.e. the text is now in the ApplicationConstants interface). Change-Id: I030fe39c1d8b0d370b835b7a4a26a615ddffcdf0 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AboutPopupView.ui.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I030fe39c1d8b0d370b835b7a4a26a615ddffcdf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Do Not Allow Same Mac Address (#845837)
by msalem＠redhat.com 06 Aug '12

06 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Do Not Allow Same Mac Address (#845837) ...................................................................... core: Do Not Allow Same Mac Address (#845837) https://bugzilla.redhat.com/845837 This patch removes the freeing of Mac addresses from the MacPool in the canDoAction of UpdateVmInterface and AddVmInterface. The reason is that this enabled adding two VmInterfaces with the same Mac address. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I3cfcf0c15bc494f1debd4bdd3e15bd396b179323 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cfcf0c15bc494f1debd4bdd3e15bd396b179323 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: wipe after delete should be disabled for POSIXFS storage...
by oourfali＠redhat.com 06 Aug '12

06 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: ui: wipe after delete should be disabled for POSIXFS storage (#845463) ...................................................................... ui: wipe after delete should be disabled for POSIXFS storage (#845463) https://bugzilla.redhat.com/845463 This patch disable the wipe after delete option in the UI for disks that rely on posixfs storage domains. Change-Id: I3ce4c13b18f8886d24a66e51bd5458b3be8e9906 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/6934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce4c13b18f8886d24a66e51bd5458b3be8e9906 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix AutoRecoveryTest
by masayag＠redhat.com 06 Aug '12

06 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix AutoRecoveryTest ...................................................................... core: Fix AutoRecoveryTest Removed redundant unit test that test the default behaviour, which is not a stable behaviour configuration worth testing. Change-Id: Ie5196a92dace692289399cf40be18bf58b78315a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5196a92dace692289399cf40be18bf58b78315a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Update URL of DocumentationPath CSV fil...
by ecohen＠redhat.com 06 Aug '12

06 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: Update URL of DocumentationPath CSV files ...................................................................... webadmin,userportal: Update URL of DocumentationPath CSV files This patch updates the URL of DocumentationPath CSV files, containing dialog-to-documentation mappings used with context-sensitive help feature. Before this patch, CSV files were fetched from following locations: (assuming that vdc_options table declares 'DocsURL' with value 'docs') * WebAdmin http://<server-name>/docs/en-US/DocumentationPath.csv * UserPortal http://<server-name>/docs/en-US/UserPortalDocumentationPath.csv After this patch, CSV files are fetched from following locations: * WebAdmin http://<server-name>/docs/DocumentationPath.csv * UserPortal http://<server-name>/docs/UserPortalDocumentationPath.csv This has no impact on actual locale-specific HTML documentation URLs, e.g. http://<server-name>/docs/en-US/html/path/to/dialog/guide.html This patch also adds some Javadoc for better clarity. Change-Id: Ia649d860ebed35e2784bdeb183d49c5368c6f718 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia649d860ebed35e2784bdeb183d49c5368c6f718 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: api: user can set port mirroring without network id
by shavivi＠redhat.com 06 Aug '12

06 Aug '12

Shahar Havivi has submitted this change and it was merged. Change subject: api: user can set port mirroring without network id ...................................................................... api: user can set port mirroring without network id Change-Id: I49bdb50901c3a2281124e36d4a7cc0423b1a6be6 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java 2 files changed, 72 insertions(+), 35 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49bdb50901c3a2281124e36d4a7cc0423b1a6be6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0