- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Brick existance validation for add brick
by ofrenkel＠redhat.com 08 Aug '12

08 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Brick existance validation for add brick ...................................................................... engine: Brick existance validation for add brick - New brick exists check is added in Add Brick To Gluster Volume command. Change-Id: Ie93eb97560bc02157683983aa4e65cfb187bdb97 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 7 files changed, 65 insertions(+), 8 deletions(-) Approvals: Selvasundaram: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie93eb97560bc02157683983aa4e65cfb187bdb97 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: fix NPE in new cluster dialogue
by shavivi＠redhat.com 08 Aug '12

08 Aug '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: fix NPE in new cluster dialogue ...................................................................... UI: fix NPE in new cluster dialogue Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Quota log messages with UNKNOWN (#844646)
by dfediuck＠redhat.com 08 Aug '12

08 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: backend: Quota log messages with UNKNOWN (#844646) ...................................................................... backend: Quota log messages with UNKNOWN (#844646) https://bugzilla.redhat.com/844646 creating, removing and editing quota show the action in even log with quota name <UNKNOWN> This was due to lack of getter in the Audit log machanism. Change-Id: I53f74b169fd6032933475c62936e0aa34b352ee2 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53f74b169fd6032933475c62936e0aa34b352ee2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Use %d instead %i for String format (#843099)
by mlipchuk＠redhat.com 08 Aug '12

08 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Use %d instead %i for String format (#843099) ...................................................................... core:Use %d instead %i for String format (#843099) Fix UnknownFormatConversionException by changing %i in string format to use %d. https://bugzilla.redhat.com/show_bug.cgi?id=843099 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I32475369cbfd510632d4aa3c97126ebeebbbd29b --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32475369cbfd510632d4aa3c97126ebeebbbd29b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: no error messages after jboss restart (#842112)
by gchaplik＠redhat.com 07 Aug '12

07 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: no error messages after jboss restart (#842112) ...................................................................... webadmin: no error messages after jboss restart (#842112) https://bugzilla.redhat.com/842112 when the application logs out we need to clean the error messages, in order the application to show error messages in the next login. Change-Id: I76d828aad967c7fa9f3f1b1014ba035fd9ed1e58 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 6 files changed, 19 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d828aad967c7fa9f3f1b1014ba035fd9ed1e58 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetworks] unmanaged networks (#820504)
by derez＠redhat.com 07 Aug '12

07 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] unmanaged networks (#820504) ...................................................................... webadmin: [SetupNetworks] unmanaged networks (#820504) https://bugzilla.redhat.com/820504 Add unmanaged networks to SetupNetworks gui - Network panel- remove instead of edit - Right click menu- contains just detach - Tooltip- just tell the network is unmanaged. Other values are not displayed. Change-Id: I1ea44aaa1487cea4bc1c842a222dd708ff855315 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/but_erase_net_hover.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/but_erase_net_mousedown.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/empty.png 10 files changed, 85 insertions(+), 61 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea44aaa1487cea4bc1c842a222dd708ff855315 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up engineeringcryptutils' test logging
by yzaslavs＠redhat.com 07 Aug '12

07 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Clean up engineeringcryptutils' test logging ...................................................................... core: Clean up engineeringcryptutils' test logging Fixed log4j to reference org.apache.log4j.helpers.OnlyOnceErrorHandler instead of org.jboss.logging.util.OnlyOnceErrorHandler to avoid getting a NoClassDefError in unit test execution. Change-Id: Idaff7477ee94d76f281c4dd75cb701ae2daf45bf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/test/resources/log4j.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaff7477ee94d76f281c4dd75cb701ae2daf45bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reloadable AutoRecoveryAllowedTypes config
by yzaslavs＠redhat.com 07 Aug '12

07 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Reloadable AutoRecoveryAllowedTypes config ...................................................................... core: Reloadable AutoRecoveryAllowedTypes config Flagged the AutoRecoveryAllowedTypes config value as Reloadable, to allow changing it in runtime when the Reloadable Configuration feature is fully supported. Change-Id: I4ba63a89740aa7f711932734c9cc97b197e8cbd4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba63a89740aa7f711932734c9cc97b197e8cbd4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: comment out tests that depend on powermock
by yzaslavs＠redhat.com 07 Aug '12

07 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: comment out tests that depend on powermock ...................................................................... core: comment out tests that depend on powermock There are other tests that needs to be taken care of, this is a first patch in the series Change-Id: I9a4433b790ce28da5bfd7861ebb007e9a7bcacb7 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/TransactionSupportTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 4 files changed, 875 insertions(+), 853 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a4433b790ce28da5bfd7861ebb007e9a7bcacb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MigrateVmCommand cleanup
by lhornyak＠redhat.com 07 Aug '12

07 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: MigrateVmCommand cleanup ...................................................................... core: MigrateVmCommand cleanup - import java.util - suppress warning on unused variable in overridden method Change-Id: I3a8dce43eceb213cb428d25f0cb51eeaf04ee704 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8dce43eceb213cb428d25f0cb51eeaf04ee704 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0