- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: setup networks freezes on engine error
by derez＠redhat.com 19 Jun '12

19 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: setup networks freezes on engine error ...................................................................... webadmin: setup networks freezes on engine error VdcActionType___SetupNetworks was missing in the enums files Change-Id: Iee89adac8fc81fd83474d596273c66e216a0ba5a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee89adac8fc81fd83474d596273c66e216a0ba5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updating flow and error messages in cleanup (#825...
by oschreib＠redhat.com 19 Jun '12

19 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updating flow and error messages in cleanup (#825998) ...................................................................... packaging: Updating flow and error messages in cleanup (#825998) https://bugzilla.redhat.com/show_bug.cgi?id=825998 * Updated flows and various error messages in engine-cleanup. Change-Id: I47480fc85cb627ad38e26f9e5052e2067095d1f2 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47480fc85cb627ad38e26f9e5052e2067095d1f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Pass storage-domain on add disk
by oliel＠redhat.com 19 Jun '12

19 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Pass storage-domain on add disk ...................................................................... restapi: Pass storage-domain on add disk When adding a disk from root collection (.../api/disks) storage domain was not mapped, and not passed to the Backend. This patch fixes this. Change-Id: I436951074d8c5db2a6a65a09b6219d51df5ce92b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I436951074d8c5db2a6a65a09b6219d51df5ce92b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: wedadmin: switching engine net to new nic causes error
by derez＠redhat.com 19 Jun '12

19 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: wedadmin: switching engine net to new nic causes error ...................................................................... wedadmin: switching engine net to new nic causes error witching rhevm network to different NIC throws exception NETWORK_ATTACH_ILLEGAL_GATEWAY The engine throws this error because the old nic keeps the old default gateway attribute value even there is no network attached to it. The engine checks if the nic with the default gateway is management- it isn't so it throws the error. Change-Id: I05752b8e5283f86778155e9fa04d3e52215cf427 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05752b8e5283f86778155e9fa04d3e52215cf427 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Rephrase the "check connectivity"
by derez＠redhat.com 19 Jun '12

19 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Rephrase the "check connectivity" ...................................................................... webadmin: Rephrase the "check connectivity" In a prevous commit "check connectivity" in the setup network form and edit management form was changed to ""Rollback changes if Host loses Connectivity to the Engine". In this commit it is changed to ""Rollback changes if Host loses Connectivity to the Engine". And is checked by default. Change-Id: Ifdb4559b0d4f69ee9d5e691873974741869856ea Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdb4559b0d4f69ee9d5e691873974741869856ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: package: Updated sysprep.w7 profiles for Windows 7 (#786394)
by oschreib＠redhat.com 19 Jun '12

19 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: package: Updated sysprep.w7 profiles for Windows 7 (#786394) ...................................................................... package: Updated sysprep.w7 profiles for Windows 7 (#786394) https://bugzilla.redhat.com/show_bug.cgi?id=786394 * Updated DPI to 96 in sysprep.w7 and sysprep.w7x64 files so that 100% sizing will be set during system setup. Change-Id: Ic4e09b73ad8800857cf2740a7d4efc827f95fc0d Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/conf/sysprep/sysprep.w7 M backend/manager/conf/sysprep/sysprep.w7x64 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e09b73ad8800857cf2740a7d4efc827f95fc0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing reconstruct
by mkublin＠redhat.com 19 Jun '12

19 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing reconstruct ...................................................................... core: Fixing reconstruct After introducing a new state of storage domain : Maintaice at engine side we should not send these status to vdsm. These fix will solve a problem Change-Id: I3f4bcd8db2f496aa99a1b061f36a4cb4dc108552 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f4bcd8db2f496aa99a1b061f36a4cb4dc108552 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: use enums properly
by rgolan＠redhat.com 19 Jun '12

19 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: webadmin: use enums properly ...................................................................... webadmin: use enums properly use built-in enum's values method instead of explicit setting it. Change-Id: I1a9284cf192f5da91ea321832edd908eb9d78013 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 22 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9284cf192f5da91ea321832edd908eb9d78013 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated upgrade flow to rename DB before its upg...
by oschreib＠redhat.com 19 Jun '12

19 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated upgrade flow to rename DB before its upgrade. ...................................................................... packaging: Updated upgrade flow to rename DB before its upgrade. Updated the upgrade flow so that restore operation will check whether DB was already renamed, and if so, it will restore it to the original according to backup file. Change-Id: I686b033d15f7d8d91de52171ac06b6b8c836abef Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I686b033d15f7d8d91de52171ac06b6b8c836abef Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: List all templates according to user permissions...
by vszocs＠redhat.com 19 Jun '12

19 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: List all templates according to user permissions. ...................................................................... userportal: List all templates according to user permissions. Originally User Portal retrieves vm templates that the user has 'EDIT_TEMPLATE_PROPERTIES' action group for, This patch retrieves all vm templates according to user permissions. Change-Id: Id723a6ba65ad5b9f433d51e5885318b6ce6c29f3 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id723a6ba65ad5b9f433d51e5885318b6ce6c29f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0