- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: setup networks- check conn and save config
by gchaplik＠redhat.com 19 Jun '12

19 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: setup networks- check conn and save config ...................................................................... webadmin: setup networks- check conn and save config The commit includes: 1. Adding to the setup netwroks form- - Check Connectivity checkbox (renamed to- Rollback changes if Host looses Connectivity to the Engine). - Save network configuration checkbox 2. Removing save network configuration button from host->interfaces panel if the dc vertion is 3.1 or uppper. Change-Id: I270f49501ba2dc7854d1779ef93e22aff7687079 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 8 files changed, 114 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I270f49501ba2dc7854d1779ef93e22aff7687079 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix vNIC count parameter for add VM
by mkolesni＠redhat.com 19 Jun '12

19 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix vNIC count parameter for add VM ...................................................................... core: Fix vNIC count parameter for add VM The parameter is the number of vNICs about to be allocated, so changed it's name & the callers now send number of NICs to allocate (according to their amount in the template). Change-Id: I4285920adb02a7e15fe0ed1410359eb9acacbed3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java 5 files changed, 30 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4285920adb02a7e15fe0ed1410359eb9acacbed3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adding Enum validations in create volume (#831096)
by mpastern＠redhat.com 19 Jun '12

19 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Adding Enum validations in create volume (#831096) ...................................................................... restapi: Adding Enum validations in create volume (#831096) https://bugzilla.redhat.com/831096 Enum validation added for Volume Type, Transport Type and Access Protocols. Change-Id: I06602c5bb4eec461a80ddaf3d96ac9eb0d3f6a56 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java 2 files changed, 38 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/5278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06602c5bb4eec461a80ddaf3d96ac9eb0d3f6a56 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Testing MaxBlockDiskSize validation
by derez＠redhat.com 19 Jun '12

19 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Testing MaxBlockDiskSize validation ...................................................................... core: Testing MaxBlockDiskSize validation Added tests for 'MaxBlockDiskSize' validation in AddDiskToVmCommandTest. Change-Id: I3e6b068f6a4ebb58859162c1cd89c53f7775aa68 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 1 file changed, 61 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e6b068f6a4ebb58859162c1cd89c53f7775aa68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Reduce flood of polling attempts/logs
by mkolesni＠redhat.com 19 Jun '12

19 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Reduce flood of polling attempts/logs ...................................................................... engine: Reduce flood of polling attempts/logs When SetupNetworksCommand was run and the host didn't lose connectivity with the engine, we would poll it relentlessly. This would cause a log flood on both the host and the engine, and also generates needless traffic over the network. Added a 0.5 second cooldown period betweeb polling attempts, unless the polling took more than that time (which probably was caused due to lost connectivity). Also reduced the verbosity of the logs on the engine side. Change-Id: I324e326a6ea8ef92195dd22218bc619a49fe574a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I324e326a6ea8ef92195dd22218bc619a49fe574a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Fix NPE when no CreationDate given in OvfVmReader
by shavivi＠redhat.com 18 Jun '12

18 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: engine: Fix NPE when no CreationDate given in OvfVmReader ...................................................................... engine: Fix NPE when no CreationDate given in OvfVmReader Change-Id: I803ce5f24a607cb877fda1284b162afc0bee4e7f Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Sharad Mishra: Verified -- To view, visit http://gerrit.ovirt.org/5457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I803ce5f24a607cb877fda1284b162afc0bee4e7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: Attach disk from VmGuideModel
by derez＠redhat.com 18 Jun '12

18 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Attach disk from VmGuideModel ...................................................................... webadmin: Attach disk from VmGuideModel Added missing support for attaching a disk through GuideMe. Change-Id: I31509e79c47a6c6f4dceab178997aac3abdd87d9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31509e79c47a6c6f4dceab178997aac3abdd87d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant casting on UpdateVmDisk
by derez＠redhat.com 18 Jun '12

18 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove redundant casting on UpdateVmDisk ...................................................................... webadmin: Remove redundant casting on UpdateVmDisk UpdateVmDiskParameters - removed redundant casting to DiskImage. Change-Id: I7d9202edf32524c132776d204f4e14afcc707e38 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d9202edf32524c132776d204f4e14afcc707e38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix IndexOutOfBounds in remove quotaStorage
by gchaplik＠redhat.com 18 Jun '12

18 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix IndexOutOfBounds in remove quotaStorage ...................................................................... core: fix IndexOutOfBounds in remove quotaStorage In case CreateAllSnapshotsFromVmCommand doesn't contains disks, ignore remove removeStorageDeltaQuotaCommand. unless ignored caused IndexOutOfBounds exception. Change-Id: I15cd6dc43fdfe2ff8111566f1f20a0d83301793d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cd6dc43fdfe2ff8111566f1f20a0d83301793d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DateRenderer - handle empty dates
by gchaplik＠redhat.com 18 Jun '12

18 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: DateRenderer - handle empty dates ...................................................................... webadmin: DateRenderer - handle empty dates Change-Id: Iec84d2b03a799437798e8244cfc10938f65eb9b5 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/GeneralDateTimeRenderer.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec84d2b03a799437798e8244cfc10938f65eb9b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0