- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Grayed-Out LUNs Support
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Grayed-Out LUNs Support ...................................................................... webadmin: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out/Disabled LUNs (LUNS that are not applicable for adding into storage domains): * Storage domain dialog: ** LUN devices that include partitions - should be grayed-out. ** LUN devices that are a part of a VG - should be grayed-out. ** LUN devices that already exists in the system - should be grayed-out. * Add DirectLUN dialog: ** LUN devices that include partitions - a warning should be displayed. ** LUN devices that are a part of a VG - a warning should be displayed. ** LUN devices that already exists in the system - should be grayed-out. Change-Id: I59539aa6b5f0b12a5ac88cf6ea6509133b85ee92 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/LunTextColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LunModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 14 files changed, 236 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59539aa6b5f0b12a5ac88cf6ea6509133b85ee92 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Grayed-Out LUNs Support
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: restapi: Grayed-Out LUNs Support ...................................................................... restapi: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out (disabled) LUNs: * Added 'partitioned' flag and 'volume_group_id' to LogicalUnit type. ** 'partitioned' flag - indicating whether the LUN device contains partitions - cannot be added to a storage domain. ** 'volume_group_id' - indicating whether the LUN device is a part of a VG - cannot be added to a storage domain. ** 'storage_domain_id' - indicating whether the LUN device is already a part of a storage domain - cannot be added to another storage domain. * Modified 'StorageLogicalUnitMapper' accordingly. * The new representation is needed when getting host's storage sub-collection (a list of LUN devices). Change-Id: I9accec6b37180e2da77c752875e8e181c0cd3601 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9accec6b37180e2da77c752875e8e181c0cd3601 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Grayed-Out LUNs Support
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Grayed-Out LUNs Support ...................................................................... core: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out LUNs: * Added 'isPartitioned' flag, storage domain Id/Name and disk Id/Alias to LUNs business entity. LUN devices that include partitions and/or already exist in the system and/or are part of a VG - should not be applicable for adding into storage domains. * GetDeviceListQuery should not filter LUNs that are 'partitioned/exist in DB/part of a VG' on cluster 3.1 and up. * VDSM's GetDeviceList should be called with includePartitioned=true option for cluster C3.1 and up. Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 14 files changed, 385 insertions(+), 34 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: selecting default quota name
by emesika＠redhat.com 07 Jun '12

07 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: selecting default quota name ...................................................................... core: selecting default quota name In create DC, select a default quota name that doesn't exist in quota table. In case the regular quota name exist increment the new quota name. Change-Id: I69be6335484a4ee4d115b4dc29399f9b571c3759 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/quota_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java 4 files changed, 54 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69be6335484a4ee4d115b4dc29399f9b571c3759 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change visibily of host->network actions
by gchaplik＠redhat.com 07 Jun '12

07 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Change visibily of host->network actions ...................................................................... webadmin: Change visibily of host->network actions https://bugzilla.redhat.com/show_bug.cgi?id=823891 Host->network interfaces. The setup network action should be visible just for hosts with 3.1 and above version. All the other actions (except save network configuration) should be visible just on hosts with 3.0 and beneath version. Change-Id: Ife46dddbaf772258bc4b112c476c7ee3f837c495 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java 2 files changed, 17 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife46dddbaf772258bc4b112c476c7ee3f837c495 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: REST-API request of VM's NIC with non-exists network
by emesika＠redhat.com 07 Jun '12

07 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: REST-API request of VM's NIC with non-exists network ...................................................................... core: REST-API request of VM's NIC with non-exists network REST-API request of VM's NIC with non-exists network returns error instead of the NIC's structure XML This patch handles interface invalid network or non vm network and if validation failed the network name will be an empty string and the user will be asked to set the correct network upon running the VM Change-Id: I50abd4319dbeaf6fa272bf9529bf4b1e651c8dcd Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 34 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50abd4319dbeaf6fa272bf9529bf4b1e651c8dcd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change supported host statuses (#826470)
by ofrenkel＠redhat.com 07 Jun '12

07 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Change supported host statuses (#826470) ...................................................................... core: Change supported host statuses (#826470) https://bugzilla.redhat.com/826470 Change supported statuses to Maintenance, Up, NonOperational as they are all valid satuses for running setup networks. Change-Id: Ic9015f6a1dbe5ed984ec934cabdf53e395caac73 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 37 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9015f6a1dbe5ed984ec934cabdf53e395caac73 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change host status error message
by ofrenkel＠redhat.com 07 Jun '12

07 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Change host status error message ...................................................................... core: Change host status error message Change status error message to receive status from variable (which can be localized), since it will be needed in next patch. Change-Id: I68e532bc8e5ee5a07c8099d60d4cc012c112942a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 17 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68e532bc8e5ee5a07c8099d60d4cc012c112942a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: changed default Blank template USB policy to DISABLED
by lhornyak＠redhat.com 07 Jun '12

07 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: changed default Blank template USB policy to DISABLED ...................................................................... core: changed default Blank template USB policy to DISABLED Blank template USB policy changed to be by default DISABLED Change-Id: I4a18d4ec7c99db30d455ee844be0f2d0b22a3e1a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1200_blank_template_usb_policy.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a18d4ec7c99db30d455ee844be0f2d0b22a3e1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Set lock to null
by mkolesni＠redhat.com 07 Jun '12

07 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Set lock to null ...................................................................... core: Set lock to null A lock was passed to child command, and will be released there. There are no need to rerlease a lock at parent command, that's why setting lock to null Change-Id: I162e7520288128dcbd6d95756c82e22e53938994 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Michael Kublin: Verified -- To view, visit http://gerrit.ovirt.org/5138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I162e7520288128dcbd6d95756c82e22e53938994 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0