- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix for GUI should check for volume name uniqueness
by ofrenkel＠redhat.com 07 Jun '12

07 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fix for GUI should check for volume name uniqueness ...................................................................... engine: Fix for GUI should check for volume name uniqueness https://bugzilla.redhat.com/826454 Added the can do action to check whether volume name already exists. Change-Id: I6a0c36273fafdf4acd7a37a21de04a989ba18656 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 4 files changed, 15 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a0c36273fafdf4acd7a37a21de04a989ba18656 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove AsyncQuery leftovers
by mkublin＠redhat.com 07 Jun '12

07 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Remove AsyncQuery leftovers ...................................................................... core: Remove AsyncQuery leftovers AsyncQuery was removed in a previous patch (I3734abc8a99ebcfdd8e8c8ea8c6b3a674a139f10). This patch removed some left-overs that were forgotten in it. Change-Id: Ia28c0f938ce70c300693320b6a2e6d1b69c71778 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/GenericApiService.java 3 files changed, 18 insertions(+), 33 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia28c0f938ce70c300693320b6a2e6d1b69c71778 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding logging in DirectorySearcher (#829573)
by yzaslavs＠redhat.com 07 Jun '12

07 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: adding logging in DirectorySearcher (#829573) ...................................................................... core: adding logging in DirectorySearcher (#829573) https://bugzilla.redhat.com/829573 This patch adds debug log message to the find method, to enable better debugging of query related issues. Change-Id: I0482f3f9f6cda1d2a4c4f7ad328a41559c7869ea Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0482f3f9f6cda1d2a4c4f7ad328a41559c7869ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: replacing Active-Directory to LDAP server in error mes...
by yzaslavs＠redhat.com 07 Jun '12

07 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: replacing Active-Directory to LDAP server in error message ...................................................................... core: replacing Active-Directory to LDAP server in error message This patch replaces the "Active Directory" string in the timeout error message to "LDAP", so that we get "Connection to LDAP server has timed out" Change-Id: I249f39d206d33df1fb8adb417ab86dbcba095e86 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249f39d206d33df1fb8adb417ab86dbcba095e86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Adding remoteDb support to dwh
by ydary＠redhat.com 06 Jun '12

06 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Adding remoteDb support to dwh ...................................................................... packaging: Adding remoteDb support to dwh * Adding remote DB support to dwh. Change-Id: Iec31497fceae9c335d6ec2c073388fea1335ece4 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_db.sh M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh M data-warehouse/historydbscripts_postgres/dbfunctions.sh M data-warehouse/historydbscripts_postgres/ovirt-engine-history-db-install.sh M data-warehouse/historydbscripts_postgres/upgrade.sh A data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/add_comment_col_to_schema_version.sql M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py M packaging/ovirt-engine-dwh.spec.tmpl 9 files changed, 437 insertions(+), 158 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec31497fceae9c335d6ec2c073388fea1335ece4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: missing localized Attach-Detach Disk enum
by derez＠redhat.com 06 Jun '12

06 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: missing localized Attach-Detach Disk enum ...................................................................... webadmin: missing localized Attach-Detach Disk enum Added missing localization for 'AttachDiskToVm' and 'DetachDiskFromVm' enums. Change-Id: I965cbd497ac4ad8421ffac1be812e62813609f45 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I965cbd497ac4ad8421ffac1be812e62813609f45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ConfigurationValues Shareable and DirectLUN
by derez＠redhat.com 06 Jun '12

06 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: ConfigurationValues Shareable and DirectLUN ...................................................................... core: ConfigurationValues Shareable and DirectLUN Added 'ShareableDiskEnabled' and 'DirectLUNDiskEnabled' to ConfigurationValues enum. Change-Id: Id12bd42c9175f07b26dc45d47eaf9afaacc18a9c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id12bd42c9175f07b26dc45d47eaf9afaacc18a9c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: property sheet: drop-down (#827710)
by gchaplik＠redhat.com 06 Jun '12

06 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: property sheet: drop-down (#827710) ...................................................................... webadmin: property sheet: drop-down (#827710) https://bugzilla.redhat.com/show_bug.cgi?id=827710 Currently in custom property sheet, each value is input-ed via a text-box, but some keys allow only A|B|C reg-ex values: In this case we can ease the user experience process by having a drop-down containing the values A,B,C. Change-Id: Id8137723e0d4c761b1315433878e26931b1afc9c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 4 files changed, 63 insertions(+), 11 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8137723e0d4c761b1315433878e26931b1afc9c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add Vm Ballooning Support
by emesika＠redhat.com 06 Jun '12

06 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: restapi: Add Vm Ballooning Support ...................................................................... restapi: Add Vm Ballooning Support REST API implementation for balloon device support. hange-Id: I50ae28e645c7236dbf0f1dad50b409609c44549e Signed-off-by: Eli Mesika <emesika(a)redhat.com> Change-Id: I50ae28e645c7236dbf0f1dad50b409609c44549e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 5 files changed, 57 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ae28e645c7236dbf0f1dad50b409609c44549e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add version, retrans and timeo to inst_sp.sql
by yzaslavs＠redhat.com 06 Jun '12

06 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add version, retrans and timeo to inst_sp.sql ...................................................................... core: Add version, retrans and timeo to inst_sp.sql Add the version, retrans and timeo parameters to the call that the engine-setup script uses to create the ISO storage domain during installation. Change-Id: I9d24d6d5cac0c7cb88441a0114420ce739451d8a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/inst_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d24d6d5cac0c7cb88441a0114420ce739451d8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0