- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Avoid psql warning about global temporary table
by Code Review 09 Aug '17

09 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80493 ) Change subject: inventory: Avoid psql warning about global temporary table ...................................................................... inventory: Avoid psql warning about global temporary table global is deprecated, let's avoid this warning to users, this message can show in old dbs. Change-Id: I53d9cd4d7a6a3f91b826302ced8b8ee00284726e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53d9cd4d7a6a3f91b826302ced8b8ee00284726e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: improvement in displaying and validation
by Code Review 09 Aug '17

09 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80492 ) Change subject: inventory: improvement in displaying and validation ...................................................................... inventory: improvement in displaying and validation This patch move stderr to /dev/null when extracting files and check if variable ENGINE_CONF_D_10_SETUP_JAVA has value. Change-Id: I483132a1c5e46ddb72c65eb5314e00948fa40de9 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/unpackHostsSosReports.sh 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I483132a1c5e46ddb72c65eb5314e00948fa40de9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: make sure we have all perms to unpacked dir
by Code Review 09 Aug '17

09 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80491 ) Change subject: inventory: make sure we have all perms to unpacked dir ...................................................................... inventory: make sure we have all perms to unpacked dir Change-Id: I446431611a7ccbab64e6392c6a1c634946b29c2f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/unpackAndPrepareDump.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I446431611a7ccbab64e6392c6a1c634946b29c2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix ui exception
by Code Review 09 Aug '17

09 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80343 ) Change subject: webadmin: fix ui exception ...................................................................... webadmin: fix ui exception - Fixed exception caused by iframe handler. - Reduced white space around iframes. - Reduced white space around main grids. - Reduced white space around detail views. Change-Id: I993ffc9c322c3bdfcee4889d4d7c86acee4c4404 Bug-Url: https://bugzilla.redhat.com/1478020 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabWithDetailsTableView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/DynamicUrlContentTabView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/DynamicUrlContentTabView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.ui.xml M packaging/branding/ovirt.brand/common.css 5 files changed, 29 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I993ffc9c322c3bdfcee4889d4d7c86acee4c4404 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: undo recent generalization of ovf processing
by Code Review 09 Aug '17

09 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80328 ) Change subject: core: undo recent generalization of ovf processing ...................................................................... core: undo recent generalization of ovf processing Reverting the attempt to generalize OvfReader and OvfWriter to support different kinds of OVF implementations. It produces a complicated code and increases the chance for regressions. A better approach would be to split the OVF handling of ordinary OVFs in oVirt and general OVFs that better comply with the specification. Change-Id: Ibbe176cfc0a5bcb0319d178f573ba948ab1d6fc8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 2 files changed, 36 insertions(+), 88 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/80328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe176cfc0a5bcb0319d178f573ba948ab1d6fc8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Inject GlusterGeoRepUtil DAOs
by Code Review 09 Aug '17

09 Aug '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/79413 ) Change subject: core: Inject GlusterGeoRepUtil DAOs ...................................................................... core: Inject GlusterGeoRepUtil DAOs Change-Id: I5d9d2d90df423dcae58ac72e8bdfe4b0f7d3dce3 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepCreateEligibilityBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java 4 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d9d2d90df423dcae58ac72e8bdfe4b0f7d3dce3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Inject SchedulingManager DAOs
by Code Review 09 Aug '17

09 Aug '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/79412 ) Change subject: scheduling: Inject SchedulingManager DAOs ...................................................................... scheduling: Inject SchedulingManager DAOs Change-Id: Icfb1193ba270f92c6daa3114f154ae9020d176c1 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 19 insertions(+), 30 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfb1193ba270f92c6daa3114f154ae9020d176c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Migrate DiskProfileValidator to CDI
by Code Review 09 Aug '17

09 Aug '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/79410 ) Change subject: core: Migrate DiskProfileValidator to CDI ...................................................................... core: Migrate DiskProfileValidator to CDI Change-Id: I8c2d7460e214ddc04d2f20867f6a08b61ae996a1 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java 6 files changed, 36 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2d7460e214ddc04d2f20867f6a08b61ae996a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Migrate CpuProfileValidator to CDI
by Code Review 09 Aug '17

09 Aug '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/79409 ) Change subject: core: Migrate CpuProfileValidator to CDI ...................................................................... core: Migrate CpuProfileValidator to CDI Change-Id: I094e6049e01e8111db5f370391dd96cee52f1103 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java 4 files changed, 29 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I094e6049e01e8111db5f370391dd96cee52f1103 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: post ovirt-hosted-engine-setup-2.1.3.6
by Code Review 09 Aug '17

09 Aug '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/80465 ) Change subject: build: post ovirt-hosted-engine-setup-2.1.3.6 ...................................................................... build: post ovirt-hosted-engine-setup-2.1.3.6 Change-Id: Ied27d5137c505196ee16f5b36b135f1779ebe524 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied27d5137c505196ee16f5b36b135f1779ebe524 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0