- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Made default loop delay value a constant
by Code Review 09 Aug '17

09 Aug '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/80458 ) Change subject: Made default loop delay value a constant ...................................................................... Made default loop delay value a constant Change-Id: I208e62edbec9caae190a4302a751f0360c4cdc43 Bug-Url: https://bugzilla.redhat.com/1337914 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M ovirt_hosted_engine_ha/env/constants.py.in M ovirt_hosted_engine_ha/lib/fsm/machine.py 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I208e62edbec9caae190a4302a751f0360c4cdc43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: Provide clearer error when failing to connect to storage dom...
by Code Review 09 Aug '17

09 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80380 ) Change subject: Provide clearer error when failing to connect to storage domain. ...................................................................... Provide clearer error when failing to connect to storage domain. Change-Id: I2120636a51c9a9e2e16062e0fd526edd813eecc3 Bug-Url: https://bugzilla.redhat.com/1460982 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 52 insertions(+), 45 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/80380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2120636a51c9a9e2e16062e0fd526edd813eecc3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Provide clearer error when failing to connect to storage dom...
by Code Review 09 Aug '17

09 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80377 ) Change subject: Provide clearer error when failing to connect to storage domain. ...................................................................... Provide clearer error when failing to connect to storage domain. Change-Id: I2120636a51c9a9e2e16062e0fd526edd813eecc3 Bug-Url: https://bugzilla.redhat.com/1434209 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 52 insertions(+), 45 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/80377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2120636a51c9a9e2e16062e0fd526edd813eecc3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: Document changes in get and set shared config commands
by Code Review 09 Aug '17

09 Aug '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/79225 ) Change subject: Document changes in get and set shared config commands ...................................................................... Document changes in get and set shared config commands hosted-engine.conf was added to the editable configuration files on the shared storage. This patch adds documentation about the new type and usage. Change-Id: I507ce101ea27cea4a0fafd24e34822008ad92999 Bug-Url: https://bugzilla.redhat.com/1457357 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 16 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Jenny Tokar: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I507ce101ea27cea4a0fafd24e34822008ad92999 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Document changes in get and set shared config commands
by Code Review 09 Aug '17

09 Aug '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/78702 ) Change subject: Document changes in get and set shared config commands ...................................................................... Document changes in get and set shared config commands hosted-engine.conf was added to the editable configuration files on the shared storage. This patch adds documentation about the new type and usage. Change-Id: I507ce101ea27cea4a0fafd24e34822008ad92999 Bug-Url: https://bugzilla.redhat.com/1457357 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 16 insertions(+), 6 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified Objections: Sandro Bonazzola: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/78702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I507ce101ea27cea4a0fafd24e34822008ad92999 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Add iptables deprecation message to the user
by Code Review 09 Aug '17

09 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79444 ) Change subject: packaging: setup: Add iptables deprecation message to the user ...................................................................... packaging: setup: Add iptables deprecation message to the user Change-Id: Ibb53293c51e3e8eee81a0865be331b4b0199a0aa Bug-Url: https://bugzilla.redhat.com/1456558 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb53293c51e3e8eee81a0865be331b4b0199a0aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Inform user about adding OVN secret
by Code Review 09 Aug '17

09 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79892 ) Change subject: packaging: setup: Inform user about adding OVN secret ...................................................................... packaging: setup: Inform user about adding OVN secret As this can be a long process on a (virtual) machine with low entropy. Change-Id: Iac81c401f571f5288ab627ce5658040e658ae6e5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac81c401f571f5288ab627ce5658040e658ae6e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Inform about setting admin password
by Code Review 09 Aug '17

09 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79890 ) Change subject: packaging: setup: Inform about setting admin password ...................................................................... packaging: setup: Inform about setting admin password In a (virtual) machine with low entropy, this process can take a very long time. Inform users, so that they do not mistakenly think there is a problem with whatever previous INFO message that was output. Change-Id: I6eaa462ee769ddd95b3b69484eb07c359b219252 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaajdbc.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eaa462ee769ddd95b3b69484eb07c359b219252 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add GetTlvsByHostNicIdQuery
by Code Review 09 Aug '17

09 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79927 ) Change subject: core: Add GetTlvsByHostNicIdQuery ...................................................................... core: Add GetTlvsByHostNicIdQuery The added GetTlvsByHostNicIdQuery utilizes the GetLldpVDSCommand directly to get the LLDP information from a host. Change-Id: I130ca73f4ffdc6668bc4a4bd979ca4f488be8c7f Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetTlvsByHostNicIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetTlvsByHostNicIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/QueryType.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 222 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130ca73f4ffdc6668bc4a4bd979ca4f488be8c7f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixes & simplifications in MoveMacs.java
by Code Review 09 Aug '17

09 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78132 ) Change subject: core: fixes & simplifications in MoveMacs.java ...................................................................... core: fixes & simplifications in MoveMacs.java • renamed moveMacsOfUpdatedCluster to migrateMacsToAnotherMacPoolIfNeeded • removed duplicate call needToMigrateMacs. • added missing source-target macPool comparison in migrateMacsToAnotherMacPool • added missing requireNonNull in migrateMacsToAnotherMacPool Bug-Url: https://bugzilla.redhat.com/1435485 Change-Id: Iccad1b2c74280f393afa51d198c990468245533d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java 3 files changed, 19 insertions(+), 24 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccad1b2c74280f393afa51d198c990468245533d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0