- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: dashboards: Fixed cluster.last24hours dashboard query
by Code Review 13 Feb '17

13 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: dashboards: Fixed cluster.last24hours dashboard query ...................................................................... dashboards: Fixed cluster.last24hours dashboard query Change-Id: I91595689d576227b4b6216ed0864731c9cacb576 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterDwhDAO.properties 1 file changed, 28 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91595689d576227b4b6216ed0864731c9cacb576 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: vdsm: Don't disable NetworkManager by default.
by Code Review 13 Feb '17

13 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: vdsm: Don't disable NetworkManager by default. ...................................................................... vdsm: Don't disable NetworkManager by default. NetworkManager is now supported in vdsm versions 4.19 and upwards; modify the default value of DISABLE_NETWORKMANAGER to false and disable NetworkManager if either DISABLE_NETWORKMANAGER is set to true or vdsm's version is below 4.19. Bug-Id: https://bugzilla.redhat.com/1421464 Change-Id: Id5174fcc27553efea00e46c280912bc0856bf1c1 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/vdsm/packages.py 2 files changed, 16 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/71858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5174fcc27553efea00e46c280912bc0856bf1c1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: NPE on edit pool dialog
by Code Review 13 Feb '17

13 Feb '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NPE on edit pool dialog ...................................................................... webadmin: NPE on edit pool dialog The resource allocation of the edit pool dialog has a logic which tries to select the storage domain of the selected template to be the same as the storage domain on which some Vm from the pool is. The logic has an assumption that the selected template's disks are the parent disks of the respective VM. This assumption is true only if the template is not versioned. If the template has versions, this assumption is broken. This causes an issue that the disk allocation part is not properly inited and consequently fails on validation on NPE. Fixed by first initing the storage to the values of the template disks and than try to match them to the VM ones. Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc Bug-Url: https://bugzilla.redhat.com/1388963 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Passed CI tests Martin Betak: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: DB configuration plugin
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: DB configuration plugin ...................................................................... packaging: setup: DB configuration plugin Motivation A setup may fail with misconfigured db properties, but it fails-fast, and that may send the user into a loop untill all the db values are configured correctly while instead we can report all the missing items at once and offer to fix them Change Default configuration are decleared by the core setup files and extra configuration are inside configuration.py Whenever a configuration item is decleraed as must, the setup will try to fix ammend postgres.conf and restart postgres (notice, won't work for dev-env unless combind with sudo). If the db is a remote db, the user will get a warning with the misconfigured items and setup will abort Result Setup can auto fix mandatory db configurations without asking for manual intervention. Change-Id: I99d5a661044a4077589326b8f215fa2152952304 Bug-Url: https://bugzilla.redhat.com/1388433 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/engine_common/dwh_shared_constants.py M packaging/setup/ovirt_engine_setup/engine_common/postgres.py M packaging/setup/ovirt_engine_setup/provisiondb/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/configuration.py 8 files changed, 348 insertions(+), 128 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Peřina: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/72111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d5a661044a4077589326b8f215fa2152952304 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: More aggressive autovacuum configuration
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: More aggressive autovacuum configuration ...................................................................... packaging: setup: More aggressive autovacuum configuration Configuring the autovacuum daemon to be more performant and aggressive. To make the daemon efficient we a) tell it to start working more frequent on small number of changes (vacuum_scale_factor), b) spin more workers as we have more then 3 tables which are updated frequently and we want to prevent from exhausting the vacuum cost on few tables and starving other tables from being vacuumed and c) raising the memory amount each worker have to the passes on the pages would be efficient and quick. Our v*_dynamic and v*_statistics tables (plus few more) are updated very frequently as part of our monitoring needs. Even though we keep on optimizing the amount of updates to the bare minimum we still have to make sure we don't starve any of those tables otherwise we are in the risk of bloating the db. Change-Id: I426de8d2903dc8430e14957738e04757eb4c7eb5 Bug-Url: https://bugzilla.redhat.com/1388433 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/postgres.py 4 files changed, 124 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/70309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I426de8d2903dc8430e14957738e04757eb4c7eb5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: userportal, webadmin: Italian translation update from Zanata
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: Italian translation update from Zanata ...................................................................... userportal, webadmin: Italian translation update from Zanata Refreshed Italian (it_IT) community provided translations from oVirt's zanata project, version master, as of February 10, 2017. Change-Id: I91b04f7651225754936f0b8f0ed3ffbce9fc1119 Bug-Url: https://bugzilla.redhat.com/1421285 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/resources/messages_it_IT.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_it_IT.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_it_IT.properties M packaging/branding/ovirt.brand/messages_it_IT.properties 12 files changed, 354 insertions(+), 61 deletions(-) Approvals: Tal Nisan: Passed CI tests Alexander Wels: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/72189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91b04f7651225754936f0b8f0ed3ffbce9fc1119 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: scheduler should filter hosts based on their cluster l...
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: scheduler should filter hosts based on their cluster level ...................................................................... core: scheduler should filter hosts based on their cluster level Previously, the scheduling filter that filters hosts by their compatibility version examined their 'supported engine versions' rather than 'supported cluster levels' that should have been checked. Change-Id: I54901716a39a0dd0f7618cea51e6de158a020657 Bug-Url: https://bugzilla.redhat.com/1421174 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CompatibilityVersionFilterPolicyUnit.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Sivák: Looks good to me, approved Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54901716a39a0dd0f7618cea51e6de158a020657 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.6]: dnfpackager: do not print traceback when fail to import dnf
by Code Review 13 Feb '17

13 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: dnfpackager: do not print traceback when fail to import dnf ...................................................................... dnfpackager: do not print traceback when fail to import dnf Bug-Url: https://bugzilla.redhat.com/1404253 Change-Id: I792d30e3a059e16a6899f1d8d3294e57f151a840 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> (cherry picked from commit 38257bf79f5b1ada2e847da68a49ef1dea2fa26f) --- M src/plugins/otopi/packagers/dnfpackager.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/72188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792d30e3a059e16a6899f1d8d3294e57f151a840 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: packaging: spec: dropping fc23 template
by Code Review 13 Feb '17

13 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: packaging: spec: dropping fc23 template ...................................................................... packaging: spec: dropping fc23 template fc23 is EOL Change-Id: I63113c98884f3a47f1d711c784209fa0c4c660d3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D packaging/spec.fc23.in 1 file changed, 0 insertions(+), 86 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63113c98884f3a47f1d711c784209fa0c4c660d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Italian translation update from Zanata
by Code Review 13 Feb '17

13 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: Italian translation update from Zanata ...................................................................... userportal, webadmin: Italian translation update from Zanata Refreshed Italian (it_IT) community provided translations from oVirt's zanata project, version master, as of February 10, 2017. Change-Id: I91b04f7651225754936f0b8f0ed3ffbce9fc1119 Bug-Url: https://bugzilla.redhat.com/1421285 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/resources/messages_it_IT.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_it_IT.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_it_IT.properties M packaging/branding/ovirt.brand/messages_it_IT.properties 12 files changed, 354 insertions(+), 61 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/72103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91b04f7651225754936f0b8f0ed3ffbce9fc1119 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0