- Engine-commits - oVirt List Archives

Change in otopi[master]: dnfpackager: do not print traceback when fail to import dnf
by Code Review 13 Feb '17

13 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: dnfpackager: do not print traceback when fail to import dnf ...................................................................... dnfpackager: do not print traceback when fail to import dnf Bug-Url: https://bugzilla.redhat.com/1404253 Change-Id: I792d30e3a059e16a6899f1d8d3294e57f151a840 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M src/plugins/otopi/packagers/dnfpackager.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/72177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792d30e3a059e16a6899f1d8d3294e57f151a840 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dashboards: Fixed host dashboard queries
by Code Review 13 Feb '17

13 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: dashboards: Fixed host dashboard queries ...................................................................... dashboards: Fixed host dashboard queries Fixed host.cpu_host_utilization and host.mem_host_utilization dashboard queries. Change-Id: I4102104188fbd089366f4d4e69f92090a4957e46 Bug-Url: https://bugzilla.redhat.com/1401010 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.properties 1 file changed, 78 insertions(+), 105 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4102104188fbd089366f4d4e69f92090a4957e46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Hide the 'Hosted Engine' subtab in edit host dialog
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Hide the 'Hosted Engine' subtab in edit host dialog ...................................................................... webadmin: Hide the 'Hosted Engine' subtab in edit host dialog Deploying and undeploying hosted engine using the edit dialog does not work, so there is no reason for the subtab. Change-Id: Ic8f53facc70c9c906ae4ade93b409f315c802ff7 Bug-Url: https://bugzilla.redhat.com/1416893 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> (cherry picked from commit 9bc79f8ccba1f55f45d7b83473cc64860b180e15) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/72063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8f53facc70c9c906ae4ade93b409f315c802ff7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: aaa: Allow define principal name for GSSAPI over JAAS
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: aaa: Allow define principal name for GSSAPI over JAAS ...................................................................... aaa: Allow define principal name for GSSAPI over JAAS Allows to define principal name using engine option AAA_JAAS_PRINCIPAL_NAME to use along with ticket cache or key tab when using JAAS inside JBoss. Change-Id: I3a71e45e032e8d4c864dc904c2d3994eaa796283 Bug-Url: https://bugzilla.redhat.com/1361223 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java M packaging/bin/ovirt-engine-extensions-tool.sh M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 4 files changed, 17 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a71e45e032e8d4c864dc904c2d3994eaa796283 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Reuse the id of newly created bond with removed bo...
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Reuse the id of newly created bond with removed bond name ...................................................................... webadmin: Reuse the id of newly created bond with removed bond name Change-Id: Ideb713af5617e07f5bc63e2b35556e99cf436975 Bug-Url: https://bugzilla.redhat.com/1413377 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 4 files changed, 67 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideb713af5617e07f5bc63e2b35556e99cf436975 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Error message when trying to remove and update same ...
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Error message when trying to remove and update same bond ...................................................................... engine: Error message when trying to remove and update same bond Change-Id: I4f583fac4e59c17418bc348513d5ae37cb9700fd Bug-Url: https://bugzilla.redhat.com/1413377 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 64 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f583fac4e59c17418bc348513d5ae37cb9700fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Create audit message for deprecated API usage
by Code Review 13 Feb '17

13 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: restapi: Create audit message for deprecated API usage ...................................................................... restapi: Create audit message for deprecated API usage Currently there is no mechanism to notify users that are using a deprecated version of the API. In order to address that this patch introduces a mechanism that will check the version of the API for each request, and will send a message to the audit log in case it is deprecated. The message will look like this: Client from address "192.168.122.38" is using version 3 of the API, which has been deprecated since version 4.0 of the engine, and will no longer be supported starting with version 4.2. Make sure to update that client to use a supported versions of the API and the SDKs, before upgrading to version 4.2 of the engine. This feature will be enabled by default for version 3 of the API, and will be configurably by the administrator using the following configuration setting: # # Comma separated list of versions of the API that are deprecated. Each # deprecated version is specified by three values, separated by colons. # The first value is the version of the API that is deprecated. The # second value is the version of the engine where that version of the # API was deprecated. The third value is the version of the engine where # that version of the API will be removed. For example, the following # text: # # 3:4.0:4.2 # # Means that version 3 of the API was deprecated in version 4.0 of the # engine and will be removed in version 4.2 of the engine. # # When the engine detects a request that is using a deprecated version # of the API it will send a message to the audit log explaining it. # ENGINE_API_DEPRECATED_VERSIONS="3:4.0:4.2" This setting is intended to allow disabling the feature. If the administrator wants to do so, she can just use an empty value: # cat >> /etc/ovirt-engine/engin.conf.d/99-mute-deprecation.conf <<. ENGINE_API_DEPRECATED_VERSIONS="" To avoid flooding the audit log when there are applications that send many requests using the deprecated version of the API the messages will be sent only once per day, for each different client IP address. As the message will be written to the audit log table, other applications, for example the setup tool, can use it to determine if there are applications that used recently a deprecated version of the API. For example, to check if a deprecated version of the API was used in the last 30 days: select count(*) from audit_log where log_type = 13000 and age(now(), log_time) < '30 days' Change-Id: I69cd6344fdb013869fef85518bd4b3ed36466b43 Bug-Url: https://bugzilla.redhat.com/1400996 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDeprecatedApiEventCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDeprecatedApiEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/DeprecatedVersionInfo.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/LocalConfig.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java M packaging/services/ovirt-engine/ovirt-engine.conf.in 9 files changed, 341 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69cd6344fdb013869fef85518bd4b3ed36466b43 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid PCI address conflict when existing interface i...
by Code Review 13 Feb '17

13 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: Avoid PCI address conflict when existing interface is in an ambiguous state. ...................................................................... engine: Avoid PCI address conflict when existing interface is in an ambiguous state. Updating vm device in DB by VM monitoring after plugging can take some time. During this time the user could request to plug another device. During this time the new device could use a duplicated PCI address. This patch safeguards us against this. Change-Id: I3a998cb2de239eb69acda6e50ac08e15b8d6e5be Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1412074 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a998cb2de239eb69acda6e50ac08e15b8d6e5be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredBlockStorageDomainsQueryTest mocking
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredBlockStorageDomainsQueryTest mocking ...................................................................... core: GetUnregisteredBlockStorageDomainsQueryTest mocking Remove redundant mocking that adds nothing to the test and may actually cause it to fail under strict mocking. Change-Id: I26039b40c496646dfabd8cfdaeb48c9cae05e7cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26039b40c496646dfabd8cfdaeb48c9cae05e7cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: createNetworkAttachmentWithIpv4Configuration args
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: createNetworkAttachmentWithIpv4Configuration args ...................................................................... core: createNetworkAttachmentWithIpv4Configuration args The netmask and address passed to createNetworkAttachmentWithIpv4Configuration are always null. This patch inlines these arguments to clean up the code and make it easier to read. Change-Id: Idbc50dfc8ec23275ed56bb434d7ce49e87edfdcd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 1 file changed, 6 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc50dfc8ec23275ed56bb434d7ce49e87edfdcd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0