- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add Debian and Ubuntu installation instructions
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Debian and Ubuntu installation instructions ...................................................................... Add Debian and Ubuntu installation instructions This patch adds to the top level README.adoc file some information about how to build and install the SDK in Debian and Ubuntu, specially taking into account that these distributions provided multiple variants of 'libcurl', and the SDK only works correctly with the OpenSSL version. Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 695c726f5b7312762008d54a5570dac13d082dfd) (cherry picked from commit a8cf1c55cc8a068f474f2c678ff509ecaeb79d1c) --- M README.adoc 1 file changed, 29 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-sdk-java: add fc25 support on master
by Code Review 09 Feb '17

09 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-sdk-java: add fc25 support on master ...................................................................... ovirt-engine-sdk-java: add fc25 support on master Change-Id: Id79f9218721e5cc3a259804158e8476ba2bc9847 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id79f9218721e5cc3a259804158e8476ba2bc9847 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add Debian and Ubuntu installation instructions
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Debian and Ubuntu installation instructions ...................................................................... Add Debian and Ubuntu installation instructions This patch adds to the top level README.adoc file some information about how to build and install the SDK in Debian and Ubuntu, specially taking into account that these distributions provided multiple variants of 'libcurl', and the SDK only works correctly with the OpenSSL version. Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 695c726f5b7312762008d54a5570dac13d082dfd) --- M README.adoc 1 file changed, 29 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use 'curl-config' to detect libcurl if possible
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'curl-config' to detect libcurl if possible ...................................................................... Use 'curl-config' to detect libcurl if possible Currently the build process of the SDK expects the 'pkg-config' file of the 'libcurl' library to be available, otherwise the build will fail. In some environments (macOS, for example) this may not be available. But curl also provides a 'curl-config' script, with similar capabilities, that seems to be more widely available. This patch changes the 'extconf.rb' file, so that it first tries with this script, and, if it fails, then tries with the 'pkg-config' mechanism. Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e148e54177617c483c0e686fb9b36eb42001e226) (cherry picked from commit de060dfb038fe68f22f9d492019e45e096c78204) --- M sdk/ext/ovirtsdk4c/extconf.rb 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use 'curl-config' to detect libcurl if possible
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'curl-config' to detect libcurl if possible ...................................................................... Use 'curl-config' to detect libcurl if possible Currently the build process of the SDK expects the 'pkg-config' file of the 'libcurl' library to be available, otherwise the build will fail. In some environments (macOS, for example) this may not be available. But curl also provides a 'curl-config' script, with similar capabilities, that seems to be more widely available. This patch changes the 'extconf.rb' file, so that it first tries with this script, and, if it fails, then tries with the 'pkg-config' mechanism. Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e148e54177617c483c0e686fb9b36eb42001e226) --- M sdk/ext/ovirtsdk4c/extconf.rb 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add Debian and Ubuntu installation instructions
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Debian and Ubuntu installation instructions ...................................................................... Add Debian and Ubuntu installation instructions This patch adds to the top level README.adoc file some information about how to build and install the SDK in Debian and Ubuntu, specially taking into account that these distributions provided multiple variants of 'libcurl', and the SDK only works correctly with the OpenSSL version. Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M README.adoc 1 file changed, 29 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99031f474dbef3820f3308b250b652b93fc15d42 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use 'curl-config' to detect libcurl if possible
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'curl-config' to detect libcurl if possible ...................................................................... Use 'curl-config' to detect libcurl if possible Currently the build process of the SDK expects the 'pkg-config' file of the 'libcurl' library to be available, otherwise the build will fail. In some environments (macOS, for example) this may not be available. But curl also provides a 'curl-config' script, with similar capabilities, that seems to be more widely available. This patch changes the 'extconf.rb' file, so that it first tries with this script, and, if it fails, then tries with the 'pkg-config' mechanism. Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/extconf.rb 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e04663cfff34e7bc34d02d4a9b7493df4445b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix glusternw role selection on attach
by Code Review 09 Feb '17

09 Feb '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: engine: fix glusternw role selection on attach ...................................................................... engine: fix glusternw role selection on attach Fix persisting gluster network role when network is attached to cluster Change-Id: I4a9ea8d8302e18b1c800b257bb41f9b04174ec4f Bug-Url: https://bugzilla.redhat.com/1379225 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a9ea8d8302e18b1c800b257bb41f9b04174ec4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Implement 'StorageDomainDisks' and 'AttachedStorage...
by Code Review 09 Feb '17

09 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Implement 'StorageDomainDisks' and 'AttachedStorageDomainDisks' ...................................................................... restapi: Implement 'StorageDomainDisks' and 'AttachedStorageDomainDisks' Currently we use the same 'Disks' service definitions fo the following disk collections: /disks /storagedomain/{sd:id}/disks /datacenters/{dc:id}/storagedomains/{sd:id}/disks This is wrong, because most operations on disk are then available in multiple places, and it prevents addition of new operations that only make sense for disks that aren't yet part of the system. A good example of this is the operation to register an unregistered disk. That only makes sense for disks that appear in /storagedomains/{sd:id}/disks. To improve the situation this patch implements the new 'StorageDomainDisks' and 'AttachedStorageDomainDisk' that have been introduced in the specification of the API by the following patch: Add 'StorageDomainDisks' and 'AttachedStorageDomainDisks' https://gerrit.ovirt.org/69634 After this, each collection will have its own service: /disks DisksService /storagedomain/{sd:id}/disks StorageDomainDisksService /datacenters/{dc:id}/storagedomains/{sd:id}/disks AttachedStorageDomainDisksService These services will initially preserve most of the duplicated operations, for backwards compatibility. Those duplicated operations will be marked as deprecated, and removed in a future version of the API. Change-Id: I1021d75609a7b07e6ebea279dd4e91ed37973725 Related-To: https://bugzilla.redhat.com/1366960 Related-To: https://gerrit.ovirt.org/69634 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainDiskResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainDisksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainDiskResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainDiskServer.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainServer.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainDiskServer.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java M pom.xml 19 files changed, 685 insertions(+), 160 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1021d75609a7b07e6ebea279dd4e91ed37973725 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: upgrade-engine: restored the master to master job
by Code Review 09 Feb '17

09 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: upgrade-engine: restored the master to master job ...................................................................... upgrade-engine: restored the master to master job Change-Id: I3df2e24326c4dec9f7cef1cc311c0d763f82a5ea Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df2e24326c4dec9f7cef1cc311c0d763f82a5ea Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0