- Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-4.0]: automation: fix issues detected by automation
by Code Review 09 Feb '17

09 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: fix issues detected by automation ...................................................................... automation: fix issues detected by automation - systemd is needed in build-artifacts for Fedora - we don't build node for Fedora Change-Id: I4ef63bb570c6e10e7f75b0dfdb352ac2bb944015 (cherry picked from commit 899e34229650c5ba89e8c3f1b93f6884768f041f) --- M automation/build-artifacts.packages M ovirt-release40.spec.in 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ef63bb570c6e10e7f75b0dfdb352ac2bb944015 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: automation: stop building unversioned rpms
by Code Review 09 Feb '17

09 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: stop building unversioned rpms ...................................................................... automation: stop building unversioned rpms having agnostic unversioned rpms is causing troubles to CI which is not able to handle this case. We'll find another way to handle the generation of the agnostic rpms. Change-Id: I22c32f2e60d3c2971429f6f2f6f3b94c459ebcb1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit c60bdf81d83e6b52d3e606ad733da7ea99584c53) --- M automation/build-artifacts.sh M automation/check-patch.sh 2 files changed, 0 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22c32f2e60d3c2971429f6f2f6f3b94c459ebcb1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: PropagateLabeledNetworksToClusterHostsCommand type inf...
by Code Review 09 Feb '17

09 Feb '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: PropagateLabeledNetworksToClusterHostsCommand type inference ...................................................................... core: PropagateLabeledNetworksToClusterHostsCommand type inference Change-Id: If8fc763f3d6766041b89b510ff1abeb26c6cec4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8fc763f3d6766041b89b510ff1abeb26c6cec4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in create vm
by Code Review 09 Feb '17

09 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in create vm ...................................................................... core: cleanup in create vm 1. Check if it's a windows VM only once. 2. Replace cumbersome if-else statements. 3. Store the VM we operate on as a class member instead of passing it all around as local variable. Change-Id: If50794cb983e48b9195efb1f4eb87e968e8f9783 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java 1 file changed, 22 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If50794cb983e48b9195efb1f4eb87e968e8f9783 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: forward compatibility for vm exit reason
by Code Review 09 Feb '17

09 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: forward compatibility for vm exit reason ...................................................................... core: forward compatibility for vm exit reason We noticed that when VDSM gets a VM with exit reason that is not supported, the parsing of that VM fails and the monitoring thinks that the VM was not reported by VDSM. This patch changes the parsing of the VM so when we encounter an invalid value of VM exit reason, we'll use 'Unknown' instead. Change-Id: I17cc8da24b9eaf257f9aa44f6e721f6248f4d4b2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17cc8da24b9eaf257f9aa44f6e721f6248f4d4b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Random Generator setting wrong value after saving next...
by Code Review 09 Feb '17

09 Feb '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: Random Generator setting wrong value after saving next run configuration ...................................................................... core: Random Generator setting wrong value after saving next run configuration When editing VM while its running we apply some of the fields on next run configuration - one of them is rng which need to be one but currently we add a new rng device instead of replacing the old one that cause unwanted results such as saving only one of the devices randomly. Change-Id: I86fc48f3488cf2dc6fdc2cf4da080e5a8a5c2495 Bug-Url: https://bugzilla.redhat.com/1419337 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86fc48f3488cf2dc6fdc2cf4da080e5a8a5c2495 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-sdk: add fc25 support on master
by Code Review 08 Feb '17

08 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-sdk: add fc25 support on master ...................................................................... ovirt-engine-sdk: add fc25 support on master Change-Id: I49db61672643164f2f19e926c8236ec085e8ed01 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49db61672643164f2f19e926c8236ec085e8ed01 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-guest-agent: add fc25 support
by Code Review 08 Feb '17

08 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-guest-agent: add fc25 support ...................................................................... ovirt-guest-agent: add fc25 support Change-Id: Iaad174ca6555cb465cdf40ce3e9d8ec3b685af98 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaad174ca6555cb465cdf40ce3e9d8ec3b685af98 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core, webadmin: Imported VMs have default maxMemory
by Code Review 08 Feb '17

08 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core, webadmin: Imported VMs have default maxMemory ...................................................................... core, webadmin: Imported VMs have default maxMemory ... instead of maximum of allowed value as defined in *MaxMemorySizeInMB configuration values. The default is 4x value of memory size and it is maximum suggested value of maxMemory. Default value of ConfigValues.VM64BitMaxMemorySizeInMB was changed to 4194304 to match the current value in vdc_options table. After this change default values of all *MaxMemorySizeInMB options should match values in vdc_options. Reasons for not exceeding suggested value: * QEMU goes through nested loop of size of the maxMemory at its start. Large value of maxMemory can make QEMU to start for a longer time. * We want hot plugged memory to be also hot unpluggable. This requires guest kernel to consider hotplugged memory to be 'movable'. Kernel may be unstable if movable part of memory is significantly larger than non-movable part of the memory. * On PowerPC platform continuous block of non-movable memory of size 1/64 of the max memory needs to be allocated for each VM. Bug-Url: https://bugzilla.redhat.com/1411844 Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-extension-logger-log4j: add fc25 support on master
by Code Review 08 Feb '17

08 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-logger-log4j: add fc25 support on master ...................................................................... ovirt-engine-extension-logger-log4j: add fc25 support on master Change-Id: I21d620e74a641e5507fd4ce65a234267ab3340b2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21d620e74a641e5507fd4ce65a234267ab3340b2 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0