- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: tools: expose ImageProxyAddress to engine-config
by Code Review 02 Aug '17

02 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80085 ) Change subject: tools: expose ImageProxyAddress to engine-config ...................................................................... tools: expose ImageProxyAddress to engine-config Added ImageProxyAddress key to engine-config.properties file in order to support setting its value using engine-config tool. Change-Id: Ieb56ed16681a8f789bed5a64aa344ef0917e827d Bug-Url: https://bugzilla.redhat.com/1476979 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb56ed16681a8f789bed5a64aa344ef0917e827d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: expose ImageProxyAddress to engine-config
by Code Review 02 Aug '17

02 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80047 ) Change subject: tools: expose ImageProxyAddress to engine-config ...................................................................... tools: expose ImageProxyAddress to engine-config Added ImageProxyAddress key to engine-config.properties file in order to support setting its value using engine-config tool. Change-Id: Ieb56ed16681a8f789bed5a64aa344ef0917e827d Bug-Url: https://bugzilla.redhat.com/1476979 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb56ed16681a8f789bed5a64aa344ef0917e827d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve matching of cd-rom devices
by Code Review 02 Aug '17

02 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80039 ) Change subject: core: improve matching of cd-rom devices ...................................................................... core: improve matching of cd-rom devices The previous matching of reported disks with those that exist in the database was tailored to ordinary disks and didn't work well for cd-rom devices. This patch enhances the matching of cd-rom and floppy devices. Change-Id: Ica4ae1868e99914abb0c3eab55fe0571775a1bec Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica4ae1868e99914abb0c3eab55fe0571775a1bec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix comment for cd-rom elements in the engine xml
by Code Review 02 Aug '17

02 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80006 ) Change subject: core: fix comment for cd-rom elements in the engine xml ...................................................................... core: fix comment for cd-rom elements in the engine xml Change-Id: Ib3567619e4a914378b469eb3f7acc49aef7d3e91 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3567619e4a914378b469eb3f7acc49aef7d3e91 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: enable engine xml by default
by Code Review 02 Aug '17

02 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79169 ) Change subject: core: enable engine xml by default ...................................................................... core: enable engine xml by default Enabled for 4.2 clusters and above. Change-Id: Ie7c588dbf6d2e6aad3b9a0abcacc94b8be187f66 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 29 insertions(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7c588dbf6d2e6aad3b9a0abcacc94b8be187f66 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: null check when parsing device alias from domain xml
by Code Review 02 Aug '17

02 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80038 ) Change subject: core: null check when parsing device alias from domain xml ...................................................................... core: null check when parsing device alias from domain xml Change-Id: If65a01c2ac84540d2aad0816836b874a72c4e863 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65a01c2ac84540d2aad0816836b874a72c4e863 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Set vmId to the target VM ID in ImportVmCommandBase
by Code Review 02 Aug '17

02 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80079 ) Change subject: core: Set vmId to the target VM ID in ImportVmCommandBase ...................................................................... core: Set vmId to the target VM ID in ImportVmCommandBase Set vmId field in the ImportVmCommandBase command to the ID of the target VM. This makes getVmIdRef() (that is used for audit logging) to return the correct VM ID. Change-Id: Ia545533d0ba471a01f2eef581f3fc244ea0276d9 Bug-Url: https://bugzilla.redhat.com/1477375 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia545533d0ba471a01f2eef581f3fc244ea0276d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Drop ovirt-engine-setup-plugin-dockerc
by Code Review 02 Aug '17

02 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79632 ) Change subject: packaging: setup: Drop ovirt-engine-setup-plugin-dockerc ...................................................................... packaging: setup: Drop ovirt-engine-setup-plugin-dockerc Change-Id: Ide10e81fef19d5bdf39f9edcde934eb6a4bc4eb3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1473182 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M ovirt-engine.spec.in D packaging/firewalld/dockerc/ovirt-local-cinder.xml.in D packaging/firewalld/dockerc/ovirt-local-glance.xml.in D packaging/setup/ovirt_engine_setup/dockerc/__init__.py D packaging/setup/ovirt_engine_setup/dockerc/constants.py D packaging/setup/plugins/ovirt-engine-common/dockerc/__init__.py D packaging/setup/plugins/ovirt-engine-common/dockerc/core.py D packaging/setup/plugins/ovirt-engine-remove/dockerc/__init__.py D packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py D packaging/setup/plugins/ovirt-engine-setup/dockerc/__init__.py D packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py 11 files changed, 0 insertions(+), 1,187 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide10e81fef19d5bdf39f9edcde934eb6a4bc4eb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix data table link cell rendering
by Code Review 01 Aug '17

01 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80067 ) Change subject: webadmin: fix data table link cell rendering ...................................................................... webadmin: fix data table link cell rendering The HTML composed by the text plus link cell was causing the link to render incorrectly. By putting the link on its own, with a small adjustment to the link style, the links will match the text cells. Change-Id: I45fcfa7c34ed1658bc4127c78d59b42187e04fd9 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css 3 files changed, 51 insertions(+), 32 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/80067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45fcfa7c34ed1658bc4127c78d59b42187e04fd9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Dashboard icon
by Code Review 01 Aug '17

01 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80072 ) Change subject: webadmin: Dashboard icon ...................................................................... webadmin: Dashboard icon - Due to recent changes, DynamicTab extended SimpleTab which caused the TabFactory to never get to DynamicTab as SimpleTab comparison happened first. Change the order to have the more specific instanceof check (DynamicTab) happen first. Change-Id: I1697372e1526f07974d754803942423ca3fc7633 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/TabFactory.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified; Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1697372e1526f07974d754803942423ca3fc7633 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0