- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Use default grid item comparator
by Code Review 01 Aug '17

01 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/76639 ) Change subject: webadmin: Use default grid item comparator ...................................................................... webadmin: Use default grid item comparator If a grid has no explicit column sorting applied by the user (which is the initial state of all grids), use a default item comparator with following logic: - first, try to compare by name (lexo-numeric) if the item is assignable to Nameable interface (this covers most, but not all, business entities), or treat it as null - otherwise (for items still considered equal by above rule), try to compare by queryable ID if the item is assignable to Queryable interface (this should cover the rest of entities), or treat it as null - finally, put "null" items at the end (nulls last strategy) Above comparator logic is in-line with the general UI design of having "Name" column with clickable links leading to detail views for each main grid. Above comparator is not applied if a grid has been explicitly sorted by the user (by clicking the given column header). Change-Id: I4711af76410a16354c38c083130be1c2e033306f Bug-Url: https://bugzilla.redhat.com/1445235 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java 3 files changed, 44 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/76639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4711af76410a16354c38c083130be1c2e033306f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: preview snapshot button
by Code Review 01 Aug '17

01 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80071 ) Change subject: webadmin: preview snapshot button ...................................................................... webadmin: preview snapshot button - Fixed preview snapshot not being a combo button Change-Id: Icbb4b6803f87693b31311d5bd6580367a00d222e Bug-Url: https://bugzilla.redhat.com/1474841 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/SnapshotActionPanelPresenterWidget.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbb4b6803f87693b31311d5bd6580367a00d222e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: bootstrap buttons for user/group select on user list
by Code Review 01 Aug '17

01 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80069 ) Change subject: webadmin: bootstrap buttons for user/group select on user list ...................................................................... webadmin: bootstrap buttons for user/group select on user list Convert the user/group selection radio buttons on the user admin data table to be bootstrap radio buttons. Adjust the simple action table overhead container to better layout the buttons and to add the top border to the data table. Change-Id: I9fd521e67de940474a4f4b2e9adf4917b0852a8d Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/users/UsersTypeRadioGroup.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/users/UsersTypeRadioGroup.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 5 files changed, 27 insertions(+), 35 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/80069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd521e67de940474a4f4b2e9adf4917b0852a8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: fix typo in ovirtmgmt network check
by Code Review 01 Aug '17

01 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80065 ) Change subject: inventory: fix typo in ovirtmgmt network check ...................................................................... inventory: fix typo in ovirtmgmt network check Change-Id: I1060b216142a86d25708e3c0ee7ae427e0f35e07 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/network_query_cluster_with_non_ovirtmgmt_as_management_network.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1060b216142a86d25708e3c0ee7ae427e0f35e07 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: check if management network is not ovirtmgmt
by Code Review 01 Aug '17

01 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80028 ) Change subject: inventory: check if management network is not ovirtmgmt ...................................................................... inventory: check if management network is not ovirtmgmt Hosted engine upgrades can be affect if the management network is 'rhevm'. See bz#1449547 for more info. Change-Id: I0aeeba9501710e7c7cf767b85dc972025e9fb54f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/network_query_cluster_with_non_ovirtmgmt_as_management_network.sql 4 files changed, 66 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aeeba9501710e7c7cf767b85dc972025e9fb54f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: split bash and SQL - storage domains
by Code Review 01 Aug '17

01 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80026 ) Change subject: inventory: split bash and SQL - storage domains ...................................................................... inventory: split bash and SQL - storage domains Change-Id: I352ad8cea86560c4170fe7d2abcf098b709b7da7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/storage_domains_query_data.sql 3 files changed, 25 insertions(+), 20 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352ad8cea86560c4170fe7d2abcf098b709b7da7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use engine xml according to cluster compatibility version
by Code Review 01 Aug '17

01 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79984 ) Change subject: core: use engine xml according to cluster compatibility version ...................................................................... core: use engine xml according to cluster compatibility version By not specifying any version when checking the config-value, we essentially check the 'general' version. That is not what we want to determine whether or not to use the engine xml by, but to check if engine xml is enabled for the VM compatibility version instead. Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c2cb80dcdbe3980d23434edcb91cd5929454b6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix missing validation highlight
by Code Review 01 Aug '17

01 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80054 ) Change subject: webadmin: Fix missing validation highlight ...................................................................... webadmin: Fix missing validation highlight This patch fixes the missing validation highlight on the 'Physical Memory Guaranteed' field in the 'Resource Allocation' side tab of the new/edit VM popup dialog. Change-Id: I5c3b95862c8e541829689e1e3393b9447f1fcbdd Bug-Url: https://bugzilla.redhat.com/1456778 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/80054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3b95862c8e541829689e1e3393b9447f1fcbdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: config: Made LibGfApi configurable using engine-config
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79785 ) Change subject: config: Made LibGfApi configurable using engine-config ...................................................................... config: Made LibGfApi configurable using engine-config Change-Id: Ifda65801d2e7d756109b9f79c6e7c2ecf07cd5db Bug-Url: https://bugzilla.redhat.com/1022961 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifda65801d2e7d756109b9f79c6e7c2ecf07cd5db Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: libgfapi feature and cluster level feature have diff...
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79895 ) Change subject: engine: libgfapi feature and cluster level feature have different names. ...................................................................... engine: libgfapi feature and cluster level feature have different names. Change-Id: I9e4788b6028622f282a527feff6ab5b15c77e786 Bug-Url: https://bugzilla.redhat.com/1022961 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Denis Chaplygin: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e4788b6028622f282a527feff6ab5b15c77e786 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0