- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: fix inconsistency with empty cd-rom value
by tnisan＠redhat.com 26 Oct '16

26 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix inconsistency with empty cd-rom value ...................................................................... core: fix inconsistency with empty cd-rom value By default, the CD-ROM attached to the VM is NULL. VDSM also reports NULL value in case no CD-ROM is attached. Recently RunVmCommand was changed to persist the CD-ROM that is attached to a VM as well, however, it is then set to an empty string if no CD-ROM is attached. Therefore, the monitoring gets empty string from the DB and NULL value from VDSM and decides to update VM dynamic data because of this change. But later on, the NULL value from VDSM is ignored and thus, this flow will happen on every monitoring cycle, leading to many redundant updates of VM dynamic daa. Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37 Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java A packaging/dbscripts/upgrade/04_00_0950_empty_current_cd_to_null.sql 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e2afff36f3ee02b57a43760ab88f0a9c3176f37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: do not compare hash of guest agent nics in vms monitoring
by tnisan＠redhat.com 26 Oct '16

26 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: do not compare hash of guest agent nics in vms monitoring ...................................................................... core: do not compare hash of guest agent nics in vms monitoring The hash of the network interfaces reported by the guest agent is computed by the engine (rather than reported by VDSM) and therefore should not be a part of the comparison of the dynamic data from the database and the data reported by VDSM in VMs monitoring that leads to redundant updates of the dynamic data of VMs. Change-Id: I01629b006525cd30be5d7cdf6e6ccd398131d50a Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01629b006525cd30be5d7cdf6e6ccd398131d50a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: do not compare hash in vms monitoring
by tnisan＠redhat.com 26 Oct '16

26 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: do not compare hash in vms monitoring ...................................................................... core: do not compare hash in vms monitoring The devices hash is now processed by VmDevicesMonitoring so no need to compare it against the value in the database as part of the analysis of VmAnalyzer. Change-Id: Ib080211a9ecf52d4b63b102d6255f27109b92113 Bug-Url: https://bugzilla.redhat.com/1340722 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib080211a9ecf52d4b63b102d6255f27109b92113 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: refactoring of AddRemoveRowWidget, split overgrown...
by mbetak＠redhat.com 26 Oct '16

26 Oct '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: refactoring of AddRemoveRowWidget, split overgrown method. ...................................................................... webadmin: refactoring of AddRemoveRowWidget, split overgrown method. usualy everytime a method accepts boolean flag, this method is overgrown, worsening maintenance and readability. Change-Id: I396a048d696ae12773d9ae2b93b17036b8b2b10b Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java 1 file changed, 52 insertions(+), 34 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396a048d696ae12773d9ae2b93b17036b8b2b10b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Add missing parameters to Power saving balance p...
by msivak＠redhat.com 26 Oct '16

26 Oct '16

Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Add missing parameters to Power saving balance policy ...................................................................... scheduling: Add missing parameters to Power saving balance policy The Enable automatic PM and Hosts in reserve options were not visible from the webadmin. Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1384563 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Artyom Lukianov: Looks good to me, but someone else must approve Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Use Optional.empty() instead of null in schedule...
by msivak＠redhat.com 26 Oct '16

26 Oct '16

Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Use Optional.empty() instead of null in schedule call ...................................................................... scheduling: Use Optional.empty() instead of null in schedule call A small cleanup of the scheduling API that should be a bit more NPE safe and removes some obsolete Guid.Empty checks. Change-Id: I281345ee566bbc944351fc4a362ed068e4a32cc6 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 3 files changed, 17 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I281345ee566bbc944351fc4a362ed068e4a32cc6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi, core: add force member to StorageServerConnectionPar...
by derez＠redhat.com 26 Oct '16

26 Oct '16

Daniel Erez has submitted this change and it was merged. Change subject: restapi,core: add force member to StorageServerConnectionParametersBase ...................................................................... restapi,core: add force member to StorageServerConnectionParametersBase * Added 'force' member to StorageServerConnectionParametersBase. * Used in order to enable updating a storage connection regardless to storage domain's status (i.e. also when the domain is not in status Maintenance). Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8 Bug-Url: https://bugzilla.redhat.com/1379771 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 14 files changed, 42 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Adding bond_active_slave to vds_interface
by emesika＠redhat.com 26 Oct '16

26 Oct '16

Eli Mesika has submitted this change and it was merged. Change subject: engine: Adding bond_active_slave to vds_interface ...................................................................... engine: Adding bond_active_slave to vds_interface To prepare exposing the information of the active slave in a "bonded" interface, a column is added to the table vds_interface in the database. Bug-Url: https://bugzilla.redhat.com/1038550 Change-Id: Ib710d7da480629411f81e4328559de30d06c202a Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0360_add_bond_active_slave_to_vds_interface.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib710d7da480629411f81e4328559de30d06c202a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove GetCpuStatisticsByVdsId
by ahadas＠redhat.com 26 Oct '16

26 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove GetCpuStatisticsByVdsId ...................................................................... core: remove GetCpuStatisticsByVdsId Remove the unused query GetCpuStatisticsByVdsId. Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/host/GetCpuStatisticsByVdsIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/65732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bd92acee4bb77898788e1158e9e1df1a4317e96 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Inject members for ALB with VdsName
by amureini＠redhat.com 26 Oct '16

26 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Inject members for ALB with VdsName ...................................................................... core: Inject members for ALB with VdsName getVdsName() apparently performs a DAO call even if its vds member is set. This patch fixes a gap from patch 2d9dc8 and injects the DAOs to those AuditLoggableBases too. Change-Id: I9f4c589307f7dd3907289f82fe62b2b8add59e13 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f4c589307f7dd3907289f82fe62b2b8add59e13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0