- Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Disable bug status change for draft patches
by sbendavi＠redhat.com 25 Oct '16

25 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Disable bug status change for draft patches ...................................................................... Disable bug status change for draft patches We shouldn't change bug status (to POST) for drafts patches. Change-Id: I3a28bafe1525a8f23dc11ef8a915490729ef64a3 Fixes: OVIRT-788 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a28bafe1525a8f23dc11ef8a915490729ef64a3 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Require Ruby 2
by juan.hernandez＠redhat.com 25 Oct '16

25 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Require Ruby 2 ...................................................................... Require Ruby 2 The SDK is no longer built or tested with Ruby 1.9, as it is now unsupported and no longer available in the platforms supported by oVirt. To make that explicit this patch changes the .gemspec file to indicate that Ruby 2 is required. Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 38639f341c0c6690a61d07bb342907ee8cc1d75b) --- M sdk/ovirt-engine-sdk.gemspec 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Separate DNS server addresses with spaces
by juan.hernandez＠redhat.com 25 Oct '16

25 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Separate DNS server addresses with spaces ...................................................................... restapi: Separate DNS server addresses with spaces Currently when a set of DNS servers is provided as the initialization data for a virtual machine the result is concatenated and saved to the database, without spaces. For example, if the following data passed to the API: <vm> <initialization> <cloud_init> <network_configuration> <dns> <servers> <host> <address>192.168.0.1</address> </host> <host> <address>192.168.0.2</address> </host> <host> <address>192.168.0.3</address> </host> </servers> </dns> ... </network_configuration> ... </cloud_init> </initialization> ... </vm> Then the following is stored in the database (note that there are no spaces separating the addresses): 192.168.0.1192.168.0.2192.168.0.3 And the following is added to the generated cloud-init configuration file: dns-nameservers 192.168.0.1192.168.0.2192.168.0.3 This way to provide the cloud-init configuration is deprecated, the preferred way is to use directly the 'initialization' element: <vm> <initialization> <dns_servers>192.168.0.1 192.168.0.2 192.168.0.3</dns_servers> ... </initialization> ... </vm> But we should fix the issue anyhow. That is what this patch does. Change-Id: I417bd7b1da69bda0d3b2879ee519ea4744fd35a9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I417bd7b1da69bda0d3b2879ee519ea4744fd35a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sven Kieske <svenkieskemittwald(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Fix JqueryUtils.getTextFromHtml
by tnisan＠redhat.com 25 Oct '16

25 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Fix JqueryUtils.getTextFromHtml ...................................................................... webadmin,userportal: Fix JqueryUtils.getTextFromHtml oVirt GWT UI currently uses jQuery version 1.11.3 Quote from jQuery upgrade guide [1]: " As of 1.9, a string is only considered to be HTML if it starts with a less-than ("<") character. .. If a string is known to be HTML but may start with arbitrary text that is not an HTML tag, pass it to jQuery.parseHTML() which will return an array of DOM nodes representing the markup. " [1] http://stage.jquery.com/upgrade-guide/1.9/#jquery-htmlstring-versus-jquery-… The problem was that jQuery treated `html` argument as selector if the string didn't start with `<` character. Because of this, the string failed to parse as selector, resulting in error like: Syntax error, unrecognized expression: Dev. Size This patch fixes the problem. Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946 Bug-Url: https://bugzilla.redhat.com/1386765 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/65692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Restore SAN storage device size column header in n...
by tnisan＠redhat.com 25 Oct '16

25 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Restore SAN storage device size column header in new disk popup ...................................................................... webadmin: Restore SAN storage device size column header in new disk popup Commit 96025168 fixed the JQuery error when creating a new disk among other errors, it's not safe to restore the original column header Change-Id: I7a779c7aa23e0014ae70a9928f6df89a60eefab9 Bug-Url: https://bugzilla.redhat.com/1383220 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a779c7aa23e0014ae70a9928f6df89a60eefab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate StoragePoolDomainHelper to CDI
by mbetak＠redhat.com 25 Oct '16

25 Oct '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Migrate StoragePoolDomainHelper to CDI ...................................................................... backend: Migrate StoragePoolDomainHelper to CDI Change-Id: I30d8bf4382dc1378cee673693b687c968a73ee57 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SetStoragePoolStatusCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java 3 files changed, 28 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30d8bf4382dc1378cee673693b687c968a73ee57 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Require Ruby 2
by juan.hernandez＠redhat.com 25 Oct '16

25 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Require Ruby 2 ...................................................................... Require Ruby 2 The SDK is no longer built or tested with Ruby 1.9, as it is now unsupported and no longer available in the platforms supported by oVirt. To make that explicit this patch changes the .gemspec file to indicate that Ruby 2 is required. Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ovirt-engine-sdk.gemspec 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f00ddae5acb26f053c72a3c3f12f8e2e776a5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove InternalMigrateVmCommand
by ahadas＠redhat.com 25 Oct '16

25 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Remove InternalMigrateVmCommand ...................................................................... core: Remove InternalMigrateVmCommand The same functionality was merged to MigrateVmCommand, which checks if it is run as an internal command. Change-Id: I5c7dcdf4d2b6e1dc441bd7be9b8ddf4e00c795c4 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/async_tasks_map.py 9 files changed, 7 insertions(+), 85 deletions(-) Approvals: Jenkins CI: Passed CI tests Andrej Krejcir: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c7dcdf4d2b6e1dc441bd7be9b8ddf4e00c795c4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add migration reason to the audit log
by ahadas＠redhat.com 25 Oct '16

25 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Add migration reason to the audit log ...................................................................... core: Add migration reason to the audit log Change-Id: I053272b08ce6492a7cd062125b8692af588fa816 Bug-Url: https://bugzilla.redhat.com/1377632 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/BasicMigrationHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/MigrationHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 12 files changed, 60 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/64277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I053272b08ce6492a7cd062125b8692af588fa816 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Do not suggest to use password 'engine'
by sbonazzo＠redhat.com 25 Oct '16

25 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not suggest to use password 'engine' ...................................................................... packaging: setup: Do not suggest to use password 'engine' Change-Id: I344f0c3f5b78a25270c5ed6f5342a31e9ad8c0b9 Related-To: https://bugzilla.redhat.com/1384417 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I344f0c3f5b78a25270c5ed6f5342a31e9ad8c0b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0