- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Run Rubocop as part of the 'test' task
by juan.hernandez＠redhat.com 25 Oct '16

25 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Run Rubocop as part of the 'test' task ...................................................................... Run Rubocop as part of the 'test' task This patch fixes most of the Rubocop complaints, and disables the cops that can't be easily addressed, so that we can actually run Rubocop on the source as part of the 'test' task. Note that the generated code has also been improved to generate less Rubocop complaints (1.9 hash syntax, no return, etc), but it isn't actually checked because it takes too long, and some complaints (long lines, for example) are hard to avoid. Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4f25dd3f80efca0954984e13e41a9608a5b3fb29) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/.rubocop.yml M sdk/Gemfile M sdk/README.adoc M sdk/Rakefile M sdk/examples/add_cluster.rb M sdk/examples/add_data_center.rb M sdk/examples/add_group.rb M sdk/examples/add_host.rb M sdk/examples/add_independent_vm.rb A sdk/examples/add_mac_pool.rb M sdk/examples/add_nfs_data_storage_domain.rb M sdk/examples/add_nfs_iso_storage_domain.rb M sdk/examples/add_openstack_image_provider.rb M sdk/examples/add_vm.rb M sdk/examples/add_vm_disk.rb M sdk/examples/add_vm_nic.rb M sdk/examples/add_vm_snapshot.rb M sdk/examples/attach_nfs_data_storage_domain.rb M sdk/examples/attach_nfs_iso_storage_domain.rb M sdk/examples/change_vm_cd.rb M sdk/examples/enable_compression.rb M sdk/examples/follow_vm_links.rb M sdk/examples/import_external_vm.rb M sdk/examples/kerberos_authentication.rb M sdk/examples/list_vm_disks.rb M sdk/examples/list_vms.rb M sdk/examples/page_vms.rb M sdk/examples/remove_host.rb M sdk/examples/remove_vm.rb M sdk/examples/search_vms.rb M sdk/examples/set_vm_serial_number.rb M sdk/examples/show_summary.rb M sdk/examples/start_vm.rb M sdk/examples/stop_vm.rb M sdk/examples/update_data_center.rb M sdk/lib/ovirtsdk4/connection.rb M sdk/lib/ovirtsdk4/probe.rb M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/service.rb M sdk/lib/ovirtsdk4/type.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/ovirt-engine-sdk.gemspec M sdk/spec/action_reader_spec.rb M sdk/spec/cluster_reader_spec.rb M sdk/spec/clusters_service_spec.rb M sdk/spec/connection_create_spec.rb M sdk/spec/connection_timeout_spec.rb M sdk/spec/connection_use_spec.rb M sdk/spec/data_centers_service_spec.rb M sdk/spec/enum_spec.rb M sdk/spec/fault_reader_spec.rb M sdk/spec/network_reader_spec.rb M sdk/spec/network_writer_spec.rb M sdk/spec/openstack_image_provider_writer_spec.rb M sdk/spec/probe_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/service_spec.rb M sdk/spec/spec_helper.rb M sdk/spec/storage_domain_service_spec.rb M sdk/spec/storage_domains_service_spec.rb M sdk/spec/type_spec.rb M sdk/spec/vm_reader_spec.rb M sdk/spec/vm_service_spec.rb M sdk/spec/vm_spec.rb M sdk/spec/vm_writer_spec.rb M sdk/spec/vms_service_spec.rb M sdk/spec/writer_spec.rb M sdk/spec/xml_reader_spec.rb M sdk/spec/xml_writer_spec.rb 74 files changed, 1,521 insertions(+), 1,852 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Run Rubocop as part of the 'test' task
by juan.hernandez＠redhat.com 25 Oct '16

25 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Run Rubocop as part of the 'test' task ...................................................................... Run Rubocop as part of the 'test' task This patch fixes most of the Rubocop complaints, and disables the cops that can't be easily addressed, so that we can actually run Rubocop on the source as part of the 'test' task. Note that the generated code has also been improved to generate less Rubocop complaints (1.9 hash syntax, no return, etc), but it isn't actually checked because it takes too long, and some complaints (long lines, for example) are hard to avoid. Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/.rubocop.yml M sdk/Gemfile M sdk/README.adoc M sdk/Rakefile M sdk/examples/add_cluster.rb M sdk/examples/add_data_center.rb M sdk/examples/add_group.rb M sdk/examples/add_host.rb M sdk/examples/add_independent_vm.rb M sdk/examples/add_mac_pool.rb M sdk/examples/add_nfs_data_storage_domain.rb M sdk/examples/add_nfs_iso_storage_domain.rb M sdk/examples/add_openstack_image_provider.rb M sdk/examples/add_vm.rb M sdk/examples/add_vm_disk.rb M sdk/examples/add_vm_nic.rb M sdk/examples/add_vm_snapshot.rb M sdk/examples/attach_nfs_data_storage_domain.rb M sdk/examples/attach_nfs_iso_storage_domain.rb M sdk/examples/change_vm_cd.rb M sdk/examples/enable_compression.rb M sdk/examples/follow_vm_links.rb M sdk/examples/import_external_vm.rb M sdk/examples/kerberos_authentication.rb M sdk/examples/list_vm_disks.rb M sdk/examples/list_vms.rb M sdk/examples/page_vms.rb M sdk/examples/remove_host.rb M sdk/examples/remove_vm.rb M sdk/examples/search_vms.rb M sdk/examples/set_vm_serial_number.rb M sdk/examples/show_summary.rb M sdk/examples/start_vm.rb M sdk/examples/stop_vm.rb M sdk/examples/update_data_center.rb M sdk/lib/ovirtsdk4/connection.rb M sdk/lib/ovirtsdk4/probe.rb M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/service.rb M sdk/lib/ovirtsdk4/type.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/ovirt-engine-sdk.gemspec M sdk/spec/action_reader_spec.rb M sdk/spec/cluster_reader_spec.rb M sdk/spec/clusters_service_spec.rb M sdk/spec/connection_create_spec.rb M sdk/spec/connection_timeout_spec.rb M sdk/spec/connection_use_spec.rb M sdk/spec/data_centers_service_spec.rb M sdk/spec/enum_spec.rb M sdk/spec/fault_reader_spec.rb M sdk/spec/network_reader_spec.rb M sdk/spec/network_writer_spec.rb M sdk/spec/openstack_image_provider_writer_spec.rb M sdk/spec/probe_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/service_spec.rb M sdk/spec/spec_helper.rb M sdk/spec/storage_domain_service_spec.rb M sdk/spec/storage_domains_service_spec.rb M sdk/spec/type_spec.rb M sdk/spec/vm_reader_spec.rb M sdk/spec/vm_service_spec.rb M sdk/spec/vm_spec.rb M sdk/spec/vm_writer_spec.rb M sdk/spec/vms_service_spec.rb M sdk/spec/writer_spec.rb M sdk/spec/xml_reader_spec.rb M sdk/spec/xml_writer_spec.rb 74 files changed, 1,467 insertions(+), 1,870 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix JqueryUtils.getTextFromHtml
by awels＠redhat.com 25 Oct '16

25 Oct '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin,userportal: Fix JqueryUtils.getTextFromHtml ...................................................................... webadmin,userportal: Fix JqueryUtils.getTextFromHtml oVirt GWT UI currently uses jQuery version 1.11.3 Quote from jQuery upgrade guide [1]: " As of 1.9, a string is only considered to be HTML if it starts with a less-than ("<") character. .. If a string is known to be HTML but may start with arbitrary text that is not an HTML tag, pass it to jQuery.parseHTML() which will return an array of DOM nodes representing the markup. " [1] http://stage.jquery.com/upgrade-guide/1.9/#jquery-htmlstring-versus-jquery-… The problem was that jQuery treated `html` argument as selector if the string didn't start with `<` character. Because of this, the string failed to parse as selector, resulting in error like: Syntax error, unrecognized expression: Dev. Size This patch fixes the problem. Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946 Bug-Url: https://bugzilla.redhat.com/1386765 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/65690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic939c09f3cb2e2a80b6ef2dd15cb759cbc27f946 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmCommand - init spID in init()
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmCommand - init spID in init() ...................................................................... core: RunVmCommand - init spID in init() Move the initialization of the storage pool id, which potentially accesses the database from the constructor to the init() method where it belongs. Change-Id: I3e2cdbea79842431ee2d26da6f5a153a625d0960 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2cdbea79842431ee2d26da6f5a153a625d0960 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Introduce IrsProxyManager
by mbetak＠redhat.com 25 Oct '16

25 Oct '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Introduce IrsProxyManager ...................................................................... backend: Introduce IrsProxyManager * Renamed IrsProxyData to IrsProxy * IrsProxy has now depencencies via CDI * Extracted IrsProxy bookkeeping logic from IrsBrokerCommand to new IrsProxyManager backend service * Various methods that needed to be collocated in IrsBrokerCommand due to dependency on the IrsProxy map have been moved to respective use-sites with the added dependency on IrsProxyManager Change-Id: Ia97fe2ae850a239fd418579528c00a5243f3a181 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DestroyStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsoDirectoryVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MarkPoolInReconstructModeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMClearTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksStatusesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMRevertTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMStopTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java 20 files changed, 300 insertions(+), 241 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia97fe2ae850a239fd418579528c00a5243f3a181 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVmCommandTest DbFacade mocking
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmCommandTest DbFacade mocking ...................................................................... core: UpdateVmCommandTest DbFacade mocking Removed the redundant mocking of the DbFacade. Change-Id: I955a93f902724b69beb1b76acc63396697a61bc7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I955a93f902724b69beb1b76acc63396697a61bc7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant InjectorRule usages
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant InjectorRule usages ...................................................................... core: Remove redundant InjectorRule usages Change-Id: I36894189270d28520eb203b7e586560c1dbedebf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 5 files changed, 8 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36894189270d28520eb203b7e586560c1dbedebf Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant command spying
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant command spying ...................................................................... core: Remove redundant command spying @Spying a command and then mocking behavior with do[Return|Answer|Nothing] is a common practice in BLL's tests which originated from the need to mock DAOs' behavior. After the recent changes, the commands' DAOs are injected, so in many scenarios using @Spy is redundant, and @InjectMocks is sufficient to introduce the required dependencies. This patch removes these redundant spying by doing the following: - Remove the @Spy annotation where possible - Using straight-forward setter methods instead of spying the behavior of getters with doReturn. This has an added bonus of testing another method of the command, albeit a simple one. Change-Id: I828e0f55cec9ccbe873636ca40afb8bbbcf1daf3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractRolesCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalStepCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalJobCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalStepCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateWatchdogCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcherTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommandTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 25 files changed, 2 insertions(+), 53 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828e0f55cec9ccbe873636ca40afb8bbbcf1daf3 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommand#loadConfigValue
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ProcessOvfUpdateForStoragePoolCommand#loadConfigValue ...................................................................... core: ProcessOvfUpdateForStoragePoolCommand#loadConfigValue loadConfigValue was an artificial method that had exactly one use - to be mocked out by the test. This patch removes this useless method and replaces its mocking with the project's standard MockConfigRule. Change-Id: I7137c5b86870d66cd25d8db8e194938362cb4cb8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7137c5b86870d66cd25d8db8e194938362cb4cb8 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase: @Inject BusinessEntitySnapshotDao
by amureini＠redhat.com 25 Oct '16

25 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CommandBase: @Inject BusinessEntitySnapshotDao ...................................................................... core: CommandBase: @Inject BusinessEntitySnapshotDao Change-Id: I5c02a3eb20034fb3265175f1f0622886de9165c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c02a3eb20034fb3265175f1f0622886de9165c4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0