- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Rm ChangeVDSClusterCommand#targetClusterCompatibilityV...
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Rm ChangeVDSClusterCommand#targetClusterCompatibilityVersion ...................................................................... core: Rm ChangeVDSClusterCommand#targetClusterCompatibilityVersion Calculating targetClusterCompatibilityVersion requires access to the ClusterDao, and doing so in a data member means that DAO cannot be injected. Since this member is only used in one place anyway, it makes very little sense holding it as a member, so this patch inlines the call. Doing so has some advantages: 1. As mentioned above, it allows injecting the DAO 2. Performance: The command may fail its validation before the targetCluster is required. In this case, a database call is saved. Change-Id: Ie01547f3b3e3b87dc6addd313e7d4f8ef418ebbf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01547f3b3e3b87dc6addd313e7d4f8ef418ebbf Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AuditLogableBase: @Inject StorageServerConnectionLunMa...
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AuditLogableBase: @Inject StorageServerConnectionLunMapDao ...................................................................... core: AuditLogableBase: @Inject StorageServerConnectionLunMapDao @Inject the StorageServerConnectionLunMapDao and fix the tests accordingly. Change-Id: I2daa932cfb4a30812dd8559ac42ef70fc3895396 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageConnectionToStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageServerConnectionToStorageDomainCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 4 files changed, 8 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2daa932cfb4a30812dd8559ac42ef70fc3895396 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AuditLogableBase: @Inject LunDao
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AuditLogableBase: @Inject LunDao ...................................................................... core: AuditLogableBase: @Inject LunDao @Inject the LunDao and fix the tests accordingly. Change-Id: I8ad14086058dbd451fb1ef0a3e429e87c1a62145 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageConnectionToStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectAllHostsToLunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AttachStorageServerConnectionToStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 16 files changed, 21 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad14086058dbd451fb1ef0a3e429e87c1a62145 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AuditLogableBase: @Inject GlusterHooksDao
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AuditLogableBase: @Inject GlusterHooksDao ...................................................................... core: AuditLogableBase: @Inject GlusterHooksDao @Inject the GlusterHooksDao and fix the tests accordingly. Change-Id: I48eec4f6ce9b6c94abcd2946dbe9db242e663f07 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 9 files changed, 15 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48eec4f6ce9b6c94abcd2946dbe9db242e663f07 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EndExternalStepCommandTest @Before annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: EndExternalStepCommandTest @Before annotation ...................................................................... core: EndExternalStepCommandTest @Before annotation Use the @Before annotation to set up the test instead of having to explicitly call setupMock() in each test case. Change-Id: I59a9f88a967dd6225535ffcdf665e07330d32148 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalStepCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59a9f88a967dd6225535ffcdf665e07330d32148 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove EndExternalStepCommandTest#log
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove EndExternalStepCommandTest#log ...................................................................... core: Remove EndExternalStepCommandTest#log Removed the unused mocked logger. Change-Id: I37dac353736e43fdb738396caaf0df91b7e5ce5b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalStepCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37dac353736e43fdb738396caaf0df91b7e5ce5b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClearExternalStepCommandTest @Spy annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ClearExternalStepCommandTest @Spy annotation ...................................................................... core: ClearExternalStepCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I1d190589fa849b429b1ab7e40311902941728bc0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 14 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d190589fa849b429b1ab7e40311902941728bc0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove ClearExternalStepCommandTest#log
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove ClearExternalStepCommandTest#log ...................................................................... core: Remove ClearExternalStepCommandTest#log Removed the unused mocked logger. Change-Id: Ice02828f9cb36d19da7d8972e97e689bd2a2dad0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice02828f9cb36d19da7d8972e97e689bd2a2dad0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClearExternalStepCommandTest @Before annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ClearExternalStepCommandTest @Before annotation ...................................................................... core: ClearExternalStepCommandTest @Before annotation Use the @Before annotation to set up the test instead of having to explicitly call setupMock() in each test case. Change-Id: I04e36ee60b96cb9229f23d061a91d7ab61c6cbdd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClearExternalJobCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e36ee60b96cb9229f23d061a91d7ab61c6cbdd Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVdsSpmIdCommandTest @Spy annotation
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddVdsSpmIdCommandTest @Spy annotation ...................................................................... core: AddVdsSpmIdCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I62adc73946abe14ead613028dbf0bbde57db527e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62adc73946abe14ead613028dbf0bbde57db527e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0