- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmTemplateHandler#isVmTemplateImagesReady
by tnisan＠redhat.com 24 Oct '16

24 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: VmTemplateHandler#isVmTemplateImagesReady ...................................................................... core: VmTemplateHandler#isVmTemplateImagesReady Move the isVmTemplateImagesReady static method to VmTemplateHandler, which is a utility class for handling templates, instead of having it in a command and forcing commands of several hierarchies to have cross dependencies. Change-Id: Id0937276fc3002ae3cd4f4d0af3eab4e50d8172c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java 6 files changed, 67 insertions(+), 70 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0937276fc3002ae3cd4f4d0af3eab4e50d8172c Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, restapi: random rng source is implicit
by mbetak＠redhat.com 24 Oct '16

24 Oct '16

Martin Betak has submitted this change and it was merged. Change subject: core,restapi: random rng source is implicit ...................................................................... core,restapi: random rng source is implicit /dev/random is automatically required for hosts in all clusters. Change shouldn't affect existing hosts since they are expected to support /dev/random anyway. This patch: * splits Cluster#requiredRngSources to Cluster#additionalRngSource that holds required rng sources except for /dev/random (currently only /dev/hwrng) and #requiredRngSources that works as computed property based on #additionalRngSource. * renames 'required_rng_sources' to 'additional_rng_sources' in DB related code. I.e. /dev/random won't be mentioned in DB any more. * adds migration sql script removing 'RANDOM' from column additional_rng_sources table. * removes redundant RandomDeviceClusterEditChecker. * [restapi] To keep API backward compatible rng sources will still be available through <required-rng-sources>. /dev/random will be always shown to client and ignored when set by client. Change-Id: I8d39e6210a64a8cae6187deb5c2712934a5d54d5 Bug-Url: https://bugzilla.redhat.com/1337101 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RandomDeviceClusterEditChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategyTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/clusters_sp.sql A packaging/dbscripts/upgrade/04_01_0340_random_rng_source_required.sql 19 files changed, 91 insertions(+), 44 deletions(-) Approvals: Jakub Niedermertl: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d39e6210a64a8cae6187deb5c2712934a5d54d5 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: urllib from python-six
by sbonazzo＠redhat.com 24 Oct '16

24 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: urllib from python-six ...................................................................... packaging: setup: urllib from python-six Use python-six as compatibility layer for urllib. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1379674 Change-Id: I51b342619d66b1bd5a325a2eb592389d6b5a28ed Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .isort.cfg M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/check_liveliness.py M src/ovirt_hosted_engine_setup/ohttpshandler.py M src/ovirt_hosted_engine_setup/pkissh.py 5 files changed, 10 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51b342619d66b1bd5a325a2eb592389d6b5a28ed Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: urllib from python-six
by sbonazzo＠redhat.com 24 Oct '16

24 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: urllib from python-six ...................................................................... packaging: setup: urllib from python-six Use python-six as compatibility layer for urllib. Change-Id: I68aa9e643037e83a931495f6c5c608379844c0f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1379674 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68aa9e643037e83a931495f6c5c608379844c0f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Install built RPMs
by juan.hernandez＠redhat.com 24 Oct '16

24 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Install built RPMs ...................................................................... Install built RPMs In the past there have been situations where the built RPMs failed during installation, because they required packages that don't exist in the distribution. In order to detect that earlier in the future this patch changes the automation scripts so that the built RPMs are installed as part of the build process. Change-Id: I34352228f6b394ce9ad82d5a80a45056550b3d47 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit aa52a827fca3afbd6da116214b80fb591ad91bdc) --- D automation/build-artifacts.packages A automation/build-artifacts.packages.el7 A automation/build-artifacts.packages.fc23 A automation/build-artifacts.packages.fc24 R automation/build.packages.el7 C automation/build.packages.fc23 C automation/build.packages.fc24 M automation/build.py D automation/check-merged.packages A automation/check-merged.packages.el7 A automation/check-merged.packages.fc23 A automation/check-merged.packages.fc24 D automation/check-patch.packages A automation/check-patch.packages.el7 A automation/check-patch.packages.fc23 A automation/check-patch.packages.fc24 16 files changed, 29 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34352228f6b394ce9ad82d5a80a45056550b3d47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Require json >= 1.8 instead of >= 2.0
by juan.hernandez＠redhat.com 24 Oct '16

24 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Require json >= 1.8 instead of >= 2.0 ...................................................................... Require json >= 1.8 instead of >= 2.0 Currently the SDK requires version 2 or newer of the 'json' gem, but actually it doesn't need version 2, it can perfectly work with 1.8. In addition Fedora and CentOS provide version 1.8, so the RPM generated for the SDK won't work in those distributions. To solve this problem this patch changes the SDK so that it requires version 1.8. Change-Id: Ic1f5095c1f9181a91721484ab6838be78d4c0df4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 68e56414fe14e756ba842e27b3d8d38d96d736ac) --- M sdk/ovirt-engine-sdk.gemspec 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f5095c1f9181a91721484ab6838be78d4c0df4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Clarify that DiskAttachment.disk is only a link
by omachace＠redhat.com 24 Oct '16

24 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Clarify that DiskAttachment.disk is only a link ...................................................................... Clarify that DiskAttachment.disk is only a link This patch improves the example of how to list virtual machine disks in order to clarify that the DiskAttachment.disk attribute is only a link, and that in order to retrieve the actual disk data an additional request is required, for example using the 'follow_link' method. Change-Id: I32ad8628aa92bf45526dc5bb585f46befd85a49c Related-To: https://bugzilla.redhat.com/1387951 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmDisks.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32ad8628aa92bf45526dc5bb585f46befd85a49c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Clarify that DiskAttachment.disk is only a link
by omachace＠redhat.com 24 Oct '16

24 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Clarify that DiskAttachment.disk is only a link ...................................................................... Clarify that DiskAttachment.disk is only a link This patch improves the example of how to list virtual machine disks in order to clarify that the DiskAttachment.disk attribute is only a link, and that in order to retrieve the actual disk data an additional request is required, for example using the 'follow_link' method. Change-Id: Iae92b665622288afc13d176194223a4cc4366a7d Related-To: https://bugzilla.redhat.com/1387951 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/list_vm_disks.py 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae92b665622288afc13d176194223a4cc4366a7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Install built RPMs
by juan.hernandez＠redhat.com 24 Oct '16

24 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Install built RPMs ...................................................................... Install built RPMs In the past there have been situations where the built RPMs failed during installation, because they required packages that don't exist in the distribution. In order to detect that earlier in the future this patch changes the automation scripts so that the built RPMs are installed as part of the build process. Change-Id: I34352228f6b394ce9ad82d5a80a45056550b3d47 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D automation/build-artifacts.packages A automation/build-artifacts.packages.el7 A automation/build-artifacts.packages.fc23 A automation/build-artifacts.packages.fc24 R automation/build.packages.el7 C automation/build.packages.fc23 C automation/build.packages.fc24 M automation/build.py D automation/check-merged.packages A automation/check-merged.packages.el7 A automation/check-merged.packages.fc23 A automation/check-merged.packages.fc24 D automation/check-patch.packages A automation/check-patch.packages.el7 A automation/check-patch.packages.fc23 A automation/check-patch.packages.fc24 16 files changed, 29 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34352228f6b394ce9ad82d5a80a45056550b3d47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Require json >= 1.8 instead of >= 2.0
by juan.hernandez＠redhat.com 24 Oct '16

24 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Require json >= 1.8 instead of >= 2.0 ...................................................................... Require json >= 1.8 instead of >= 2.0 Currently the SDK requires version 2 or newer of the 'json' gem, but actually it doesn't need version 2, it can perfectly work with 1.8. In addition Fedora and CentOS provide version 1.8, so the RPM generated for the SDK won't work in those distributions. To solve this problem this patch changes the SDK so that it requires version 1.8. Change-Id: Ic1f5095c1f9181a91721484ab6838be78d4c0df4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ovirt-engine-sdk.gemspec 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f5095c1f9181a91721484ab6838be78d4c0df4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0