- Engine-commits - oVirt List Archives

Change in ovirt-live[master]: Fedora: add metrics packages
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fedora: add metrics packages ...................................................................... Fedora: add metrics packages Change-Id: I680b551d3d7373a91abe9090e3264f7cb4e85700 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M fedora-24/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I680b551d3d7373a91abe9090e3264f7cb4e85700 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: max-total increase reducing idle slaves
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: max-total increase reducing idle slaves ...................................................................... max-total increase reducing idle slaves With recent increase of the number of available slaves we're now able to increase the number of concurrent jobs. Change-Id: I9e04e5a1e1fdb766f786daab7fc2fdd9cdd224ae Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml M jobs/confs/yaml/templates/find-bugs.yaml M jobs/confs/yaml/templates/standard-stage.yaml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Anton Marchukov: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/65635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e04e5a1e1fdb766f786daab7fc2fdd9cdd224ae Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: image: use a coherent dialog name
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: image: use a coherent dialog name ...................................................................... image: use a coherent dialog name 'ovehosted_vmenv_mem' is already in use for the VM memory, using a different value for the disk size. It can affect automated tests over machine dialog. Change-Id: I1f58e36386a3526c56be0430ff39f434d0727ef3 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-common/vm/image.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f58e36386a3526c56be0430ff39f434d0727ef3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Fix CpuAndMemoryBalancingPolicyUnit
by msivak＠redhat.com 20 Oct '16

20 Oct '16

Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Fix CpuAndMemoryBalancingPolicyUnit ...................................................................... scheduling: Fix CpuAndMemoryBalancingPolicyUnit The unit considers CPU usage to choose VM for migration. Function VmDao.getAllRunningForVds() does not return VM with VmStatistics anymore. This patch fixes NPE caused by the missing VmStatistics. Change-Id: Iabad0025c4964790628c69b9a1c534adf843feaf Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnitTest.java 3 files changed, 69 insertions(+), 50 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/64950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabad0025c4964790628c69b9a1c534adf843feaf Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: automation: fix isort checkings
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: fix isort checkings ...................................................................... automation: fix isort checkings fixed isort checking. The test was not running on fc24 due to missing package in check-patch.packages Change-Id: I872de5966348af77534973c2c2f8d63f310488a1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .isort.cfg A automation/check-patch.packages.fc24 M src/ovirt_hosted_engine_setup/engineapi.py M src/ovirt_hosted_engine_setup/pkissh.py M src/plugins/gr-he-common/network/bridge.py M src/plugins/gr-he-common/sanlock/lockspace.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-setup/engine/add_host.py M src/plugins/gr-he-setup/network/firewall_manager.py M src/plugins/gr-he-setup/pki/vdsmpki.py M src/plugins/gr-he-setup/storage/storage.py M src/plugins/gr-he-upgradeappliance/engine/misc.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py 14 files changed, 30 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I872de5966348af77534973c2c2f8d63f310488a1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix coverity issue in VmModelBehaviorBase
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix coverity issue in VmModelBehaviorBase ...................................................................... webadmin: Fix coverity issue in VmModelBehaviorBase This fixes Coverity issue 1353386 (logical dead code in VmModelBehaviorBase:901) Change I4706419295d67f7a022a85bc61f75bb46def2b6b made CPU pinning always available for local data centers yet failed to remove the remaining logic this patch removes it. Change-Id: Ic4e8d7b87367354b6202d70e98c7ab0663ad1b46 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 1 insertion(+), 8 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e8d7b87367354b6202d70e98c7ab0663ad1b46 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add slf4j-log4j as test dependency
by omachace＠redhat.com 20 Oct '16

20 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add slf4j-log4j as test dependency ...................................................................... Add slf4j-log4j as test dependency This way the debug output of tests, and the debug output generated when running examples from the IDE, is written to the standard output, as configured in the 'src/test/resources/log4j.xml' file, otherwise it is just ignored. Change-Id: Icb86a8c4a47d57f02d3cd546bc46405e35e514b8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/pom.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb86a8c4a47d57f02d3cd546bc46405e35e514b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddAffinityGroupCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddAffinityGroupCommandTest @Spy annotation ...................................................................... core: AddAffinityGroupCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to use injected mocks instead of explicitly spying their return. Note that as the order of execution between @Mock and @Spy can't be relied upon the parameters objects was converted from a mock to a real instance. As this object is a simple data-POJO, there is no real reason to mock it anyway, and doing so just adds complexity to the test. Change-Id: I0daa7eedb9b63fa78e8eb11a12e43bc705e4165c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/AddAffinityGroupCommandTest.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0daa7eedb9b63fa78e8eb11a12e43bc705e4165c Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VM Numa command test setup unification
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: VM Numa command test setup unification ...................................................................... core: VM Numa command test setup unification Reworked the VM numa command test classes to have a unified setup, as they all currently copy-paste very similar boiler-plate code. As part of this reworking, a single command instance is annotated with a @Spy annotation in order to prepare this test for injecting DAOs as done in the subsequent patches. With this patch, the class is left with a single command instance which has a single instance of a list of numa nodes. Since these issues remain between tests, they need to be cleaned up in an @After method. Change-Id: Id6e9746f4cba3767e4948ae066149226927ee352 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java 5 files changed, 226 insertions(+), 398 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6e9746f4cba3767e4948ae066149226927ee352 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveAuditLogByIdCommandTest @Before annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveAuditLogByIdCommandTest @Before annotation ...................................................................... core: RemoveAuditLogByIdCommandTest @Before annotation Use the @Before annotation to set up the test instead of having to explicitly call prepareMocks(command) in each test case. Change-Id: I9a675e257aad9eb5fd3b57178485ab3328566b7e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a675e257aad9eb5fd3b57178485ab3328566b7e Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0