- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin: Sort VM instance images by disk alias
by tnisan＠redhat.com 10 Oct '16

10 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sort VM instance images by disk alias ...................................................................... webadmin: Sort VM instance images by disk alias Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Bug-Url: https://bugzilla.redhat.com/1381322 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Sort VM instance images by disk alias
by tnisan＠redhat.com 10 Oct '16

10 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sort VM instance images by disk alias ...................................................................... webadmin: Sort VM instance images by disk alias Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Bug-Url: https://bugzilla.redhat.com/1381322 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: vmpools: Check storage status before building disk map
by ahadas＠redhat.com 10 Oct '16

10 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: vmpools: Check storage status before building disk map ...................................................................... core: vmpools: Check storage status before building disk map To build storage-to-disk map safely, when all storage domains are down, moved ensureDestinationImageMap() call in CommonVmPoolCommand from init() to validate(), after checking storage pool status. Change-Id: I61f67c4f088b5782b4879e9dc9721cc156eebc0d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1359883 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61f67c4f088b5782b4879e9dc9721cc156eebc0d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: remove kvmEnable
by ahadas＠redhat.com 10 Oct '16

10 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: remove kvmEnable ...................................................................... webadmin: remove kvmEnable It is always set to true, thus not needed. Change-Id: I26647898af870db2fcd1de2cb2d52f64c082cfdd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 3 files changed, 1 insertion(+), 27 deletions(-) Approvals: Martin Betak: Looks good to me, approved Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26647898af870db2fcd1de2cb2d52f64c082cfdd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Sort VM instance images by disk alias
by tnisan＠redhat.com 10 Oct '16

10 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sort VM instance images by disk alias ...................................................................... webadmin: Sort VM instance images by disk alias Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Bug-Url: https://bugzilla.redhat.com/1381322 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified; Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida7f52c843c46d94b6a6e23530b483f098ed41b6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: spec: move engine/constants.py to engine-common package
by sbonazzo＠redhat.com 10 Oct '16

10 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: move engine/constants.py to engine-common package ...................................................................... spec: move engine/constants.py to engine-common package Keep the file in the same place in both source and installation target, but package it in ovirt-engine-setup-plugin-ovirt-engine-common, as it turns out that some external packages require constants from it. Change-Id: Ie389d11e9e2ea52a620b5ef23fefd8bca3bd8e12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie389d11e9e2ea52a620b5ef23fefd8bca3bd8e12 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add extern keyword to variables declared in headers
by juan.hernandez＠redhat.com 09 Oct '16

09 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add extern keyword to variables declared in headers ...................................................................... Add extern keyword to variables declared in headers Otherwise the XCode compiler used in Mac OS isn't able to complete the link. Change-Id: I17ddbb216b3952a6e25794982340d8aa4fa085b3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_http_client.c M sdk/ext/ovirtsdk4c/ov_http_client.h M sdk/ext/ovirtsdk4c/ov_http_request.c M sdk/ext/ovirtsdk4c/ov_http_request.h M sdk/ext/ovirtsdk4c/ov_http_response.c M sdk/ext/ovirtsdk4c/ov_http_response.h 6 files changed, 23 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17ddbb216b3952a6e25794982340d8aa4fa085b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Gluster role for network
by tnisan＠redhat.com 09 Oct '16

09 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Gluster role for network ...................................................................... restapi: Gluster role for network Support adding gluster role for network Bug-Url: https://bugzilla.redhat.com/1379225 Change-Id: I891cf5a26f6724a5665a7db9b6b3766b1be664e4 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/65218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I891cf5a26f6724a5665a7db9b6b3766b1be664e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix NPE on new instance image creation
by tnisan＠redhat.com 09 Oct '16

09 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE on new instance image creation ...................................................................... webadmin: Fix NPE on new instance image creation Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943 Bug-Url: https://bugzilla.redhat.com/1382357 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ceec10d297f44071f919b4e2dfd05728d64943 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: desktopLogin sends empty password, impacts desktop SSO ...
by mperina＠redhat.com 07 Oct '16

07 Oct '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: desktopLogin sends empty password, impacts desktop SSO feature ...................................................................... aaa: desktopLogin sends empty password, impacts desktop SSO feature The session password is not saved on engine and is only saved on SSO end. Engine should make a call to retrieve the encryped password from SSO and use its private key to decrypt the password. Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72 Bug-Url: https://bugzilla.redhat.com/1381606 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 4 files changed, 58 insertions(+), 36 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3048210dcc71a6eb4a732b347e57398213b9f72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0