- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.5]: aaa: Consolidate SSO session validation requests
by piotr.kliczewski＠gmail.com 07 Oct '16

07 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Consolidate SSO session validation requests ...................................................................... aaa: Consolidate SSO session validation requests Engine makes multiple queries to SSO to validate each exisitng session. This could cause performance issue when there are thousands of sessions. Combining all requests into one request to fetch all the statuses in one request can resolve the performance issue. When SSO clears an engine session associated with a token by invoking TerminateSessionsForToken SSO_ACCESS_TOKEN_PARAMETER value in the map is null. This can lead to problems when equality is checked with the contents of the map for the token. Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17 Bug-Url: https://bugzilla.redhat.com/1379805 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java 5 files changed, 58 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie63dd4e85ac4e4b25cd2884d07d84483dc8add17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Add extra debug information in AsyncTaskManager
by piotr.kliczewski＠gmail.com 07 Oct '16

07 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add extra debug information in AsyncTaskManager ...................................................................... engine: Add extra debug information in AsyncTaskManager Add extra debug information in AsyncTaskManager that logs polling and updating task statuses. Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Bug-Url: https://bugzilla.redhat.com/1374171 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InstallVdsInternalCommandTest @Spy
by amureini＠redhat.com 06 Oct '16

06 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: InstallVdsInternalCommandTest @Spy ...................................................................... core: InstallVdsInternalCommandTest @Spy Use the @Spy annotation to spy the command being tested in order to allow injecting mocks in subsequent patches. Change-Id: Id0a1cc86eec32c96d6d1c76173d7bbc24f81b18b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0a1cc86eec32c96d6d1c76173d7bbc24f81b18b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Improve column control menu
by awels＠redhat.com 06 Oct '16

06 Oct '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Improve column control menu ...................................................................... webadmin: Improve column control menu 1. replaced JavaScript/jQuery JSNI code with proper Java/GWT code to avoid performance issues & leaks 2. replaced up/down arrow icons on menu items with drag'n'drop Side note: HTML5 DnD spec is a _total_ mess. Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Bug-Url: https://bugzilla.redhat.com/1285499 Bug-Url: https://bugzilla.redhat.com/1368101 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnController.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ColumnContextMenu.css D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_no.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_yes.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_down.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_up.png 11 files changed, 328 insertions(+), 375 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved; Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/54186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't populate NetworkAttachment.network.name
by juan.hernandez＠redhat.com 06 Oct '16

06 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't populate NetworkAttachment.network.name ...................................................................... restapi: Don't populate NetworkAttachment.network.name Currently when the list of network attachments of a host is retrieved we return a link to the network that includes also the network name: GET /ovirt-engine/api/hosts/123/networkattachments <network_attachments> <network_attachment id="..." href="..."> ... <network id="..." href="...> <name>mynetwork</name> <-- This should't appear </network> </network_attachment> ... </network_attachments> This is not correct, as output links should not have any content other than the "id" and "href" attributes. This patch fixes that issue. Change-Id: Ie0eb5ba57a03f0e89c844d22969015ddf67a4134 Bug-Url: https://bugzilla.redhat.com/1382341 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0eb5ba57a03f0e89c844d22969015ddf67a4134 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add extra debug information in AsyncTaskManager
by oourfali＠redhat.com 06 Oct '16

06 Oct '16

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add extra debug information in AsyncTaskManager ...................................................................... engine: Add extra debug information in AsyncTaskManager Add extra debug information in AsyncTaskManager that logs polling and updating task statuses. Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Bug-Url: https://bugzilla.redhat.com/1374171 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3a84f280c24e8bd47096a0a7929223a4033d2ff Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: after dwh build for 4.0.5
by Shirly Radco 06 Oct '16

06 Oct '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after dwh build for 4.0.5 ...................................................................... build: after dwh build for 4.0.5 Change-Id: I07a1041377ca7497851005e87290e50992ee4be2 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a1041377ca7497851005e87290e50992ee4be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: dwh build for 4.0.5
by Shirly Radco 06 Oct '16

06 Oct '16

Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.0.5 ...................................................................... build: dwh build for 4.0.5 Change-Id: Idaf46d19144033b5ba7d5feee998a7ac9aa6801f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf46d19144033b5ba7d5feee998a7ac9aa6801f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Moved Quota from Vm to VmBase
by juan.hernandez＠redhat.com 06 Oct '16

06 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Moved Quota from Vm to VmBase ...................................................................... restapi: Moved Quota from Vm to VmBase Moving Quota from Vm to VmBase in the REST api model adds quota parameter to the Template in the api. Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838 Bug-Url: https://bugzilla.redhat.com/1379802 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 2 files changed, 12 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/64969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82a207be205e0e4f6c5740b7c9eaa54caafbc838 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.5]: restapi: Update to model 4.0.36
by tnisan＠redhat.com 06 Oct '16

06 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.36 ...................................................................... restapi: Update to model 4.0.36 The more relevant changes in the new version of the model are the following: * Add `gluster` value to the `NetworkUsage` enum. * Add `force` parameter to the operation that updates a storage server connection. * Move the `quota` link from the `Vm` type to the `VmBase` type. Change-Id: Icaeaf32c29cb972f87ab3613b5b9d0e12c3cf58e Related-To: https://bugzilla.redhat.com/1379802 Related-To: https://bugzilla.redhat.com/1379771 Related-To: https://bugzilla.redhat.com/1379225 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 17631488ee1538f7474aae3e39003d29a0e2643c) --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaeaf32c29cb972f87ab3613b5b9d0e12c3cf58e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0