- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix error message for storage not found
by rgolan＠redhat.com 11 Sep '16

11 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix error message for storage not found ...................................................................... core: Fix error message for storage not found Syntax for storage domain not found error message fixed to interpret the storage domain id correctly. Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: delete audit log records of reverted audit log type
by tnisan＠redhat.com 11 Sep '16

11 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0900_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: delete audit log records of reverted audit log type
by tnisan＠redhat.com 11 Sep '16

11 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0900_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: delete audit log records of reverted audit log type
by emesika＠redhat.com 11 Sep '16

11 Sep '16

Eli Mesika has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0290_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OsRepositoryImplTest printing
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: OsRepositoryImplTest printing ...................................................................... core: OsRepositoryImplTest printing Removed a useless printing to System.out. Change-Id: I6315d1e3978b49eec3be02d284758f8eec09e2db Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6315d1e3978b49eec3be02d284758f8eec09e2db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: config mocking in SysprepHandlerTest
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: config mocking in SysprepHandlerTest ...................................................................... core: config mocking in SysprepHandlerTest Remove the redundant config mocking from SysprepHandlerTest. Change-Id: I5c56000137490ba18d6f21d5daea1b205648c3f2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c56000137490ba18d6f21d5daea1b205648c3f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MTUValidator: Clean generics specification
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: MTUValidator: Clean generics specification ...................................................................... core: MTUValidator: Clean generics specification Remove the redundant "extends Object" from the generic specification. There is literally no way T can not extend Object. Change-Id: I8b8c9942318b8b0ee82e1604f728de8e2bb7e1b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8c9942318b8b0ee82e1604f728de8e2bb7e1b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove StandaloneDataSourceTest
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: Remove StandaloneDataSourceTest ...................................................................... core: Remove StandaloneDataSourceTest Removed an @Ignored, useless test. Change-Id: Ia7f099a2dd55cd397f9e872884a8980a4a0ffd98 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/db/StandaloneDataSourceTest.java 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7f099a2dd55cd397f9e872884a8980a4a0ffd98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove unused NumberRangeValidation
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Remove unused NumberRangeValidation ...................................................................... webadmin: Remove unused NumberRangeValidation Commit cd3f88a02851b7b46d07a712a69ec8843099c0f7 removed all the usages of NumberRangeValidation, except for the ones in NumberRangeValidationTestUtils (which was unused on its own right). This commit finishes the job and completely removes these two unused classes. Change-Id: Iea7a00d41a22c87dc68d1bd9541e23aa3e00065c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidation.java D frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidationTestUtils.java 2 files changed, 0 insertions(+), 187 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7a00d41a22c87dc68d1bd9541e23aa3e00065c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsCommandTypeTest @Theories
by mbetak＠redhat.com 09 Sep '16

09 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: VdsCommandTypeTest @Theories ...................................................................... core: VdsCommandTypeTest @Theories Use @Theories to clean up the test's code instead of reimplementing the same logic. Change-Id: Id345f0b76bc87f85bfac49a4e73ea55a6b4ae00a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/common/vdscommands/VdsCommandTypeTest.java 1 file changed, 10 insertions(+), 15 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id345f0b76bc87f85bfac49a4e73ea55a6b4ae00a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0