- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: set display/migration for cluster network
by emesika＠redhat.com 08 Sep '16

08 Sep '16

Eli Mesika has submitted this change and it was merged. Change subject: core: set display/migration for cluster network ...................................................................... core: set display/migration for cluster network The display and migration flag should be set for the default cluster network. The upgrade script that did that before in 03_05 and was squashed to the database used the name 'ManagementNetwork' to recognize this network. However, the name were changed to 'DefaultManagementNetwork' and this change is now running in the pre-upgrade step, so those flags update never occurred. This patch sets the correct value for display and migration flags for the default cluster network. Change-Id: Iae220e05b8908ea372c134db12f2c0fa5466b7de Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372955 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0280_display_migration_cluster_network.sql 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae220e05b8908ea372c134db12f2c0fa5466b7de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix NPE in SubTabHostVmView
by mbetak＠redhat.com 08 Sep '16

08 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: frontend: Fix NPE in SubTabHostVmView ...................................................................... frontend: Fix NPE in SubTabHostVmView Change-Id: I093b264f8fed4260400dd2126c65075cbe497edf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373475 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I093b264f8fed4260400dd2126c65075cbe497edf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix disk profile matching by storage domain
by tnisan＠redhat.com 08 Sep '16

08 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix disk profile matching by storage domain ...................................................................... core: Fix disk profile matching by storage domain Disk profile matching by storage domain was done incorrectly Taking under account only the storage domain default disk profile. Matching a disk profile by storage domain is now done against all disk profiles of that storage domain. Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit e20ff86) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix disk profile matching by storage domain
by rgolan＠redhat.com 08 Sep '16

08 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix disk profile matching by storage domain ...................................................................... core: Fix disk profile matching by storage domain Disk profile matching by storage domain was done incorrectly Taking under account only the storage domain default disk profile. Matching a disk profile by storage domain is now done against all disk profiles of that storage domain. Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: Revert "engine: add finish report on multi-host network comm...
by tnisan＠redhat.com 08 Sep '16

08 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: add finish report on multi-host network commands" ...................................................................... Revert "engine: add finish report on multi-host network commands" reverted upon request, due to bug (1372950) and also other bugs(?). This reverts commit 0ccb3ff4bf84108d4675b434067e2f6e05f6f2f3. Change-Id: Ieea40253f0519b92a1df038b5fc17fba4c7c9fb7 Bug-Url: https://bugzilla.redhat.com/1372950 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 11 files changed, 7 insertions(+), 279 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieea40253f0519b92a1df038b5fc17fba4c7c9fb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Set hosted engine maintenance mode to none after upgrade
by rgolan＠redhat.com 08 Sep '16

08 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: Set hosted engine maintenance mode to none after upgrade ...................................................................... core: Set hosted engine maintenance mode to none after upgrade When upgrading hosted engine host, the engine first moves it to maintenance mode in the engine and sets local maintenance to true on the host itself. After finishing the upgrade the engine sets the host status to up but doesn't change the local maintenance status of the host. This fix sets the local maintenance to false after upgrade if the host is a hosted engine host. Change-Id: I48f193b99dc8e71aef7e36532d36c551f9927ecd Bug-Url: https://bugzilla.redhat.com/1370907 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 38 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/62888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48f193b99dc8e71aef7e36532d36c551f9927ecd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add disk attachments collection to a VM in export d...
by tnisan＠redhat.com 08 Sep '16

08 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add disk attachments collection to a VM in export domain ...................................................................... restapi: Add disk attachments collection to a VM in export domain Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473 Bug-Url: https://bugzilla.redhat.com/1371024 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java 3 files changed, 75 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: improve getLunsToUpdateInDb
by tnisan＠redhat.com 08 Sep '16

08 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: backend: improve getLunsToUpdateInDb ...................................................................... backend: improve getLunsToUpdateInDb The method getLunsToUpdateInDb in SyncLunsInfoForBlockStorageDomainCommand used to iterate over lunsFromDb inside the iteration over lunsFromVgInfo, i.e run with a complexity of O(n^2), and the method updateLunsInDb used to make one db call for each update (existing lun that should be updated or a new lun). This patch is responsible for the following things: - Improves the complexity of getLunsToUpdateInDb to O(n) by using hash maps. - Makes less db calls - two calls in the worst case, one for updating all the luns that need to be updated and one for new luns. - Fixes a bug introduced by I9cfd2 - if lunsFromVgInfo had more luns than lunsFromDb, and it contained luns with a new pv id (not identical to any lun in lunsFromDb), they would not be updated (happens when a user manually extends a vg with a new pv without using oVirt). Now these luns will be updated. - Previously, if lunsFromVgInfo and lunsFromDb contained the same number of luns, but one of the luns in lunsFromVgInfo had a new pv id, it wouldn't be updated. Now it will. - Adds some tests to SyncLunsInfoForBlockStorageDomainCommandTest. Change-Id: I6b3f790b7a5c7bbed75ed4346d4f958cca0ed153 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 2 files changed, 113 insertions(+), 78 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/63277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b3f790b7a5c7bbed75ed4346d4f958cca0ed153 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: call getVgInfo after extending a storage domain
by tnisan＠redhat.com 08 Sep '16

08 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: backend: call getVgInfo after extending a storage domain ...................................................................... backend: call getVgInfo after extending a storage domain When extending a storage domain, we get the new luns' information from vdsm when calling ConnectAllHostsToLun (in validate()) and save it to the db. This causes an inconsistency between the luns' real info from the storage and their info as we save it in the db, for example a different physical volume id. Calling getVgInfo right after the extend itself gets us the new info, and saving the new info fixes this bug. Change-Id: I6a987f1f81f6ecad56a6854090fbba21131cbabd Bug-Url: https://bugzilla.redhat.com/1371960 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a987f1f81f6ecad56a6854090fbba21131cbabd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Remove null handling from PerHostMessages
by rgolan＠redhat.com 08 Sep '16

08 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Remove null handling from PerHostMessages ...................................................................... scheduling: Remove null handling from PerHostMessages Change-Id: I22040512ce2eb0496e13f30a386e96081ab39212 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PerHostMessages.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22040512ce2eb0496e13f30a386e96081ab39212 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0