- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CopyDataCommand - adding execution step
by laravot＠redhat.com 07 Sep '16

07 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyDataCommand - adding execution step ...................................................................... core: CopyDataCommand - adding execution step This patch adds the COPY_VOLUME execution step to be used by the CopyData command. Change-Id: I27591c8424aad4358d9d6328ae8b93ed4376098e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 4 files changed, 9 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27591c8424aad4358d9d6328ae8b93ed4376098e Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - execute endAction()
by laravot＠redhat.com 07 Sep '16

07 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - execute endAction() ...................................................................... core: StorageJobCallback - execute endAction() This patch adds execution of the endAction() method from the StorageJobCallback to perform the standard endAction() operations for StorageJob commands as well. Untill now, that wasn't relevant for those commands, as now we intend them to add command steps (added in commit 6833ee94) we need to execute the endAction to end those steps. Change-Id: I5dc940acd60cd956ce1905902b84773636b67120 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dc940acd60cd956ce1905902b84773636b67120 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add vdsm build-artifacts-manual jobs
by eedri＠redhat.com 07 Sep '16

07 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Add vdsm build-artifacts-manual jobs ...................................................................... Add vdsm build-artifacts-manual jobs Change-Id: I4e9b1f47a1181d12fed44b7331b676a657e10a02 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 35 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9b1f47a1181d12fed44b7331b676a657e10a02 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix match disk profile to storage domain
by piotr.kliczewski＠gmail.com 07 Sep '16

07 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix match disk profile to storage domain ...................................................................... core: Fix match disk profile to storage domain Problem cause: A. When a template has a disk which is allocated to more than one storage domain, it will contain for that disk image: - A list of storage domains - A list of disk profiles that belong to each storage domain B. Creating a VM from that template using REST will : - Select the first storage domain from the list - Select the first disk profile from the list Note : VM creation via UI selects a specific storage domain and a specific disk profile which is associated with that storage domain. There is no option to leave these values empty - unlike a REST call where these values can be dismissed. Consequence: In cases where the selected disk profile is not associated with the selected storage domain - the VM will not be created due to this inconsistency. Fix: The disk profile is selected according to the selected storage domain (out of the possible storage domains). Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 276df6effc6d14bc99fec4f75dfef97f30ef8d0d) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit 1f821c8) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 20 files changed, 247 insertions(+), 32 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix match disk profile to storage domain
by piotr.kliczewski＠gmail.com 07 Sep '16

07 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix match disk profile to storage domain ...................................................................... core: Fix match disk profile to storage domain Problem cause: A. When a template has a disk which is allocated to more than one storage domain, it will contain for that disk image: - A list of storage domains - A list of disk profiles that belong to each storage domain B. Creating a VM from that template using REST will : - Select the first storage domain from the list - Select the first disk profile from the list Note : VM creation via UI selects a specific storage domain and a specific disk profile which is associated with that storage domain. There is no option to leave these values empty - unlike a REST call where these values can be dismissed. Consequence: In cases where the selected disk profile is not associated with the selected storage domain - the VM will not be created due to this inconsistency. Fix: The disk profile is selected according to the selected storage domain (out of the possible storage domains). Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 276df6effc6d14bc99fec4f75dfef97f30ef8d0d) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 20 files changed, 247 insertions(+), 32 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adding ovirt-vmconsole build-artifacts and manual jobs
by eedri＠redhat.com 07 Sep '16

07 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Adding ovirt-vmconsole build-artifacts and manual jobs ...................................................................... Adding ovirt-vmconsole build-artifacts and manual jobs Change-Id: I0b7cb42aadbbadc3de96fb46d8c6579c03b13327 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_create-rpms.yaml A jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 4 files changed, 49 insertions(+), 4 deletions(-) Approvals: Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b7cb42aadbbadc3de96fb46d8c6579c03b13327 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: v2v VMware handle special chars in uri
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: v2v VMware handle special chars in uri ...................................................................... webadmin: v2v VMware handle special chars in uri VMware seems to allow all special chars for data center, folder and cluster name. We should handle it correctlly in v2v engine side by encoding those chars before sening them to VDSM. This solution encodes the VMware data center and VMware cluster parts of the uri i.e. for uri vpx://user@vcenter/DATACENTER/CLUSTER/esxi?no_verify=1 we encode the DATACENTER and CLUSTER parts, including folders if exists. Other parts of the uri are left decoded. In UI we continue to display the data center and cluster as was originally typed by the user (decoded). The encoding is done on frontend and therefore should be also done while using REST apis for v2v. known problems: If you include the following chars in VMware datacenter or cluster, the import failed: %, \, / -> error of "Could not find datacenter specified in uri..." appesrs &, +, =, ? -> error of "virt-v2v: internal error: invalid argument: cannot fetch XML" a bug is opened on libvirt/virt-v2v for that. Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb Bug-Url: https://bugzilla.redhat.com/1356767 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 3 files changed, 12 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/63484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: typo in tests
by amureini＠redhat.com 07 Sep '16

07 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: typo in tests ...................................................................... core: typo in tests Add missing "f". Change-Id: Ic7e3a281c0db476e3e0a4db4c0eac23328165a02 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommandTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7e3a281c0db476e3e0a4db4c0eac23328165a02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Add CDI and unit tests for CpuProfileHelper
by piotr.kliczewski＠gmail.com 07 Sep '16

07 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Add CDI and unit tests for CpuProfileHelper ...................................................................... core: Add CDI and unit tests for CpuProfileHelper Change-Id: I3dd1d953812f057801c97ee752868a9965344036 Bug-Url: https://bugzilla.redhat.com/1371888 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java 12 files changed, 160 insertions(+), 48 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd1d953812f057801c97ee752868a9965344036 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix cpu profile group permissions
by piotr.kliczewski＠gmail.com 07 Sep '16

07 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix cpu profile group permissions ...................................................................... core: Fix cpu profile group permissions Use PermissionDao to correctly check cpu profile user and group permissions. Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Bug-Url: https://bugzilla.redhat.com/1371888 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_views.sql 15 files changed, 65 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0