- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use SingleColumnRowMapper
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use SingleColumnRowMapper ...................................................................... core: Use SingleColumnRowMapper Reuse org.springframework.jdbc.core.SingleColumnRowMapper instead of reinventing the wheel. Change-Id: Ia6954a70cd39b8f0f552e2bd3fdf398121053016 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/IscsiBondDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDaoImpl.java 18 files changed, 50 insertions(+), 113 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6954a70cd39b8f0f552e2bd3fdf398121053016 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StepSubjectEntityDaoTest String.format
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StepSubjectEntityDaoTest String.format ...................................................................... core: StepSubjectEntityDaoTest String.format Remove a useless String.format call. Change-Id: If4e63f956f2c30b0c9c8c1d9f3c3d463efe4d793 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e63f956f2c30b0c9c8c1d9f3c3d463efe4d793 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DAO test members
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DAO test members ...................................................................... core: DAO test members Reduced scope of unneeded members and convert them to local variables, or remove them completely where possible. Change-Id: Ib402393c12d8effd162514bc19b6710f1c5240be Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsSpmIdMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java 9 files changed, 25 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib402393c12d8effd162514bc19b6710f1c5240be Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RepoFileMetaDataDaoTest duplicate key insert
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RepoFileMetaDataDaoTest duplicate key insert ...................................................................... core: RepoFileMetaDataDaoTest duplicate key insert Use the ExpectedException @Rule to fail testPrimaryKeyValidation() if the first insert throws an exception and ONLY pass if the second insert throws this exception. Change-Id: I1df18ad9e320895e745b4dbd3eafe6eee86f79d0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDaoTest.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1df18ad9e320895e745b4dbd3eafe6eee86f79d0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DAO tests static method access
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DAO tests static method access ...................................................................... core: DAO tests static method access Clean up code to correctly access static test methods. Change-Id: Ia40fe2ee529718952ffbba5902f052ed298cc86c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia40fe2ee529718952ffbba5902f052ed298cc86c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DAO tests collections
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DAO tests collections ...................................................................... core: DAO tests collections Use Collections.singletonList instead of Arrays.asList for single-item lists to improve performance. Change-Id: Id148cff67353b0cdadb156f3e8c2ed8d682d8be9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineSessionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java 10 files changed, 24 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id148cff67353b0cdadb156f3e8c2ed8d682d8be9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DbUserDaoTest TODO
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbUserDaoTest TODO ...................................................................... core: DbUserDaoTest TODO Remove a useless TODO comment Change-Id: Id54f0b7537c5ec3cc278af59505b7716024730d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDaoTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id54f0b7537c5ec3cc278af59505b7716024730d6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseDao method modifiers
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseDao method modifiers ...................................................................... core: BaseDao method modifiers Removed the pointless final modifiers from the class' static methods. Change-Id: I94c99c82462904c0a977b3db0fcf46499d3405b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94c99c82462904c0a977b3db0fcf46499d3405b3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DaoCdiIntegrationTest raw types
by amureini＠redhat.com 04 Sep '16

04 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DaoCdiIntegrationTest raw types ...................................................................... core: DaoCdiIntegrationTest raw types Solve annoying raw types warnings. Change-Id: Icf0419813b06f33899e534f898e2c3ebbbcdb5b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DaoCdiIntegrationTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf0419813b06f33899e534f898e2c3ebbbcdb5b3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add recipients list to failure email in check closure jobs
by eedri＠redhat.com 04 Sep '16

04 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Add recipients list to failure email in check closure jobs ...................................................................... Add recipients list to failure email in check closure jobs Change-Id: I3413b1ddf43f27eece642ca9cdab01fa089342e4 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/repos-check-closure.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3413b1ddf43f27eece642ca9cdab01fa089342e4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0