- Engine-commits - oVirt List Archives

Change in jenkins[master]: Changing repos_check_closure jobs email recipients
by eedri＠redhat.com 04 Sep '16

04 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Changing repos_check_closure jobs email recipients ...................................................................... Changing repos_check_closure jobs email recipients Change-Id: I7a754be0630cfef2248f90be27db0fed5cdb8168 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/repos-check-closure.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a754be0630cfef2248f90be27db0fed5cdb8168 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.5]: packaging: spec: exclude debug plugins
by didi＠redhat.com 04 Sep '16

04 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: spec: exclude debug plugins ...................................................................... packaging: spec: exclude debug plugins Without this, they are packaged both in 'otopi' and in 'otopi-debug-plugins'. Bug-Url: https://bugzilla.redhat.com/1365752 Change-Id: I723a191f85c6c64d6f19d215c0f4597dd3305b51 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723a191f85c6c64d6f19d215c0f4597dd3305b51 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: spec: exclude debug plugins
by didi＠redhat.com 04 Sep '16

04 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: spec: exclude debug plugins ...................................................................... packaging: spec: exclude debug plugins Without this, they are packaged both in 'otopi' and in 'otopi-debug-plugins'. Bug-Url: https://bugzilla.redhat.com/1365752 Change-Id: I723a191f85c6c64d6f19d215c0f4597dd3305b51 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723a191f85c6c64d6f19d215c0f4597dd3305b51 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: don't cast from Guid to StorageDomain
by tnisan＠redhat.com 03 Sep '16

03 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: don't cast from Guid to StorageDomain ...................................................................... webadmin: don't cast from Guid to StorageDomain This patch removes a wrong cast from the return type of getEntity() (Guid) to StorageDomain, and replaces it with a cast to Guid. Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Bug-Url: https://bugzilla.redhat.com/1371304 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/63118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.33
by tnisan＠redhat.com 03 Sep '16

03 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.33 ...................................................................... restapi: Update to model 4.0.33 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Related-To: https://bugzilla.redhat.com/1351576 Related-To: https://bugzilla.redhat.com/1337077 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromsServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java M pom.xml 12 files changed, 50 insertions(+), 49 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: log reason for stopping vm only if set
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: log reason for stopping vm only if set ...................................................................... core: log reason for stopping vm only if set Previously we always tried to include the stop reason when auditing VM stop operation. When no reason was set, either because it is not enabled in the cluster or the user simply did not enter a reason, the audit log included the following redundant message: (Reason: No reason was returned for this operation failure. See logs for further details.) This patch changes that so audit logs will include the stop reason only when it is set. That way, we avoid messages as shown above. Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Bug-Url: https://bugzilla.redhat.com/1340414 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> (cherry picked from commit 220f657dcd3de9919448106b06fe168fb510a3f2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: don't cast from Guid to StorageDomain
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: don't cast from Guid to StorageDomain ...................................................................... webadmin: don't cast from Guid to StorageDomain This patch removes a wrong cast from the return type of getEntity() (Guid) to StorageDomain, and replaces it with a cast to Guid. Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Bug-Url: https://bugzilla.redhat.com/1371304 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/63116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't add V3 guest IP to links
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Don't add V3 guest IP to links ...................................................................... restapi: Don't add V3 guest IP to links Currently the V3 compatibility layer tries to add the guest IP to all the returned objects of type "vm". That is wrong, as links, for example, shouldn't include such information. To solve the problem this patch changes the API so that the population of the guest IP is performed only for objects of type "vm" returned by the "list", "get", and "update" operations of the services that manage virtual machines. Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 371894f4b19605ebe10fe0e5e2cddd0146482c4a) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 71 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't add V3 disk attachment details to links
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Don't add V3 disk attachment details to links ...................................................................... restapi: Don't add V3 disk attachment details to links Currently the V3 compatibility layer tries to add the attachment details (bootable, etc) to all the returned objects of type "disk". That is wrong, as links, for example, shoundn't include such information. To solve the problem this patch changes the API so that the population of these details is performed only for objects of type "disk" returned by the "list", "get", and "update" operations of the services that manage virtual machine disks. Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9aa386f4ea54dd69e96fe87176a394ef6113d3ef) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 4 files changed, 49 insertions(+), 79 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal,webadmin: default refresh
by awels＠redhat.com 02 Sep '16

02 Sep '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: default refresh ...................................................................... userportal,webadmin: default refresh - Defaulted refresh to false Change-Id: I8bf4eef17f82bf1552f89b6cf450533d3837921b Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf4eef17f82bf1552f89b6cf450533d3837921b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0