- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Bind PluginActionButtonHandler as eager singleton
by vszocs＠redhat.com 25 Aug '16

25 Aug '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Bind PluginActionButtonHandler as eager singleton ...................................................................... webadmin: Bind PluginActionButtonHandler as eager singleton This fixes an issue where main/sub tab action buttons added by UI plugins would not appear at all. The handler class must be bound as eager singleton to ensure that all AddTabActionButtonEvent instances are processed. Change-Id: Ief464ec72b4b9e3cfdfc2a476c600f2e7501d094 Bug-Url: https://bugzilla.redhat.com/1369235 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/62289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief464ec72b4b9e3cfdfc2a476c600f2e7501d094 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Change DiskVmElement queries to User auth type
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change DiskVmElement queries to User auth type ...................................................................... core: Change DiskVmElement queries to User auth type Changed the DiskVmElement querties auth type to User to avoid problems in VM<->disk operations via REST/SDK Bug-Url: https://bugzilla.redhat.com/1369024 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementsByVmIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M packaging/dbscripts/disk_vm_element_sp.sql 6 files changed, 88 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.5]: packaging: otopi-1.5.2
by didi＠redhat.com 25 Aug '16

25 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: otopi-1.5.2 ...................................................................... packaging: otopi-1.5.2 Change-Id: If67d51b573c0647040683b533921c62597e3f43e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ChangeLog M automation/build-artifacts.sh M configure.ac M otopi.spec.in M po/pt_BR.po 5 files changed, 55 insertions(+), 49 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If67d51b573c0647040683b533921c62597e3f43e Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: webadmin: Rephrase Running VMs notification for Cluster Upgr
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Rephrase Running VMs notification for Cluster Upgr ...................................................................... webadmin: Rephrase Running VMs notification for Cluster Upgr Text of notification regarding running VMs after Cluster Version Change is changed. Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: webadmin: Rephrase Preview Snapshot warning
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Rephrase Preview Snapshot warning ...................................................................... webadmin: Rephrase Preview Snapshot warning User warning for preview live snapshot originating in different cluster version is rephrased. User needs to explicitely confirm the intention to restore the memory. Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: SuspendedVMClusterEditChecker removed
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: SuspendedVMClusterEditChecker removed ...................................................................... core: SuspendedVMClusterEditChecker removed Prior this change, Cluster Edit dialog displayed warning for suspended VMs when changing cluster level. This warning is no more needed, since it's covered by - more general warning in Cluster Edit - adding nextrun config - and setting temporal custom compatibility level on the VM This patch removes the checker and UI warning. Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 46 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, but someone else must approve Tal Nisan: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: webadmin: Count of affected VMs shown when CL change
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Count of affected VMs shown when CL change ...................................................................... webadmin: Count of affected VMs shown when CL change During Cluster Version change, count of affected (means not in Down state) VMs is displayed. All of them have to be rebooted once the cluster version is changed. Change-Id: I032e1816bbbc07e12f7721bda79cece6e6abf05f Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 5 files changed, 6 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I032e1816bbbc07e12f7721bda79cece6e6abf05f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: Block cluster version change when Snapshot in Preview
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Block cluster version change when Snapshot in Preview ...................................................................... core: Block cluster version change when Snapshot in Preview Block cluster version change in UpdateClusterVersion when there is a VM snapshot in preview. The webadmin shows list such VM names after Cluster Edit dialog. Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: Temporal VM CustCompatVer after Cluster Ver change
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Temporal VM CustCompatVer after Cluster Ver change ...................................................................... core: Temporal VM CustCompatVer after Cluster Ver change During Cluster Version change, set temporarily the VM Custom Compatibility Version. This change is reverted when the VM is rebooted and so the NextRun configuration is applied. Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 3 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change DiskVmElement queries to User auth type
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change DiskVmElement queries to User auth type ...................................................................... core: Change DiskVmElement queries to User auth type Changed the DiskVmElement querties auth type to User to avoid problems in VM<->disk operations via REST/SDK Bug-Url: https://bugzilla.redhat.com/1369024 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementsByVmIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java M packaging/dbscripts/disk_vm_element_sp.sql 7 files changed, 112 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0