- Engine-commits - oVirt List Archives

Change in jenkins[master]: Adding 4.0 ovirt image test job
by tlitovsk＠redhat.com 24 Aug '16

24 Aug '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: Adding 4.0 ovirt image test job ...................................................................... Adding 4.0 ovirt image test job Change-Id: I5ae9f24babdc8ccbbbb47ff33082f44a46695193 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/62775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae9f24babdc8ccbbbb47ff33082f44a46695193 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: build: ovirt-release40-4.0.3
by sbonazzo＠redhat.com 24 Aug '16

24 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release40-4.0.3 ...................................................................... build: ovirt-release40-4.0.3 Change-Id: Ie3764cd5713cf1d065928b32f91969290bdfa999 --- M configure.ac M ovirt-release40.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62780 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3764cd5713cf1d065928b32f91969290bdfa999 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: improve propriety UUID generation
by mperina＠redhat.com 24 Aug '16

24 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: improve propriety UUID generation ...................................................................... improve propriety UUID generation UUID generation is not random enough and may generate in some circumstances duplicate UUIDs I was thinking first to use the native PG UUID generator but this seems complex since the UUID generator functions are provided as a PG extension that only a super user DB role can install and even if we handled that in engine-setup, it will solve only local provisioned DB. In this patch I suggest the following improvements to the uuid_generate_v1 function 1) Setting a seed before using the random() function 2) Generating the first 8 characters using the clock timestamp value 3) Improve randomness of other generated values I believe that the above is a pretty simple solution that is sufficient for our needs Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1362459 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, restapi: Report version parts for host's os element
by masayag＠redhat.com 24 Aug '16

24 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: core,restapi: Report version parts for host's os element ...................................................................... core,restapi: Report version parts for host's os element The version parts of host's os are being parsed and reported properly as parsed from the host os: For RHEL: <os type="RHEL"> <version major="7" minor="2" full_version="7.2 - 9.el7"/> </os> For RHEV-H: <os type="RHEV Hypervisor"> <version major="7" minor="2" full_version="7.2 - 20160711.0.el7ev"/> </os> For ovirt-node: <os type="oVirt Node"> <version major="3" minor="6" full_version="3.6 - 0.999.201608161021.el7.centos"/> </os> Change-Id: Id845c71160f4af3b5bf9474beaaad3540ecafe3d Bug-Url: https://bugzilla.redhat.com/1368134 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OS.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSParserTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSTest.java 5 files changed, 96 insertions(+), 75 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/62627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id845c71160f4af3b5bf9474beaaad3540ecafe3d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move OS class to utils for reusability
by masayag＠redhat.com 24 Aug '16

24 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Move OS class to utils for reusability ...................................................................... core: Move OS class to utils for reusability Bug-Url: https://bugzilla.redhat.com/1368134 Change-Id: I6c1025f22e790521bdb8cf112e29c77cf501aadf Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/InClusterUpgradeValidator.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OS.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSParserTest.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSTest.java 6 files changed, 47 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/62626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c1025f22e790521bdb8cf112e29c77cf501aadf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Web consoles warnings
by tjelinek＠redhat.com 24 Aug '16

24 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Web consoles warnings ...................................................................... webadmin: Web consoles warnings Patternfly alert popup is in Spice HTML5 and noVNC if there is a problem to connect to the websocket proxy server. Warnings suggests to check that: * websocket proxy is running, * firewalls ares set * https is used (only for noVNC, Spice HTML5 can work with http) * app is accessed using predefined hostname (i.e. it doesn't work with e.g. numeric ip address as a hostname) * packages spice-html5/novnc are installed Both Spice HTML5 and noVNC now works with http. Internally it uses 'wss'. Previously it tried to use 'ws' with 'http' however websocket proxy server doesn't support 'ws'. novnc-main.html and spicehtml5-main.html were changed to JSP to allow includes to allow sharing html template. Encoding of *.jsp was set to UTF-8 in 'services' module. BrandingServlet was enabled for services module to get access to Patternfly resources. Change-Id: Ifdda870e13d77b24b95fe7109de377d560a0a86a Bug-Url: https://bugzilla.redhat.com/1036221 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/services/src/main/webapp/WEB-INF/warning-template.html M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml A backend/manager/modules/services/src/main/webapp/html-console-common.css A backend/manager/modules/services/src/main/webapp/html-console-common.js D backend/manager/modules/services/src/main/webapp/novnc-main.html A backend/manager/modules/services/src/main/webapp/novnc-main.jsp D backend/manager/modules/services/src/main/webapp/spicehtml5-main.html A backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java 10 files changed, 604 insertions(+), 430 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdda870e13d77b24b95fe7109de377d560a0a86a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make vm and disk commands use default quota
by rgolan＠redhat.com 24 Aug '16

24 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: Make vm and disk commands use default quota ...................................................................... core: Make vm and disk commands use default quota Commands for adding and updating VM or disk use default quota if null or empty guid is passed as quota id in parameters. Change-Id: I9f6dcb08a2a09465ace2cd27c43b5360727710cb Bug-Url: https://bugzilla.redhat.com/1297210 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 17 files changed, 405 insertions(+), 88 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/59830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6dcb08a2a09465ace2cd27c43b5360727710cb Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Moving the ng node builds to el7 mock
by tlitovsk＠redhat.com 24 Aug '16

24 Aug '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: Moving the ng node builds to el7 mock ...................................................................... Moving the ng node builds to el7 mock Change-Id: I40d67fd67a5aadf08d3c75ecfac3bf333da1246a Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Fabian Deutsch: Looks good to me Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/62477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40d67fd67a5aadf08d3c75ecfac3bf333da1246a Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: build: post ovirt-hosted-engine-ha-2.0.3
by sbonazzo＠redhat.com 24 Aug '16

24 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-2.0.3 ...................................................................... build: post ovirt-hosted-engine-ha-2.0.3 Change-Id: I6393181f39d62eea80e80e9dfc027ce3d070c6e4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6393181f39d62eea80e80e9dfc027ce3d070c6e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: build: ovirt-hosted-engine-ha-2.0.3
by sbonazzo＠redhat.com 24 Aug '16

24 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-2.0.3 ...................................................................... build: ovirt-hosted-engine-ha-2.0.3 Change-Id: I8122d0670f0e803e1f21ee59f9c244f093624eb2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8122d0670f0e803e1f21ee59f9c244f093624eb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0