- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: remove redundant dependencies from UpdateNetworkVali...
by masayag＠redhat.com 22 Aug '16

22 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant dependencies from UpdateNetworkValidator ...................................................................... engine: remove redundant dependencies from UpdateNetworkValidator Change-Id: I6218c36f372a7015812257bdc7ac63a9ba72a72c Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkValidatorTest.java 2 files changed, 2 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6218c36f372a7015812257bdc7ac63a9ba72a72c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Added missing links and files to the hooks directory.
by eedri＠redhat.com 22 Aug '16

22 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Added missing links and files to the hooks directory. ...................................................................... Added missing links and files to the hooks directory. - Added the following links: change-abandoned ==> hook-dispatcher change-merged ==> hook-dispatcher comment-added ==> hook-dispatcher patchset-created ==> hook-dispatcher config ==> /home/gerrit2/config - Added missing config file that holds all the required params (i.e GERRIT_SRV, BZ_USER, BZ_PASS etc) to gerrit2 home directory. Change-Id: I1ffb0fa8f3a364b96f4cd192a86ec6b4d32165ca Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- A hooks/change-abandoned A hooks/change-merged A hooks/comment-added A hooks/config R hooks/config_files/README R hooks/config_files/ovirt-engine.config R hooks/config_files/vdsm.config R hooks/custom_hooks/comment-added.propagate_review_values.py A hooks/custom_hooks/patchset-created.bz.1.bug_url A hooks/custom_hooks/patchset-created.bz.1.bug_url.sh M hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch R hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch.py M hooks/custom_hooks/update_tracker A hooks/patchset-created 14 files changed, 179 insertions(+), 24 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ffb0fa8f3a364b96f4cd192a86ec6b4d32165ca Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in destroy vm
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in destroy vm ...................................................................... core: cleanup in destroy vm 1. query vm dynamic data only if the vm is actually destroyed 2. rename curVm to vm (no other VM is defined) 3. remove unused argument from #changeStatus Change-Id: I4a168284a366b19b05ab2df1df3869f589eec78b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 6 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a168284a366b19b05ab2df1df3869f589eec78b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add label restriction to master repos-check-closure job
by eedri＠redhat.com 22 Aug '16

22 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Add label restriction to master repos-check-closure job ...................................................................... Add label restriction to master repos-check-closure job Restrict master repos-check-closure jobs to run on fc24 nodes. This is a temporary solution until the job will run in mock. Change-Id: I7bde43984ed83cea06ca7285eb588805dc0c26aa Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/repos-check-closure/repos-check-closure.yaml M jobs/confs/yaml/templates/repos-check-closure.yaml 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bde43984ed83cea06ca7285eb588805dc0c26aa Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant things from destroy vm
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove redundant things from destroy vm ...................................................................... core: remove redundant things from destroy vm Clear the assigned numa nodes in ProcessDownVm instead of in DestroyVm. The reason is that destroy VM is an asynchronous operation and the numa nodes should be cleared only when it succeeds. Change-Id: I5b124cdf39f97f7c91a6c53e20eaa44f1ae61ce1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 2 files changed, 14 insertions(+), 15 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b124cdf39f97f7c91a6c53e20eaa44f1ae61ce1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: Adding build-artifacts-manual.sh script
by rmartins＠redhat.com 22 Aug '16

22 Aug '16

Rafael Martins has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages and repos files. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: If196f18ca30da156bbcfc17ccf3f120c0f62bdab Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.repos A automation/build-artifacts-manual.sh 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If196f18ca30da156bbcfc17ccf3f120c0f62bdab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: commands that query vms to use only vds id
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: commands that query vms to use only vds id ...................................................................... core: commands that query vms to use only vds id We currently pass a cloned instance of the whole VDS object which is redundant, so changing this to pass only its id. Change-Id: Ie5c68b22bb24710180e74b1eca7f84251c88a927 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java 7 files changed, 15 insertions(+), 23 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c68b22bb24710180e74b1eca7f84251c88a927 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by omachace＠redhat.com 22 Aug '16

22 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I7cbdcef3fa8a1f4babc45a81a07b945162e79e1a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M generator/pom.xml M pom.xml M sdk/pom.xml 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cbdcef3fa8a1f4babc45a81a07b945162e79e1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix monitoring of guest agent nics
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix monitoring of guest agent nics ...................................................................... core: fix monitoring of guest agent nics We used to to compare the hash that is being calculated by the engine (of network interfaces reported by the guest agent) with the hash in the dynamic VM data reported by VDSM. The problem is that VDSM doesn't report this hash, therefore it is always zero and therefore we update the dynamic data of a VM that is installed with guest agent on each monitoring cycle. This patch fixes this by changing the mentioned check so the computed hash will be compared to the one that was calculated previously. Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: log num of running vms only upon change
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: log num of running vms only upon change ...................................................................... core: log num of running vms only upon change The log of the number of running VMs on a host flooded the engine log. Therefore, adding some logic in order to log it only when the number of running VMs on a host is changed. Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Bug-Url: https://bugzilla.redhat.com/1367519 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsStatisticsFetcher.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0