- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: Block cluster version change when Snapshot in Preview
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Block cluster version change when Snapshot in Preview ...................................................................... core: Block cluster version change when Snapshot in Preview Block cluster version change in UpdateClusterVersion when there is a VM snapshot in preview. The webadmin shows list such VM names after Cluster Edit dialog. Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Switch from cirrus to vga at cluster upgrade
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Switch from cirrus to vga at cluster upgrade ...................................................................... core: Switch from cirrus to vga at cluster upgrade VNC/cirrus is switched to VNC/vga when upgrading cluster from 3.6 to 4.0. Change-Id: Ib249ccf07247cd737c295b074bfb6dddb8de5292 Bug-Url: https://bugzilla.redhat.com/1302657 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib249ccf07247cd737c295b074bfb6dddb8de5292 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add Original Template link to Vm
by juan.hernandez＠redhat.com 22 Aug '16

22 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add Original Template link to Vm ...................................................................... restapi: Add Original Template link to Vm The VM resource is enriched for Original Template. Change-Id: I8973ba30ebf29cb91b7849b7fe913d5dcf187809 Bug-Url: https://bugzilla.redhat.com/1333045 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/60457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8973ba30ebf29cb91b7849b7fe913d5dcf187809 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: automation: add isort check
by lveyde＠redhat.com 22 Aug '16

22 Aug '16

Lev Veyde has submitted this change and it was merged. Change subject: automation: add isort check ...................................................................... automation: add isort check Added isort check for python code Change-Id: I4a511edeaf343de1b6cf2201ec77a4ecc3a041cb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/check-patch.req.fc24 A ovirt-engine-setup-plugin-live/.isort.cfg M ovirt-engine-setup-plugin-live/build/python.inc M ovirt-engine-setup-plugin-live/configure.ac 4 files changed, 28 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Looks good to me, approved Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a511edeaf343de1b6cf2201ec77a4ecc3a041cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: scheduling: Log exception instead of printStackTrace
by dfediuck＠redhat.com 22 Aug '16

22 Aug '16

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: Log exception instead of printStackTrace ...................................................................... core: scheduling: Log exception instead of printStackTrace Change-Id: I79eb8f152e649f6515d0c6a1e0ffbfccbac07457 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79eb8f152e649f6515d0c6a1e0ffbfccbac07457 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Rephrase Running VMs notification for Cluster Upgrade
by tjelinek＠redhat.com 22 Aug '16

22 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Rephrase Running VMs notification for Cluster Upgrade ...................................................................... webadmin: Rephrase Running VMs notification for Cluster Upgrade Text of notification regarding running VMs after Cluster Version Change is changed. Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/62437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Release 4.0.0.a6
by omachace＠redhat.com 22 Aug '16

22 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Release 4.0.0.a6 ...................................................................... Release 4.0.0.a6 Change-Id: Ife6ec61e2ad59c62fca40b1c1b0cd5d436e34ab0 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M packaging/build.sh M sdk/lib/ovirtsdk4/version.py M sdk/setup.py 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6ec61e2ad59c62fca40b1c1b0cd5d436e34ab0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fix monitoring of guest agent nics
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix monitoring of guest agent nics ...................................................................... core: fix monitoring of guest agent nics We used to to compare the hash that is being calculated by the engine (of network interfaces reported by the guest agent) with the hash in the dynamic VM data reported by VDSM. The problem is that VDSM doesn't report this hash, therefore it is always zero and therefore we update the dynamic data of a VM that is installed with guest agent on each monitoring cycle. This patch fixes this by changing the mentioned check so the computed hash will be compared to the one that was calculated previously. Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: determine the order of vm statistics updates
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: determine the order of vm statistics updates ...................................................................... core: determine the order of vm statistics updates Update VM statistics data according to the order of the VM analyzers in VmsMonitoring. Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: make VmBase comparable
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: make VmBase comparable ...................................................................... core: make VmBase comparable The comparison is done according to the ID of the VM. Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0