- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateHostValidatorTest type inference
by amureini＠redhat.com 10 Aug '16

10 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateHostValidatorTest type inference ...................................................................... core: UpdateHostValidatorTest type inference Change-Id: Ie95c07e9ab43a52618f10b814e25db2e486a1d61 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95c07e9ab43a52618f10b814e25db2e486a1d61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: added missing mapping for el7 ppc64le
by eedri＠redhat.com 10 Aug '16

10 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: added missing mapping for el7 ppc64le ...................................................................... added missing mapping for el7 ppc64le - Added missing ppc64le mappings to el7 and fedora 24 files in mock runner - Removed epel debug repos since they don't exists for ppc64le and we don't need them Change-Id: Idbc279b726b3c53666402fe1289c153f8fbc78c2 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M mock_configs/epel-7-ppc64le.cfg M mock_configs/epel-7-ppc64le_proxied.cfg M mock_configs/mock_runner.sh 3 files changed, 2 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/62122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc279b726b3c53666402fe1289c153f8fbc78c2 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cache vm static data needed for monitoring
by ahadas＠redhat.com 10 Aug '16

10 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cache vm static data needed for monitoring ...................................................................... core: cache vm static data needed for monitoring Cache the data we need for the monitoring in VmManager. Change-Id: I2e168460a00c887b00cb26c819bc2dc23e706f32 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e168460a00c887b00cb26c819bc2dc23e706f32 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Ignore failures fetching cluster policy
by juan.hernandez＠redhat.com 09 Aug '16

09 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Ignore failures fetching cluster policy ...................................................................... restapi: Ignore failures fetching cluster policy Currently when a cluster is fetched in version 3 of the API an additional query is performed to retrieve the details of its associated scheduling policy, as that is how it used to work. But this additional query may require additional permissions for some users, and when this happens the complete cluster fetch fails. To alleviate that problem this patch changes the API so that failures to fetch the scheduling policy will just be ignored. As most users won't be interersted in those details this should solve most use cases. When a user without the required permissions fetches the cluster she will get only the reference, and not the details: GET /clusters Authorization: myuser@mydomain:... Filter: true <cluster id="123" href="/clusters/123"> ... <scheduling_policy id="456" href="/schedulingpolicies/456"/> ... </cluster> When the user has the required permissions he will get all the details of the scheduling policy. Change-Id: I23b0ef3830f8291d725fa8fce241c8e0c12309be Bug-Url: https://bugzilla.redhat.com/1364048 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ClusterOutAdapter.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23b0ef3830f8291d725fa8fce241c8e0c12309be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: edit VM - update instance image when needed
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: edit VM - update instance image when needed ...................................................................... webadmin: edit VM - update instance image when needed Edit VM dialog: invoking UpdateVmDisk only if an instance image disk was edited. Change-Id: I998e8c573c8afaf45668729cf15fb0ebe3edbad5 Bug-Url: https://bugzilla.redhat.com/1364780 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/62160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I998e8c573c8afaf45668729cf15fb0ebe3edbad5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate CommandEntityCleanupManager to CDI
by masayag＠redhat.com 09 Aug '16

09 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: backend: Migrate CommandEntityCleanupManager to CDI ...................................................................... backend: Migrate CommandEntityCleanupManager to CDI Change-Id: I1332e750bd89519f29dc5532e449a5a285e5cdd8 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandEntityCleanupManager.java 2 files changed, 14 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1332e750bd89519f29dc5532e449a5a285e5cdd8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate AutoRecoveryManager to CDI
by masayag＠redhat.com 09 Aug '16

09 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: backend: Migrate AutoRecoveryManager to CDI ...................................................................... backend: Migrate AutoRecoveryManager to CDI Also replaced usage of custom callback interfaces in conjunction with anonymous inner classes with Java 8 lambdas and standard functional interfaces. Change-Id: I34586b62f8c7d293cdf9090b2d2f290020a8870a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java 3 files changed, 84 insertions(+), 98 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34586b62f8c7d293cdf9090b2d2f290020a8870a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate JobRepositoryCleanupManager to CDI
by masayag＠redhat.com 09 Aug '16

09 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: backend: Migrate JobRepositoryCleanupManager to CDI ...................................................................... backend: Migrate JobRepositoryCleanupManager to CDI Change-Id: Ic0cd86ff09d913eaa73c995ea493510d0e79b1b8 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java 2 files changed, 20 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0cd86ff09d913eaa73c995ea493510d0e79b1b8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate Command[Context]Cache to CDI
by masayag＠redhat.com 09 Aug '16

09 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: backend: Migrate Command[Context]Cache to CDI ...................................................................... backend: Migrate Command[Context]Cache to CDI Change-Id: I3bc882ef28a06afff56bd62b8f4e6f825c124619 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java 3 files changed, 33 insertions(+), 18 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bc882ef28a06afff56bd62b8f4e6f825c124619 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Migrate JobRepository to CDI
by masayag＠redhat.com 09 Aug '16

09 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: backend: Migrate JobRepository to CDI ...................................................................... backend: Migrate JobRepository to CDI Change-Id: I24de287cdf85c30ef484f63aabc10a85b406eaa0 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobByJobIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByCorrelationIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepByStepIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java 14 files changed, 99 insertions(+), 71 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24de287cdf85c30ef484f63aabc10a85b406eaa0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0