- Engine-commits - oVirt List Archives

Change in jenkins[master]: Moving create-rpms-manual jobs to standard-ci
by eedri＠redhat.com 11 Aug '16

11 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Moving create-rpms-manual jobs to standard-ci ...................................................................... Moving create-rpms-manual jobs to standard-ci It will now be called build-artifacts-manual Change-Id: Ib9570d56dd229d30063e469ea34b902f05c00711 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A jobs/confs/groovy-scripts/build-artifacts-manual-any_get-target-jobs.groovy A jobs/confs/shell-scripts/build-artifacts-manual_any.sh A jobs/confs/shell-scripts/standard_build_artifacts_manual.sh M jobs/confs/yaml/builders/standard.yaml A jobs/confs/yaml/templates/build-artifacts-manual-any_template.yaml M jobs/confs/yaml/templates/standard-stage.yaml M jobs/confs/yaml/triggers/standard.yaml 7 files changed, 133 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9570d56dd229d30063e469ea34b902f05c00711 Gerrit-PatchSet: 10 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: RM EnumUtils#ConvertToStringWithSpaces
by amureini＠redhat.com 11 Aug '16

11 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: RM EnumUtils#ConvertToStringWithSpaces ...................................................................... webadmin: RM EnumUtils#ConvertToStringWithSpaces EnumUtils#ConvertToStringWithSpaces is a GWT-override of a method that no longer exists. As it's never used (and doesn't actually do anything besides returning null), it can safely be removed. Change-Id: I9c15a15ba22f58faaf46eff8dedc3b7d23ae0c22 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/EnumUtils.java 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c15a15ba22f58faaf46eff8dedc3b7d23ae0c22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: moving a common method to AbstractDiskModel
by derez＠redhat.com 11 Aug '16

11 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: moving a common method to AbstractDiskModel ...................................................................... webadmin: moving a common method to AbstractDiskModel Moving a common method (getStorageDomainId) to AbstractDiskModel from EditDiskModel and ReadOnlyDiskModel. Change-Id: Id74c85beac3de24b4a5735bf6bc6af003d300956 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 3 files changed, 10 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved; Passed CI tests Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74c85beac3de24b4a5735bf6bc6af003d300956 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix taskhandler init - RemoveDisksSnapshot
by derez＠redhat.com 11 Aug '16

11 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: engine: Fix taskhandler init - RemoveDisksSnapshot ...................................................................... engine: Fix taskhandler init - RemoveDisksSnapshot The method initTaskHandlers is called every time that the command is initiated. In RemoveDiskSnapshotsCommand, the number of task handlers created was different after that the former handler finished its operation. This situation created a mismatch between the task handler map in BaseCommand and the command execution index. In this patch, the images IDs are computed only once and not every time that the initTaskHandlers is invoked, keeping the number of task handlers consistent. Also, the task handlers are not created if it is a live merge flow. Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c Bug-Url: https://bugzilla.redhat.com/1365393 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java 1 file changed, 7 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/62158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupCommand - set CopyImageGroupWithData end...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupCommand - set CopyImageGroupWithData end procedure ...................................................................... core: CopyImageGroupCommand - set CopyImageGroupWithData end procedure This patch sets the CopyImageGroupWithData end procedure to be command managed. as its not executed by CopyImageGroupCommand. The change as no functional effect (as the end method performs nothing anyway), but its more correct. Change-Id: I3e99f0c614f26908a7541b73241f36d5ffb21ce5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e99f0c614f26908a7541b73241f36d5ffb21ce5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCommand to inherit from CommandBase ...................................................................... core: StorageJobCommand to inherit from CommandBase This patch changes StorageJobCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AllocateImageGroupVolumeCommand.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CloneImageGroupVolumesStructureCommand to inherit from...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructureCommand to inherit from CommandBase ...................................................................... core: CloneImageGroupVolumesStructureCommand to inherit from CommandBase This patch changes CloneImageGroupVolumesStructureCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: I1a74daa3915bbc66738e6743176df85cd8f19590 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a74daa3915bbc66738e6743176df85cd8f19590 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getVolumeInfoVDS command execution moved to ImagesHandler
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: getVolumeInfoVDS command execution moved to ImagesHandler ...................................................................... core: getVolumeInfoVDS command execution moved to ImagesHandler This patch moves the vds getVolumeInfo() usage to the ImagesHandler so it can be used easily by classes that are not part of the BaseImagesCommand hierarchy. Change-Id: I2c1743dfa3fcc8b0e237334ef1200393bc86c5dd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 3 files changed, 13 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1743dfa3fcc8b0e237334ef1200393bc86c5dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupWithDataCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupWithDataCommand to inherit from CommandBase ...................................................................... core: CopyImageGroupWithDataCommand to inherit from CommandBase This patch changes CopyImageGroupWithDataCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: Ief1802a6527783d587b0e0c057d3adcbd50fd463 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief1802a6527783d587b0e0c057d3adcbd50fd463 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupVolumesDataCommand to inherit from Comma...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupVolumesDataCommand to inherit from CommandBase ...................................................................... core: CopyImageGroupVolumesDataCommand to inherit from CommandBase This patch changes CopyImageGroupVolumesDataCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and no other methods from BaseImagesCommand are used, so this patch just changes the class to inherit from the base command class. Change-Id: Ic5b2dd83124286f223f417635b8dd83bc049c67e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b2dd83124286f223f417635b8dd83bc049c67e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0