- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Validate affinity label name length
by rgolan＠redhat.com 28 Jul '16

28 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: core: Validate affinity label name length ...................................................................... core: Validate affinity label name length Added validation for affinity label name length before it fails on postgres. Added all violations attributes to the messages returned from ValidationUtils, that way all the attributes are exposed and can be used in error messages. Change-Id: I8f0cc33a60d5b0e8035d4ec793f4161c96fade96 Bug-Url: https://bugzilla.redhat.com/1350230 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LabelActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Label.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 85 insertions(+), 2 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/60477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f0cc33a60d5b0e8035d4ec793f4161c96fade96 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.1.3
by stirabos＠redhat.com 28 Jul '16

28 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.1.3 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.1.3 Change-Id: Ie8646d8aee43621cd55b43ee184ff23a47a69e78 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved; Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8646d8aee43621cd55b43ee184ff23a47a69e78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: Upload drop-down menu button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Upload drop-down menu button ...................................................................... webadmin: Upload drop-down menu button Added 'Upload' drop-down menu button to Disks tab to consolidate Start/Cancel/Pause resume commands. Before: http://i.imgur.com/yWbcCSO.png After: http://i.imgur.com/v1aCFJe.png Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 33 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: resize upload image dialog
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: resize upload image dialog ...................................................................... webadmin: resize upload image dialog Resized 'Upload Image' dialog to accommodate its widgets more properly. Before: http://imgur.com/a/Pyecu After: http://imgur.com/a/KX8ht Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: image upload - align selection button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - align selection button ...................................................................... webadmin: image upload - align selection button Image Upload dialog: align 'Choose File' button properly. Screenshot: http://imgur.com/a/7jRwK Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: rename getTemplateVolumeType method
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: rename getTemplateVolumeType method ...................................................................... webadmin: rename getTemplateVolumeType method Renamed getTemplateVolumeType to a clearer one by its functionality: getVolumeType. Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: image upload - remove volume type list
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - remove volume type list ...................................................................... webadmin: image upload - remove volume type list Image upload dialog: * Removed 'Allocation Policy' select-box. * Filled volume format select-box with COW/RAW. The patch is making use of an existing logic that infers volume type (getTemplateVolumeType method). I.e. * For file domains: Sparse volume type. * For block domains: Sparse if COW / Preallocated if RAW. Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Allow passing of scheduling policy name for Update ...
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Allow passing of scheduling policy name for Update Cluster ...................................................................... restapi: Allow passing of scheduling policy name for Update Cluster This patch will enable auto-completion for the scheduling policy name in the SDK. Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315657 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: resize upload image dialog
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: resize upload image dialog ...................................................................... webadmin: resize upload image dialog Resized 'Upload Image' dialog to accommodate its widgets more properly. Before: http://imgur.com/a/Pyecu After: http://imgur.com/a/KX8ht Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - align selection button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - align selection button ...................................................................... webadmin: image upload - align selection button Image Upload dialog: align 'Choose File' button properly. Screenshot: http://imgur.com/a/7jRwK Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0