- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: rename getTemplateVolumeType method
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: rename getTemplateVolumeType method ...................................................................... webadmin: rename getTemplateVolumeType method Renamed getTemplateVolumeType to a clearer one by its functionality: getVolumeType. Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - remove volume type list
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - remove volume type list ...................................................................... webadmin: image upload - remove volume type list Image upload dialog: * Removed 'Allocation Policy' select-box. * Filled volume format select-box with QCOW/RAW. The patch is making use of an existing logic that infers volume type (getTemplateVolumeType method). I.e. * For file domains: Sparse volume type. * For block domains: Sparse if COW / Preallocated if RAW. Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Upload drop-down menu button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Upload drop-down menu button ...................................................................... webadmin: Upload drop-down menu button Added 'Upload' drop-down menu button to Disks tab to consolidate Start/Cancel/Pause resume commands. Before: http://i.imgur.com/yWbcCSO.png After: http://i.imgur.com/v1aCFJe.png Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 33 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core : Updates should not be checked on hosts on maintenance
by masayag＠redhat.com 28 Jul '16

28 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core : Updates should not be checked on hosts on maintenance ...................................................................... core : Updates should not be checked on hosts on maintenance VdsManager should not check for updates for host if the host is in maintenance. Change-Id: I9ae1a2a0bd0cb63477f491dc5f2bb9def8cc52b4 Bug-Url: https://bugzilla.redhat.com/1343562 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ae1a2a0bd0cb63477f491dc5f2bb9def8cc52b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FiltersHelper: Remove unused code
by amureini＠redhat.com 27 Jul '16

27 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: FiltersHelper: Remove unused code ...................................................................... core: FiltersHelper: Remove unused code Removed unused members and methods. Change-Id: I3aae45e1bf9b4176357ca807ee21286141482685 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aae45e1bf9b4176357ca807ee21286141482685 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: sso: text fixes in login page, remove placeholder
by gshereme＠redhat.com 27 Jul '16

27 Jul '16

Greg Sheremeta has submitted this change and it was merged. Change subject: sso: text fixes in login page, remove placeholder ...................................................................... sso: text fixes in login page, remove placeholder PatternFly specifies: * no placeholders in username and password fields * label of username field is "Username" (not "User Name") * page title should be "Log In" (not "Login") * Log-In button should be "Log In" (not "Login") * Log-In button should be large size Fixed the above. Change-Id: I337f10183d2d49c8012c0aa6b6c17cee9dd65314 Bug-Url: https://bugzilla.redhat.com/1347109 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/resources/messages.properties M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp 2 files changed, 9 insertions(+), 11 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/61564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I337f10183d2d49c8012c0aa6b6c17cee9dd65314 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: Make sure used is always <= total
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Make sure used is always <= total ...................................................................... webadmin: Make sure used is always <= total - In certain situations it is possible that the DWH is reporting used > 0 while total = 0. This patch makes sure that used can never be higher than total. Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360403 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationResourceSummary.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: core: protection from NPE in the initialization of RunVm
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: protection from NPE in the initialization of RunVm ...................................................................... core: protection from NPE in the initialization of RunVm Need to verify that the VM to run exists before accessing it. Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Bug-Url: https://bugzilla.redhat.com/1360265 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: engine: fix background image on welcome and login pages
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: fix background image on welcome and login pages ...................................................................... engine: fix background image on welcome and login pages Apply the background image technique used in patternfly's login page pattern to the welcome and login pages. This change will prevent the background image from being truncated if the welcome or login page is made short enough to scroll. Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e Bug-Url: https://bugzilla.redhat.com/1347807 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M packaging/branding/ovirt.brand/common.css 9 files changed, 339 insertions(+), 355 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/61423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: fix background image on welcome and login pages
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: fix background image on welcome and login pages ...................................................................... engine: fix background image on welcome and login pages Apply the background image technique used in patternfly's login page pattern to the welcome and login pages. This change will prevent the background image from being truncated if the welcome or login page is made short enough to scroll. Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e Bug-Url: https://bugzilla.redhat.com/1347807 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M packaging/branding/ovirt.brand/common.css 9 files changed, 339 insertions(+), 355 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/61422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0