- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: build: post ovirt-engine-4.0.2 rc1
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.2 rc1 ...................................................................... build: post ovirt-engine-4.0.2 rc1 Change-Id: I9bcec3ed5cff8ccce0ed2724aa2b347cf5e6238d Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 59 files changed, 65 insertions(+), 62 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bcec3ed5cff8ccce0ed2724aa2b347cf5e6238d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: build: ovirt-engine-4.0.2 rc1
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-4.0.2 rc1 ...................................................................... build: ovirt-engine-4.0.2 rc1 Change-Id: Ie74deecf6188435be8616c9eb89841a1ae941e77 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 60 files changed, 64 insertions(+), 64 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie74deecf6188435be8616c9eb89841a1ae941e77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: build: post ovirt-engine-4.0.2 branching
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.2 branching ...................................................................... build: post ovirt-engine-4.0.2 branching Change-Id: I32b3a6c624fd0de67ece3a63f5c4ad8bf12715a9 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 57 files changed, 60 insertions(+), 57 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32b3a6c624fd0de67ece3a63f5c4ad8bf12715a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Guest Info subtab name token fixed
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Guest Info subtab name token fixed ...................................................................... webadmin: Guest Info subtab name token fixed Switching selected VM in VMs main tab caused FE exception when 'Guest Info' subtab was selected because 'SubTabVirtualMachineGuestInfoPresenter' was registered with old @NameToken "sessions" instead of "guest_info". Change-Id: I21dcaea379ecac457b590d99e0de56673b49fd0b Bug-Url: https://bugzilla.redhat.com/1357630 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21dcaea379ecac457b590d99e0de56673b49fd0b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: correct lock in UpdateVmDynamicData
by ahadas＠redhat.com 20 Jul '16

20 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: correct lock in UpdateVmDynamicData ...................................................................... core: correct lock in UpdateVmDynamicData This patch fixes the following bug: UpdateVmDynamicData is supposed to take VM lock so the monitoring won't override the changes, but instead of locking the VM to be updated, it always locked the blank template (empty guid). Change-Id: I94638190a94082f7dd42019ceabc6ed1ccb53cad Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVmDynamicDataVDSCommandParameters.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94638190a94082f7dd42019ceabc6ed1ccb53cad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not rely on resource manager to clear interface sta...
by ahadas＠redhat.com 20 Jul '16

20 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not rely on resource manager to clear interface statistics ...................................................................... core: do not rely on resource manager to clear interface statistics SetVmStatus used to rely on ResourceManager#internalSetVmStatus to clear the network interface statistics, if needed. But it was done without loading the network interfaces first. So this patch removes this redundant part for now and add a TODO comment to fix this. Change-Id: I89b3ec50b5f4ce10e3f9fabfc7997b4401d25d06 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b3ec50b5f4ce10e3f9fabfc7997b4401d25d06 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal, webadmin: show single exception alert.
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: show single exception alert. ...................................................................... userportal,webadmin: show single exception alert. - Update the alert panel to only show a single alert at once instead of multiple. If more than one is shown now show a counter of the number of alerts. This is achieved using a bootstrap 'badge'. - Updated the tooltip associated with the alert to show all the alerts. Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1320559 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java 4 files changed, 78 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Cluster version update locks all VMs
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Cluster version update locks all VMs ...................................................................... core: Cluster version update locks all VMs Updating cluster version needs to call UpdateVmCommand to update VM devices (https://gerrit.ovirt.org/#/c/55636/) This patch adds locking of all necessary VMs in the UpdateClusterCommand if version is being changed. Locks are passed to UpdateVmCommand by setting LockProperties scope to None. Backport only change: initialization of UpdateClusterCommand#oldGroup was moved from validate() method to init() + tests. Inspired by patch https://gerrit.ovirt.org/#/c/50756. Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 75 insertions(+), 33 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: fix dao tests path search string
by sbonazzo＠redhat.com 20 Jul '16

20 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix dao tests path search string ...................................................................... fix dao tests path search string - removed double equal inside array - moved paths into array format Change-Id: I1aeb9c90827d0f09672b69267740fe746d56fc64 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M automation/check-patch.sh 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, approved Eyal Edri: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aeb9c90827d0f09672b69267740fe746d56fc64 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: show single exception alert.
by awels＠redhat.com 19 Jul '16

19 Jul '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: show single exception alert. ...................................................................... userportal,webadmin: show single exception alert. - Update the alert panel to only show a single alert at once instead of multiple. If more than one is shown now show a counter of the number of alerts. This is achieved using a bootstrap 'badge'. - Updated the tooltip associated with the alert to show all the alerts. Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1320559 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java 4 files changed, 78 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0