- Engine-commits - oVirt List Archives

Change in jenkins[master]: periodic decrease of 20 days for warning & abandoning
by amarchuk＠redhat.com 19 Jul '16

19 Jul '16

Anton Marchukov has submitted this change and it was merged. Change subject: periodic decrease of 20 days for warning & abandoning ...................................................................... periodic decrease of 20 days for warning & abandoning Change-Id: I62c1bd7a8b6a1ad51f31fad9d5ed089756b20c81 Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Anton Marchukov: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62c1bd7a8b6a1ad51f31fad9d5ed089756b20c81 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: tools: Rephrase privacy protocol description
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: tools: Rephrase privacy protocol description ...................................................................... tools: Rephrase privacy protocol description Rephrase the description for SNMP_PRIVACY_PROTOCOL to make it clear that not all SNMP servers support AES192 and AES256 protocols. Change-Id: I3be8fc9b7d74d0116a775051705d41eccb6142ed Bug-Url: https://bugzilla.redhat.com/1354452 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit b66e38b60f0ea2645accb32cfcb2e26d91a10009) --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3be8fc9b7d74d0116a775051705d41eccb6142ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Added information about maintenance modes in the man page.
by sbonazzo＠redhat.com 19 Jul '16

19 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added information about maintenance modes in the man page. ...................................................................... Added information about maintenance modes in the man page. Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335952 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M man/hosted-engine.8 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: error fix
by masayag＠redhat.com 19 Jul '16

19 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: error fix ...................................................................... core: error fix error caused by wrong rebase. Change-Id: I2ed6f1e1df2bcfff53b540a16a4a75178911d406 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/qos/PersistentHostSetupNetworksParametersFactoryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed6f1e1df2bcfff53b540a16a4a75178911d406 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: run setup-upgrade job per patch for master
by sbonazzo＠redhat.com 19 Jul '16

19 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: run setup-upgrade job per patch for master ...................................................................... run setup-upgrade job per patch for master Change-Id: I57664c202c91d748b3c2bb6b8555e3836af10d61 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57664c202c91d748b3c2bb6b8555e3836af10d61 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Logging of VmPoolMonitor fixed
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Logging of VmPoolMonitor fixed ...................................................................... core: Logging of VmPoolMonitor fixed * Log message about failed VM prestarting was not always printed. E.g. when there was only one VM in the pool. Fixed. * Log level of failures during prestarting was changed from INFO to WARN. * Ids of VMs that failed to prestart were added to the log. Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50 Bug-Url: https://bugzilla.redhat.com/1346848 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 17 insertions(+), 18 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: show descriptive error on illegal max value
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show descriptive error on illegal max value ...................................................................... core: show descriptive error on illegal max value Show descriptive error on illegal max value in search engine. This patch fixes an issue when illegal negative max value is passed to the search engine. The problem was that the default value for the max parameter was -1 which was translated as "no max parameter given" so all records should be retrieved. Instead of that, the default value was changed to Integer.MAX_VALUE In addition, in case of RuntimeException, the exception was swallowed by SearchQuery::initQueryData method and therefor the error was not returned to the API call. I changed that such that a RuntimeException will be thrown again after writing to the log. Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352953 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 3 files changed, 8 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: NPE on new instance type dialog
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE on new instance type dialog ...................................................................... webadmin: NPE on new instance type dialog The getOverrideMigrationPolicy().getEntity() may be null in some cases (new instance type) causing a NPE in and if statement. Fixed by having a null safe check. Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Bug-Url: https://bugzilla.redhat.com/1357440 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix UI exception after creating new profile
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix UI exception after creating new profile ...................................................................... webadmin: Fix UI exception after creating new profile This prevents a race occuring when the query result from syncSearch has returned and fetchProfiles() was called yet the entity meanwhile was changed to null Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Bug-Url: https://bugzilla.redhat.com/1354547 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/ProfileListModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0.alpha13
by omachace＠redhat.com 19 Jul '16

19 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.0.alpha13 ...................................................................... [maven-release-plugin] prepare release 4.0.0.alpha13 Change-Id: I2a310d2c3b4d805c919288213050683f9b23f0e5 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a310d2c3b4d805c919288213050683f9b23f0e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0