- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use only vm static data in vm-pool monitor
by ahadas＠redhat.com 19 Jul '16

19 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm static data in vm-pool monitor ...................................................................... core: use only vm static data in vm-pool monitor Replace the costly query of VM with a lighter query for VmStatic. Change-Id: I805e571cb4b68a8776e47f6d8bd6b4098208c122 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805e571cb4b68a8776e47f6d8bd6b4098208c122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refine daos in vm-pool monitor
by ahadas＠redhat.com 19 Jul '16

19 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refine daos in vm-pool monitor ...................................................................... core: refine daos in vm-pool monitor Inject VmDao and VmPoolDao instead of using DbFacade. Change-Id: I6d0904962b2aea4e98931053392f51effbc6aa99 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d0904962b2aea4e98931053392f51effbc6aa99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not attempt to update interface statistics on destr...
by ahadas＠redhat.com 19 Jul '16

19 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not attempt to update interface statistics on destroy vm ...................................................................... core: do not attempt to update interface statistics on destroy vm Now that DestroyVm only sets the VM status to powering down and wait for the monitoring to detect that the VM is actually down, DestroyVm should not update the network interface statistics anymore. Change-Id: I23f97757c73be64b6b579ae6e0730ab1ad9a58ce Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23f97757c73be64b6b579ae6e0730ab1ad9a58ce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example of adding VM snapshot
by juan.hernandez＠redhat.com 19 Jul '16

19 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of adding VM snapshot ...................................................................... Add example of adding VM snapshot This patch adds an example that shows how to add a snapshot to an existing virtual machine. Change-Id: Ia4bbbdc0bc72eeaf152e4d4bb76e89cc7f20a016 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5b69af6c6995449bbc3fd0a3a0b202903d7832d5) --- A sdk/examples/add_vm_snapshot.rb 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4bbbdc0bc72eeaf152e4d4bb76e89cc7f20a016 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update script which makes all macs in mac_pool_ranges ...
by oourfali＠redhat.com 19 Jul '16

19 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: update script which makes all macs in mac_pool_ranges in lowercase ...................................................................... core: update script which makes all macs in mac_pool_ranges in lowercase Change-Id: I14891e6849b01eca95af961491f5700419a5bec9 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0160_update_macs_to_lower_case.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14891e6849b01eca95af961491f5700419a5bec9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example of adding VM snapshot
by juan.hernandez＠redhat.com 19 Jul '16

19 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of adding VM snapshot ...................................................................... Add example of adding VM snapshot This patch adds an example that shows how to add a snapshot to an existing virtual machine. Change-Id: Ia4bbbdc0bc72eeaf152e4d4bb76e89cc7f20a016 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_vm_snapshot.rb 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4bbbdc0bc72eeaf152e4d4bb76e89cc7f20a016 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: show descriptive error on illegal max value
by mperina＠redhat.com 19 Jul '16

19 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: core: show descriptive error on illegal max value ...................................................................... core: show descriptive error on illegal max value Show descriptive error on illegal max value in search engine. This patch fixes an issue when illegal negative max value is passed to the search engine. The problem was that the default value for the max parameter was -1 which was translated as "no max parameter given" so all records should be retrieved. Instead of that, the default value was changed to Integer.MAX_VALUE In addition, in case of RuntimeException, the exception was swallowed by SearchQuery::initQueryData method and therefor the error was not returned to the API call. I changed that such that a RuntimeException will be thrown again after writing to the log. Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352953 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 3 files changed, 8 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: when persisting or updating mac pool into db, store ma...
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: when persisting or updating mac pool into db, store macs in lowercase ...................................................................... core: when persisting or updating mac pool into db, store macs in lowercase The assumption is that stored mac-pool ranges are in lower case should apply also to the fixtures file. Change-Id: I6021925eaa5cccd58c24c1f98c0ab0d9abf54511 Bug-Url: https://bugzilla.redhat.com/1324125 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_00_0840_update_macs_to_lower_case.sql 4 files changed, 17 insertions(+), 14 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6021925eaa5cccd58c24c1f98c0ab0d9abf54511 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: v2v-"external provider" refreshed by DC
by tjelinek＠redhat.com 19 Jul '16

19 Jul '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: v2v-"external provider" refreshed by DC ...................................................................... webadmin: v2v-"external provider" refreshed by DC In v2v import dialog, the "External Provider" field values in pull down menu are refreshed if the selected "Data Center" field value is changed (The same as done if "Source" field value is changes). The values on the "Exteranl Provider" field pull down menu are according to the current selected data center and source. Change-Id: Ie28722599ec2e6e1c108bf1d5479e6700e05cae4 Bug-Url: https://bugzilla.redhat.com/1354495 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/60930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie28722599ec2e6e1c108bf1d5479e6700e05cae4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Edit VM Pool always shows the first storage domain
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: Edit VM Pool always shows the first storage domain ...................................................................... Edit VM Pool always shows the first storage domain If template exists in more then one storage domain, edit vm pool always points to the first logical storage domain. (edit pool->resource allocation->disks allocation). When increase VMs to the pool the disks will be allocated always in the first logical storage domain. Change-Id: I289ac1c74fb721cb050b060d70dab39016b67122 Bug-Url: https://bugzilla.redhat.com/1356488 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmDataByPoolIdQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I289ac1c74fb721cb050b060d70dab39016b67122 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0