- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: no vm statistics update on destroy vm
by ahadas＠redhat.com 18 Jul '16

18 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: no vm statistics update on destroy vm ...................................................................... core: no vm statistics update on destroy vm Now that on destroy VM we always set the status of the VM to powering down, the VMs monitoring is responsible to clear the VM statistics when detecting that the VM went down. Change-Id: I974ff4f9efbcfc7975d92fc09695324c06bcba5f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I974ff4f9efbcfc7975d92fc09695324c06bcba5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: no interface statistics update on vm hand over
by ahadas＠redhat.com 18 Jul '16

18 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: no interface statistics update on vm hand over ...................................................................... core: no interface statistics update on vm hand over There is no point in saving network interface statistics when doing the hand over for migrated VM - the VM is up and might use the network. Change-Id: I12377d6e28c9d5fb8eec1bbd63885eb08ded2dbc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12377d6e28c9d5fb8eec1bbd63885eb08ded2dbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add permits to cluster level
by juan.hernandez＠redhat.com 18 Jul '16

18 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add permits to cluster level ...................................................................... restapi: Add permits to cluster level This patch adds to the cluster level service the list of supported permits. For example, to get the list of permits supported by cluster level 4.0 a request like this will be used: GET /ovirt-engine/api/clusterlevels/4.0 The result will contain the following: <cluster_level id="4.0" href="/ovirt-engine/api/clusterlevels/4.0"> ... <permits> <permit id="1"> <name>create_vm</name> <administrative>false</administrative> </permit> ... </permits> </clsuter_level> Change-Id: Ie3959ebdade60c758487f2a7d1e4e204eccdde7f Bug-Url: https://bugzilla.redhat.com/1355647 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.adoc D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermitResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermitResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermitsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PermitMapperTest.java 10 files changed, 71 insertions(+), 334 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3959ebdade60c758487f2a7d1e4e204eccdde7f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: NPE on new instance type dialog
by tjelinek＠redhat.com 18 Jul '16

18 Jul '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NPE on new instance type dialog ...................................................................... webadmin: NPE on new instance type dialog The getOverrideMigrationPolicy().getEntity() may be null in some cases (new instance type) causing a NPE in and if statement. Fixed by having a null safe check. Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Bug-Url: https://bugzilla.redhat.com/1357440 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Return LowUtiliztion parameter to power saving policy
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Return LowUtiliztion parameter to power saving policy ...................................................................... core: Return LowUtiliztion parameter to power saving policy The LowUtilization parameter was removed from power saving policy. This patch returns it. Change-Id: I3026a9d22e404836d2581afeb1e21f513981cdf2 Bug-Url: https://bugzilla.redhat.com/1351556 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 053ce5e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/60851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3026a9d22e404836d2581afeb1e21f513981cdf2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.6
by juan.hernandez＠redhat.com 18 Jul '16

18 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.6 ...................................................................... restapi: Update to model 4.1.6 The more relevant changes in the new version of the model are the following: * Add the `originalTemplate` link to the virtual machine type. * Add `permits` to the cluster level type. * Add the `current` parameter to the virtual machine graphics consoles service. * Fix the name of the output parameter of the method to list affinity groups, should be `groups` instead of `list`. Change-Id: I2bf6100d27cfb85aa2aed63fcc70ee7b6d92a5a4 Related-To: https://bugzilla.redhat.com/1355647 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bf6100d27cfb85aa2aed63fcc70ee7b6d92a5a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix VMs/Templates disks link
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix VMs/Templates disks link ...................................................................... restapi: Fix VMs/Templates disks link Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa Bug-Url: https://bugzilla.redhat.com/1356649 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> (cherry picked from commit 8db57b2d9d5a5ade0c96427f1804ce68d192ff07) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: fix initial loading of domainType value
by stirabos＠redhat.com 18 Jul '16

18 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: fix initial loading of domainType value ...................................................................... upgrade: fix initial loading of domainType value Fix the initial loading of domainType value from hosted-engine.conf since otherwise on upgrades it's not possible to load the initial answer file from the shared storage if on glusterFS. Change-Id: I87220f33497e2fcb5dd54e30ab0667a708d61afc Bug-Url: https://bugzilla.redhat.com/1356221 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-rollbackupgrade/core/misc.py M src/plugins/gr-he-upgradeappliance/core/misc.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87220f33497e2fcb5dd54e30ab0667a708d61afc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix VMs/Templates disks link
by juan.hernandez＠redhat.com 18 Jul '16

18 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix VMs/Templates disks link ...................................................................... restapi: Fix VMs/Templates disks link Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa Bug-Url: https://bugzilla.redhat.com/1356649 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b810448affdf93136dac46eb72cc5002d5d4fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: bll: search: don't replace all ocurrence of pattern
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: bll: search: don't replace all ocurrence of pattern ...................................................................... bll: search: don't replace all ocurrence of pattern Previously we replaced all occurances of pattern in search text, which could lead in replacing unwanted characters. This patch changes the behaviour in a way, that we just replace first found characters. Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356675 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 85642149c1780dd943b2aef817f586b7defb0cc2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0