- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bll: search: don't replace all ocurrence of pattern
by mperina＠redhat.com 18 Jul '16

18 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: bll: search: don't replace all ocurrence of pattern ...................................................................... bll: search: don't replace all ocurrence of pattern Previously we replaced all occurances of pattern in search text, which could lead in replacing unwanted characters. This patch changes the behaviour in a way, that we just replace first found characters. Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356675 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Upload drop-down menu button
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Upload drop-down menu button ...................................................................... webadmin: Upload drop-down menu button Added 'Upload' drop-down menu button to Disks tab to consolidate Start/Cancel/Pause resume commands. Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Before: http://i.imgur.com/yWbcCSO.png After: http://i.imgur.com/v1aCFJe.png Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 33 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/60699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Disk upload dialog - update image type
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disk upload dialog - update image type ...................................................................... webadmin: Disk upload dialog - update image type Disk Upload dialog: 'Image Type' select-box - format should be selected according to the StorageType and VolumeType. Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Bug-Url: https://bugzilla.redhat.com/1353229 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 15 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/60700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Remove code duplication in v2v providers
by mbetak＠redhat.com 18 Jul '16

18 Jul '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Remove code duplication in v2v providers ...................................................................... backend: Remove code duplication in v2v providers The KVM, Vmware and XEN ProviderProxies contained significtant portion of duplicate that was extracted into new AbstractVmProviderProxy base class. For this purpose also their respective parameter classes now extend VmProviderProperties class containing shared fields on which AbstractVmProviderProxy depends. Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/AbstractVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/KVMVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/XENVmProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/KVMVmProviderProperties.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmwareVmProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/XENVmProviderProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 136 insertions(+), 248 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Disable Scan disks option for Export and ISO.
by mlipchuk＠redhat.com 18 Jul '16

18 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Disable Scan disks option for Export and ISO. ...................................................................... webadmin: Disable Scan disks option for Export and ISO. Scan Disks option should be disabled for export and ISO storage domain. Change-Id: I8ce142e5e1bff0aeeb0e44cad97990a1c4fd3502 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ce142e5e1bff0aeeb0e44cad97990a1c4fd3502 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: disk tab - storage domain selection on upload
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disk tab - storage domain selection on upload ...................................................................... webadmin: disk tab - storage domain selection on upload Disk tab -> upload: Data Center and Storage Domains select-boxes should be changeable. Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Bug-Url: https://bugzilla.redhat.com/1352928 Bug-Url: https://bugzilla.redhat.com/1352855 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: image upload - propagate validation messages
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: core: image upload - propagate validation messages ...................................................................... core: image upload - propagate validation messages Propagate validation messages in UploadDiskImageCommand. Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Bug-Url: https://bugzilla.redhat.com/1352857 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: MoveOrCopyDisk - adjusting to dc with HSM data operations
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: MoveOrCopyDisk - adjusting to dc with HSM data operations ...................................................................... MoveOrCopyDisk - adjusting to dc with HSM data operations Change-Id: Iab47a9e52dc7fed75bb9866e4bfa63bf90dc85de Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab47a9e52dc7fed75bb9866e4bfa63bf90dc85de Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroup - adjusting to dc with HSM data operations
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroup - adjusting to dc with HSM data operations ...................................................................... core: CopyImageGroup - adjusting to dc with HSM data operations Change-Id: I76e25e72523800b59301a7cc0e7886af0a2de805 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 90 insertions(+), 53 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e25e72523800b59301a7cc0e7886af0a2de805 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CloneImageGroupVolumesStructure - support disks based ...
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructure - support disks based on templates ...................................................................... core: CloneImageGroupVolumesStructure - support disks based on templates This patch adjusts CloneImageGroupVolumesStructureCommand to support disks based on template disks. The command will inspect the cloned image, if it's based on template the template image group id will be used as the source image group. Change-Id: I2232a97f62f4ad8d25b0cc18db84941661c6b947 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2232a97f62f4ad8d25b0cc18db84941661c6b947 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0